diff mbox series

[02/10] accel/tcg: Unconditionally use CPU_DUMP_CCOP in log_cpu_exec

Message ID 20250428201028.1699157-3-richard.henderson@linaro.org
State New
Headers show
Series accel/tcg: Compile cpu-exec.c twice | expand

Commit Message

Richard Henderson April 28, 2025, 8:10 p.m. UTC 
This flag is only tested by target/i386, so including this
makes no functional change.  This is similar to other places
like cpu-target.c which use CPU_DUMP_CCOP unconditionally.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
We could just as easily remove CPU_DUMP_CCOP entirely, and let
target/i386 dump CCOP along with general regs like other targets.
---
 accel/tcg/cpu-exec.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Pierrick Bouvier April 28, 2025, 9:37 p.m. UTC | #1 
On 4/28/25 1:10 PM, Richard Henderson wrote:
> This flag is only tested by target/i386, so including this
> makes no functional change.  This is similar to other places
> like cpu-target.c which use CPU_DUMP_CCOP unconditionally.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> We could just as easily remove CPU_DUMP_CCOP entirely, and let
> target/i386 dump CCOP along with general regs like other targets.
> ---
>   accel/tcg/cpu-exec.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
diff mbox series

Patch

diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
index 8ff4a34509..ff979a2c57 100644
--- a/accel/tcg/cpu-exec.c
+++ b/accel/tcg/cpu-exec.c
@@ -285,14 +285,11 @@  static void log_cpu_exec(vaddr pc, CPUState *cpu,
         if (qemu_loglevel_mask(CPU_LOG_TB_CPU)) {
             FILE *logfile = qemu_log_trylock();
             if (logfile) {
-                int flags = 0;
+                int flags = CPU_DUMP_CCOP;
 
                 if (qemu_loglevel_mask(CPU_LOG_TB_FPU)) {
                     flags |= CPU_DUMP_FPU;
                 }
-#if defined(TARGET_I386)
-                flags |= CPU_DUMP_CCOP;
-#endif
                 if (qemu_loglevel_mask(CPU_LOG_TB_VPU)) {
                     flags |= CPU_DUMP_VPU;
                 }