From patchwork Tue Apr 29 05:00:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 885708 Delivered-To: patch@linaro.org Received: by 2002:a5d:4884:0:b0:38f:210b:807b with SMTP id g4csp143412wrq; Mon, 28 Apr 2025 22:02:32 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVQTP2I7xNMPtR11T91x2vBvG+OMlBhULhhA+JslV1HjCBnQtCVp++pJaZ0831vgRMWfirg6w==@linaro.org X-Google-Smtp-Source: AGHT+IGodxa4k5nfE/eJzvYw8OqRaQrm2UxNP/v1veKBclsnoLc3uuqv1kAhEQH1SA4LS6VoQIER X-Received: by 2002:ac8:7d43:0:b0:476:aa36:d674 with SMTP id d75a77b69052e-48131de3bd7mr191141171cf.28.1745902952768; Mon, 28 Apr 2025 22:02:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1745902952; cv=none; d=google.com; s=arc-20240605; b=QdXCyogP4DWefzdHSfZhyF2WepDf7RYR5Gz8tOxgdv0GY7bSmFlhDFTTIEtbIWvRbQ NdzTOga+UtfdB5FE77QM7NKvvDXHg/QJHF1A8X64Nc1I86TKThgOms2DQit42p8hn5Lw 5gQWDhZQhXaxF2rZkrf4DjZsmnlmejxDIturcmljEI88ms1z9BSYzXqHw9LQaVR7FUB4 HpGVdihIwX0ENbPrX0Et6L7SBtt65qYOJgWkq8aAOd9RBD1mv17NZnNX1rnDKx7VacyM IiSwN3ujFAYu218ep9G9UDQX7lwSQ4X9JfagQGFzBAT/aujRtwHX873NWaAsDpyiSe8m +idA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=oGLga5UEOZhK97fJQViOQTJRGL03WkVBEBC/7bd6T1M=; fh=O4yhk4V8tvPJDnLnyAX1De4ll2cui8YfCZlHtNTUPp4=; b=ZhZ+RYqAFONAhzOK2h7/MYBrWHScO12xBjTzIoRXNZrL31W73almbYFJ/afmFJ+HZM BVt0JyztNyIq92/azVNzkiFvJ1mUpTSEASJ9fE9Z9FJvUtbdtH9aPC7r3HWYBlm2KJZW ifkuVWi3w3cRX9UucSRa20D5nh2HWEmNA9aeA6S39vlkFTOMJfyM4AGDpCbZN4CfcpxU LtJUT3YnvonEzD/0uuzANDslbaT44C2rQ1zCBk461Rg2FL2Nr0m6VDaodGf9RlSqR8qC 0OgvTLOmQCTxxrJw3+X0eeRUYx7M3bvge5JsZWPZVreF6k6J0qThFvg2Fom1ohOlxQAD 5ZhQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=m+j7P9eG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-47ea1e95c04si122745161cf.337.2025.04.28.22.02.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Apr 2025 22:02:32 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=m+j7P9eG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9d6h-00012x-Tf; Tue, 29 Apr 2025 01:02:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9d52-0007en-KD for qemu-devel@nongnu.org; Tue, 29 Apr 2025 01:00:31 -0400 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u9d50-000613-I6 for qemu-devel@nongnu.org; Tue, 29 Apr 2025 01:00:28 -0400 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-224171d6826so83316315ad.3 for ; Mon, 28 Apr 2025 22:00:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745902824; x=1746507624; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oGLga5UEOZhK97fJQViOQTJRGL03WkVBEBC/7bd6T1M=; b=m+j7P9eGV5XuVPSZmxsguyTLebdZ+0Nsr2IwvUZrEImsStahtZ6pQYTXYmxw/wODsk mARN96YIMWsOQTW9deAPPwtguj6zPFZKcOuCHmTZW1dyKyi0ur10Qu+adW4dFbZCPbxR xu22xIxjWwVdOt0XO37vdRPKt+gHMp7FfEQf9DXAaFh+FXf/ncavwNbvBrqN9izq6Hvl 3EHNXlw1Ik1MB8z5qsA0mWQ3ilJYlU/T6EYrNsKcU6gRHXVB1DcCBRHLBJhl80h4FJ1e +qKOAhKksCigYVDO+PVhhYfi4gJueTl1AXKiopjGVsg2nH52GdbDrF6fAqmrv1AiiwJX AyZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745902824; x=1746507624; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oGLga5UEOZhK97fJQViOQTJRGL03WkVBEBC/7bd6T1M=; b=k4oY53snaYgD0YbCqqPcBWRs6BggkVnPsDIjMMtE7VqBTdOosphy5m6SGTv6V/jB1d 9Dnj01vS9wThtz0+NImYZWOhncx8jjXk3hM1kUu+li7JPvqWHxfVgz83c84TGR/iL5IY eqDCT+FJe5hLZG7oaGgNN9IPwkC1vPv9hfJrCOviuHQzwfTWLeQxuo+LnQUn9ZTPotVO Kj823JczLbLStYXxcIbnsfGp6nDHUvqAN1MHu4TqJY4yGfZ367t8bW802WH7Xvys0j0W UK0UWwU1dM1CE0Sc6PVZ2IAQLUqWGp/9ya8oRe98XqQmtUggL3V79Whv+4QC0aqMQCD7 QC0Q== X-Gm-Message-State: AOJu0Yyq6m9WSE6h/czSyZ9wtJYzVu8WxQsUmWbPX4Q3sLFiFSTkZPwK vMQoZOxC4Sb4LSY9Kr7ReriyRLsxp+jpeTE0jsTksb+S5oENEC0CDpSy610+QNXh8Pi3YVKq/FD B X-Gm-Gg: ASbGnculgWkXUHa5jNwPrj6V/zKrWVS4+sE1LxjTVDrr9XCAQsX3XuQpFlWhbhkymmJ 2/X0SwspzkJ5BbSiRLrapLcc5HmiJVl9WsNQD/Ucye/vNmKmrDo88zC9iNc2EXcqo08BBRgrHRl njXIZ5SCd18q8/1F2iiMRyIF8/AoF01W/SYKJwOzmJXE7V4BxbEUjZUPSrY2vNWWrYAfK0S8OoM agYPl1oNsEmhHVNv88mB2Gf5GuBO6GfzZ8VP0wMkQy4z8W5cy9gpMAUpw85nmM9BC74ddB1Nx/1 TFkJXprzR4h/qBAzjEtKE1s9+p/+A9ogmvjvg4/R X-Received: by 2002:a17:902:e5cd:b0:21f:71b4:d2aa with SMTP id d9443c01a7336-22dc69f83d4mr156777235ad.5.1745902824466; Mon, 28 Apr 2025 22:00:24 -0700 (PDT) Received: from pc.. ([38.41.223.211]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db4dbd6f7sm93004015ad.76.2025.04.28.22.00.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 22:00:23 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Peter Maydell , kvm@vger.kernel.org, alex.bennee@linaro.org, Paolo Bonzini , =?utf-8?q?Phil?= =?utf-8?q?ippe_Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, anjo@rev.ng, richard.henderson@linaro.org, Pierrick Bouvier Subject: [PATCH 09/13] target/arm/cpu: get endianness from cpu state Date: Mon, 28 Apr 2025 22:00:06 -0700 Message-ID: <20250429050010.971128-10-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250429050010.971128-1-pierrick.bouvier@linaro.org> References: <20250429050010.971128-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pl1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Remove TARGET_BIG_ENDIAN dependency. Signed-off-by: Pierrick Bouvier --- target/arm/cpu.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index e7a15ade8b4..85e886944f6 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -67,6 +67,15 @@ static void arm_cpu_set_pc(CPUState *cs, vaddr value) } } +static bool arm_cpu_is_big_endian(CPUState *cs) +{ + ARMCPU *cpu = ARM_CPU(cs); + CPUARMState *env = &cpu->env; + + cpu_synchronize_state(cs); + return arm_cpu_data_is_big_endian(env); +} + static vaddr arm_cpu_get_pc(CPUState *cs) { ARMCPU *cpu = ARM_CPU(cs); @@ -1130,15 +1139,6 @@ static void arm_cpu_kvm_set_irq(void *opaque, int irq, int level) #endif } -static bool arm_cpu_virtio_is_big_endian(CPUState *cs) -{ - ARMCPU *cpu = ARM_CPU(cs); - CPUARMState *env = &cpu->env; - - cpu_synchronize_state(cs); - return arm_cpu_data_is_big_endian(env); -} - #ifdef CONFIG_TCG bool arm_cpu_exec_halt(CPUState *cs) { @@ -1203,7 +1203,7 @@ static void arm_disas_set_info(CPUState *cpu, disassemble_info *info) info->endian = BFD_ENDIAN_LITTLE; if (bswap_code(sctlr_b)) { - info->endian = TARGET_BIG_ENDIAN ? BFD_ENDIAN_LITTLE : BFD_ENDIAN_BIG; + info->endian = arm_cpu_is_big_endian(cpu) ? BFD_ENDIAN_LITTLE : BFD_ENDIAN_BIG; } info->flags &= ~INSN_ARM_BE32; #ifndef CONFIG_USER_ONLY @@ -2681,7 +2681,7 @@ static const struct SysemuCPUOps arm_sysemu_ops = { .asidx_from_attrs = arm_asidx_from_attrs, .write_elf32_note = arm_cpu_write_elf32_note, .write_elf64_note = arm_cpu_write_elf64_note, - .virtio_is_big_endian = arm_cpu_virtio_is_big_endian, + .virtio_is_big_endian = arm_cpu_is_big_endian, .legacy_vmsd = &vmstate_arm_cpu, }; #endif