From patchwork Thu May 1 06:23:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 886301 Delivered-To: patch@linaro.org Received: by 2002:a5d:430f:0:b0:38f:210b:807b with SMTP id h15csp174190wrq; Wed, 30 Apr 2025 23:26:06 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCULBFe9ImcmyBMZrhAROBO8f/MuBKMxArynHVuUiy8HR6H1QePmPHvE65wFwvx/glPK34EP2A==@linaro.org X-Google-Smtp-Source: AGHT+IFf6CVtgIuMLtm7HDrB5Cp6F85yI0kdidwkMZ3JXcvodU8JuqCIqC9DG8gT/NwAKGs6Uu+X X-Received: by 2002:a05:620a:1792:b0:7c5:5883:8fbf with SMTP id af79cd13be357-7cacd74307emr239953085a.21.1746080765931; Wed, 30 Apr 2025 23:26:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1746080765; cv=none; d=google.com; s=arc-20240605; b=jtfg/Z+dFzzA/dZ1Ds6gtYsIw37homqVxnC2+wg3etkhw56SWdk8EEBXJXdElp5Qli 2LUl8HK1GGfTZKXTfqZgD2jiUkjd09FM3+ON6K0HrO9b7a0tlN7KtmSPpI+zHKeCUVFJ A9NqDo1TUZJyNSLZwq9UMLRNUT8CpbGGhIT2Q6AMlWPpPpoTSmt+Mwg409SpQBIL6U4u /yrscIUJ0lkaX/g++wi5B8qxGT4/eOjNYAHFq2zqKEQ3lqiIgYv7sVW92+cGj8Am38Lf mbaMWhkkyUrBr8az9geiyXNjTMe5MR/TGNlC3+f8hdBNTE6veNGqWPeeRZ7N3QFbG2iK BSdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=v1JmSJqnxYquNU/v4UOEtwOcqbxnEb6aDiKyyBWqJ6s=; fh=Fszn0PKjr1lTJ9agfldZI0BguDyTJI4MYSL4G/fcmsE=; b=UnHfn+w+oVIaf1LnotXwLc3Nmt9dpg8F44O5cxy42mcyhHJvwIcAtmHIywpSBzqOiE x4orI1ABa0y4WDeZLpulqb8pP8zVJcIpMr77h+mkHlrv3PFw/KTUftgaDlYAWKLWblpK sd91DlILKHe7tMvbg6w7Srw+v/wGjckjAYOxspPMLvE173tL/dANK9yxdJ96ZEDCJGON QWGw0c25qJOdxIYub/hMDm3wijsBMdCuHF2ez/CEBfio+8aAKOW+fgLA/SW0ueOBD9K8 2DnSC4bjxbJDkimceaGVIKDCwWUuvbNXYkT3Lm5vuMlzKDcbG30e4yDwW3tu5WPB7veo yAMg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="TWXtPp/A"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7cad2448ad1si5728585a.505.2025.04.30.23.26.05 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Apr 2025 23:26:05 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="TWXtPp/A"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uANKz-00059r-Hn; Thu, 01 May 2025 02:24:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uANKu-00056S-R2 for qemu-devel@nongnu.org; Thu, 01 May 2025 02:23:56 -0400 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uANKs-00070j-2z for qemu-devel@nongnu.org; Thu, 01 May 2025 02:23:56 -0400 Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-afc857702d1so655903a12.3 for ; Wed, 30 Apr 2025 23:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746080632; x=1746685432; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v1JmSJqnxYquNU/v4UOEtwOcqbxnEb6aDiKyyBWqJ6s=; b=TWXtPp/Ad3ixc17TBgANmvmp5JIs2m52XHE6X9d4Rnmjd8pkInc0fKqBwhVaIChFyL jojrgLxIM6vHMfLXNc51QBU8EYvbNcfTd+yLFl23T478ssfVwHd2Jh0A9jufgrNPKG5N Dm2V2a5VIyq9O6YZRk5fqysMCEytZM4QsPNCHH1E57Pk4hO5j3j9SGSWv7MU0DoNh7XV bEzTysALqDXIYz0hXloABFGCGYkIsh1JT8kmw8yooHbzfBfxkLVYRZ+BzA915Z1pxvA6 vrZWtecxSpHJ90zILY8B1wHTI0AXEEkuxCufr+7epJOQtiohRQSlOAh0atAUoPzHddfJ 0CJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746080632; x=1746685432; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v1JmSJqnxYquNU/v4UOEtwOcqbxnEb6aDiKyyBWqJ6s=; b=t9f71DazmdJY/eWyulvpEYJmxwMGI08b23XrZtAVls3pewlJjHZjnlSj5E6Ok7ZeUQ H7IXijetmnlhKGQpDiP3beDXUF3IoQaGqSqYudiUNFE8R0QrFZC45torxyPMAbIAhtz2 CiqRckdteW4DFWWFsiLq5YdxkyvG7YEik0Ee7ZEk0sre2S1xJ66tpQdnR/lYd2SWmCDk IAKE4twq2V9z/3cxiH6EXz9WaPML75vAEnkUNv/RzudBZ/qIvM4QkvAeA26WPrW0Q5P7 1SwyUseVMiJXfDOjoxad+RG/JhzVdJUe84jOrWtXIQH3OtyMphE/G51fSHrUzLbyhbUu m5GQ== X-Gm-Message-State: AOJu0YwvqS5DbhrKu300M5O6xglyXq1wjhhiZbn9GqhTZcyK44RcN/Sl Ir/FmlrT9LeQ9aD7QhZ0gqB2YgYHW2Lz9zLdNDn2zPA8O3NT5lIr25wqUcEnoUkbiT1YJPu/xha W X-Gm-Gg: ASbGncvLHvKK/fmBFKhhwQP8ixVLUNTuWWBL43VSSGaemLYcLzJzWutX2h00NJJQoHd yCD/UP+WKsvEohz7bzA6Hs7JdVcxbh2A2yyC4pX2t11qkMpiEfv3BckVjoHxvMRxcOdGLY3ED2e aBpRFidC77IfglHyD7FunTAhe29hqQuGymUSNYZx8eosdkq4yXTtjir03PxJUrhZYSE83XyPvzZ n4ymBuavcdxBHTDEZRPR1Iowe5eacQbj5MFS/7VvqiZYY/KnoMz7VaDXX8JkaxQUEnap7lKREAd lPkuRQfeWmHBxYeZsFTPQXfHn/BMti+YoHffZwwBeXBKQWFxol8= X-Received: by 2002:a05:6a20:7d9b:b0:1f5:79c4:5da6 with SMTP id adf61e73a8af0-20ba6a181acmr2684589637.5.1746080632405; Wed, 30 Apr 2025 23:23:52 -0700 (PDT) Received: from pc.. ([38.41.223.211]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7404f9fed21sm108134b3a.93.2025.04.30.23.23.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 23:23:52 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, richard.henderson@linaro.org, alex.bennee@linaro.org, Paolo Bonzini , anjo@rev.ng, =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , kvm@vger.kernel.org, Pierrick Bouvier Subject: [PATCH v3 01/33] target/arm: Replace target_ulong -> uint64_t for HWBreakpoint Date: Wed, 30 Apr 2025 23:23:12 -0700 Message-ID: <20250501062344.2526061-2-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250501062344.2526061-1-pierrick.bouvier@linaro.org> References: <20250501062344.2526061-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::529; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pg1-x529.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé CPUARMState::pc is of type uint64_t. Reviewed-by: Pierrick Bouvier Reviewed-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- target/arm/internals.h | 6 +++--- target/arm/hyp_gdbstub.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/arm/internals.h b/target/arm/internals.h index 4d3d84ffebd..c30689c9fcd 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -1949,9 +1949,9 @@ extern GArray *hw_breakpoints, *hw_watchpoints; #define get_hw_bp(i) (&g_array_index(hw_breakpoints, HWBreakpoint, i)) #define get_hw_wp(i) (&g_array_index(hw_watchpoints, HWWatchpoint, i)) -bool find_hw_breakpoint(CPUState *cpu, target_ulong pc); -int insert_hw_breakpoint(target_ulong pc); -int delete_hw_breakpoint(target_ulong pc); +bool find_hw_breakpoint(CPUState *cpu, uint64_t pc); +int insert_hw_breakpoint(uint64_t pc); +int delete_hw_breakpoint(uint64_t pc); bool check_watchpoint_in_range(int i, vaddr addr); CPUWatchpoint *find_hw_watchpoint(CPUState *cpu, vaddr addr); diff --git a/target/arm/hyp_gdbstub.c b/target/arm/hyp_gdbstub.c index 0512d67f8cf..4d8fd933868 100644 --- a/target/arm/hyp_gdbstub.c +++ b/target/arm/hyp_gdbstub.c @@ -54,7 +54,7 @@ GArray *hw_breakpoints, *hw_watchpoints; * here so future PC comparisons will work properly. */ -int insert_hw_breakpoint(target_ulong addr) +int insert_hw_breakpoint(uint64_t addr) { HWBreakpoint brk = { .bcr = 0x1, /* BCR E=1, enable */ @@ -80,7 +80,7 @@ int insert_hw_breakpoint(target_ulong addr) * Delete a breakpoint and shuffle any above down */ -int delete_hw_breakpoint(target_ulong pc) +int delete_hw_breakpoint(uint64_t pc) { int i; for (i = 0; i < hw_breakpoints->len; i++) { @@ -226,7 +226,7 @@ int delete_hw_watchpoint(vaddr addr, vaddr len, int type) return -ENOENT; } -bool find_hw_breakpoint(CPUState *cpu, target_ulong pc) +bool find_hw_breakpoint(CPUState *cpu, uint64_t pc) { int i;