From patchwork Thu May 1 18:36:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 886363 Delivered-To: patch@linaro.org Received: by 2002:a5d:430f:0:b0:38f:210b:807b with SMTP id h15csp464400wrq; Thu, 1 May 2025 11:40:58 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUisn0bCQGLu1kdZ+Z4BsYos7zRmumcQUez6tYLhtNAkG30jHXgDuvnTftL71ZegtmdKdt9ug==@linaro.org X-Google-Smtp-Source: AGHT+IF848sV6LcaqRTsFuTc8Q1rGhfgqJj1/J0YlNyHngvwHUTdP6T8DsWeYUOidYTPy5IMqEr7 X-Received: by 2002:a05:620a:2953:b0:7c5:3c0a:ab7e with SMTP id af79cd13be357-7cad5b20805mr21035385a.5.1746124858087; Thu, 01 May 2025 11:40:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1746124858; cv=none; d=google.com; s=arc-20240605; b=FqqMMMCyOxAfdqn8uHiXNfKgrKkXFKb1EfWCzi1ARGmu3NGQMPaRwRlRR21wIr3Nau 8TGPePl/95NrCG77my3pbiZypsqHkvk+OqDuziRlYTjcC9vrM5HBSysIAmgE4tdliChL xN1HJ5nxxYg0+ZhpcvQpHeQ/BG3DonR3J3g0qLT/Dij8azjT6rLtPE7NDhKfXNRJD+Bp 6zVxtJ/Ew5t9eO9kHLiC7pmoEyt8Jp7eRZmkK1rey3nIo55O1IiT6K7bH7bl3gLG3quO cmssbBeyvjAJaQIsper/QwThzo7/htZWvQqIa9wqVDto6q0edjKOdQ5eA6xRyUJeR6Qx 9wtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OGZ2h0bYEkKLAAI47CZVdSqBou71xk/HAQM6xphmlJ4=; fh=hoe06aprcDnk5P3d0vwgQt6uC5al0E2l9mfTIGTxZjA=; b=YCali3457P2+f7aazTRp3ViX3JSQPuHSYY+69gvZ85Er3ySXbJac9IhVnuzvCLke6z R6ULeSS3X1iGXZtXDNG7xd/vW0bG2G5MEam+PMffm6PN66dzXuAteMLiMl+FGH+eb8+E wv1P5rFa6gTRV28gsmD9NU//tCb9WC4Bmy6B0/gEjlswdXSWyK1P8G1Nubl+h5s6I6B6 I3Od97Pv+oS3UNZbNMUNqC0uvLXVIlQpo+ewhE0T3PtaIncYI5CXKi76uG+BKSoJOda5 QVbRw5NBdcBBq33gY3RQ+SjQ3CfMAxrmfAZQu6hfEKRnlayT51pW156/DwPTu+y19OtN Wrug==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FwmkcGDd; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7cad2433b24si121120185a.435.2025.05.01.11.40.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 May 2025 11:40:58 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FwmkcGDd; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uAYno-0002PQ-20; Thu, 01 May 2025 14:38:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uAYnP-0000QD-0q for qemu-devel@nongnu.org; Thu, 01 May 2025 14:38:07 -0400 Received: from mail-il1-x130.google.com ([2607:f8b0:4864:20::130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uAYnN-0008BQ-7H for qemu-devel@nongnu.org; Thu, 01 May 2025 14:38:06 -0400 Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-3d5e2606a1bso11381145ab.0 for ; Thu, 01 May 2025 11:38:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746124684; x=1746729484; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OGZ2h0bYEkKLAAI47CZVdSqBou71xk/HAQM6xphmlJ4=; b=FwmkcGDd+e4oChMZjyc6hhXdyxOi9qT6Lf7DTt7CFPyu66zn9M7FI6iCCyJgakVvxZ uxisEFkmAmBTikjCzzr8K3QxWSb0Y+NA7Ug3H34FyI90h7QBC9e4yDHeGw4WileWn5fs 4DKJnxE85cgfyi+Fs3828S1DIP4pEw7au/yOavwNvLNTUFSBtsjIn+s1aEBGRPPxLxsD GI49wk1+z0xhHgvz5ghW07dDfY3iBLawqTZOkEQ7bhIq0W0sOwH41ny1a9j6r9LbJEiF pSAnuKIy2XWElkMSU9uGtO5I0rlj0f7j/SmEcpqTTSQSkouYB2Pmx9JGOE1rHr2ANzFr c3dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746124684; x=1746729484; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OGZ2h0bYEkKLAAI47CZVdSqBou71xk/HAQM6xphmlJ4=; b=CfdVnop9nrR+NPZ3vSl4lpqG5FsJ9lDBRQ2O1DEyEeLcfAw8GFObO5CjqU+X92ynGJ IdIaY1e2Wb56O+w9rWjHQuyknBNQ7oW+N6zBSq1Y36aANC+W4WGwQgprbMMbusE7ci/e eWaYoGq19nAnhOKWRAj0qBPaUqvwJFgJocd3kdNS8XK2KwUGEsd9ppRxI4PdmHBYuU9C vV0VJh6e4Dgpxkz61tupz0GEi1miF4D75qxLJSxpx+lTwNmGx+4LbIv5ymjndjpNlieP I79JdAdh5SMRl3be53OFQZjMX161raEtQkeeO/xuHwyAqUM9v61yw5Xp3zI9lxV6tejw D1ng== X-Gm-Message-State: AOJu0YwmzZRIcx7ys7ONph5mHDYZPLAEqx7XM1bVd1bFY/2dZW4sAMHw ApB+tGRqe7zbIEsW8HkahxJ+MRg1bg5pY5Ff/FYeUPqJf2OHYCLKYSaOOwmM2P+MXhX8+IjpSG8 q X-Gm-Gg: ASbGncsiBG6Hr+h+h2uX+flm77egllwaTq/yodevp6FTh6O3wUshbJhOlg8g+YWt5GQ UDo1rs3uVydEAc4wqJAgrW575+jMvNtbwvL29j8zGtZkMIeQTRRIcNWewofCPF8PDS8GTHa1fzT K9Bi5zVnoFvoY/G8xoGmqrEr0d0pPvBnWpSJsu5NikTfHmx1JST9SHMVFiOhFBTTfm64Kw4QPuf WEpPWIOMX96DYt5Gozn3upQd+SjMMjVdT5vX3k9U4WFqPG8GNM4E0699F08pxPxe0Wg5sa2v+iF YYXq+Ca5gzfY7dXlIcYYr00YoIGivS2zF+nj5lpr2suivUcFAfpAsj1LhGAXmnumhEnmlGnQMDV H4Pjz+4Net3ra5B96PPG6 X-Received: by 2002:a05:6e02:2511:b0:3a7:88f2:cfa9 with SMTP id e9e14a558f8ab-3d97022692cmr43020525ab.11.1746124683890; Thu, 01 May 2025 11:38:03 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f882f06d40sm306171173.72.2025.05.01.11.38.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 01 May 2025 11:38:03 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Igor Mammedov , Gerd Hoffmann , =?utf-8?q?Cl=C3=A9ment_Mathieu--Drif?= , Yi Liu , Paolo Bonzini , Amit Shah , Zhao Liu , "Michael S. Tsirkin" , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Richard Henderson , Sergio Lopez , Laurent Vivier , Jason Wang , Eduardo Habkost , Yanan Wang , Marcel Apfelbaum , Ani Sinha , Thomas Huth Subject: [PATCH v2 10/16] hw/audio/pcspk: Remove PCSpkState::migrate field Date: Thu, 1 May 2025 20:36:22 +0200 Message-ID: <20250501183628.87479-11-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250501183628.87479-1-philmd@linaro.org> References: <20250501183628.87479-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::130; envelope-from=philmd@linaro.org; helo=mail-il1-x130.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The PCSpkState::migrate boolean was only set in the pc_compat_2_7[] array, via the 'migrate=off' property. We removed all machines using that array, lets remove that property, simplifying vmstate_spk[]. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland Reviewed-by: Thomas Huth --- hw/audio/pcspk.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c index a419161b5b1..0e83ba0bf73 100644 --- a/hw/audio/pcspk.c +++ b/hw/audio/pcspk.c @@ -56,7 +56,6 @@ struct PCSpkState { unsigned int play_pos; uint8_t data_on; uint8_t dummy_refresh_clock; - bool migrate; }; static const char *s_spk = "pcspk"; @@ -196,18 +195,10 @@ static void pcspk_realizefn(DeviceState *dev, Error **errp) pcspk_state = s; } -static bool migrate_needed(void *opaque) -{ - PCSpkState *s = opaque; - - return s->migrate; -} - static const VMStateDescription vmstate_spk = { .name = "pcspk", .version_id = 1, .minimum_version_id = 1, - .needed = migrate_needed, .fields = (const VMStateField[]) { VMSTATE_UINT8(data_on, PCSpkState), VMSTATE_UINT8(dummy_refresh_clock, PCSpkState), @@ -218,7 +209,6 @@ static const VMStateDescription vmstate_spk = { static const Property pcspk_properties[] = { DEFINE_AUDIO_PROPERTIES(PCSpkState, card), DEFINE_PROP_UINT32("iobase", PCSpkState, iobase, 0x61), - DEFINE_PROP_BOOL("migrate", PCSpkState, migrate, true), }; static void pcspk_class_initfn(ObjectClass *klass, const void *data)