From patchwork Thu May 1 18:36:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 886360 Delivered-To: patch@linaro.org Received: by 2002:a5d:430f:0:b0:38f:210b:807b with SMTP id h15csp464280wrq; Thu, 1 May 2025 11:40:40 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUkgMnqJFZQtlpGWCIA//jz5kX5hAyJV5RxWU2GTUWshQOOYXFzd+kEG2gCRCaoOM90RNu9hg==@linaro.org X-Google-Smtp-Source: AGHT+IGO+YtBUyWAwgibVhCwnV6evqXr294cNb+Kz1HYD5ifgI2AFhGuQXoStP9IqiNoe7bb/xUU X-Received: by 2002:a05:622a:2445:b0:48a:97dd:6594 with SMTP id d75a77b69052e-48c2e473afamr172051cf.0.1746124840083; Thu, 01 May 2025 11:40:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1746124840; cv=none; d=google.com; s=arc-20240605; b=c9fLfc1e8c+ay8qAF3Ez4Nvw6DcPRzeHWItEqmusQt2hUUIkrtALLp95n9/aB8qVEQ eIM4ZCj0fdzxJjw8dr7GYBn/jwBzdPhNoJDucWpvn9OLgaJphzXTfpN+37TSmE30Pb43 pz1f6fYx6FedVNj8JY1L9EyObeWQmm1PxbwJvR3TfpdXeLk2PuAy3NWs7i8uhFwfV0n1 QFnJI/9QdwmygK2pkin0xp9IUaNs2NPYDeYz/AA79/Jg1RA/cUOFA7tpJdJC7eEdBQ1G QS62mB15rBiOxdKcsAmrlfXBsyHnhFW2C8kba9jVxpJzFeEC+LoLiNN8GFWNtRYuU2Ez Fdvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YNiEylsO3oY9vgtqAxWvkDME/V5ix0NbPvey475+kvI=; fh=hoe06aprcDnk5P3d0vwgQt6uC5al0E2l9mfTIGTxZjA=; b=kTOT1TSOT43BPb5Y0MqKDb8Cr0GEJpldHdx7igIa1z6R4mvwKe6Nt5OjMCbS5yweYJ vSnfcjaQ5DVNy+F3YGXdT0BWNmZaFBTbPZk2BvMsnZ5H0mcATRd7xqsd5VsSYFAC74Vl 2Bvto4EU1Iyb2zNOXS5TBO+bAQU1Rxumoc3yKU36zPSNSKHXCijUyaR6vokdLqCc/oHj NBiZs4F4kWYKYbNozzgZs8eDKwK8EnFgTV+9H8Vl9QLYs4sW5GjTtGSYi+DErCNmwBlx 1532f48ydYGtuLb1ZIjXE2CMlx6pkI5Yyxe4PszwQWbdw0eYzZQuCNpImgr1kgXHNx9v aeaQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="rn/iI7UD"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-48b990fbe7csi11954271cf.635.2025.05.01.11.40.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 May 2025 11:40:40 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="rn/iI7UD"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uAYpX-0004bG-I5; Thu, 01 May 2025 14:40:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uAYnx-0002hk-Mp for qemu-devel@nongnu.org; Thu, 01 May 2025 14:38:46 -0400 Received: from mail-io1-xd35.google.com ([2607:f8b0:4864:20::d35]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uAYnv-0008KF-Sj for qemu-devel@nongnu.org; Thu, 01 May 2025 14:38:41 -0400 Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-861d7a09c88so40192639f.2 for ; Thu, 01 May 2025 11:38:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746124718; x=1746729518; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YNiEylsO3oY9vgtqAxWvkDME/V5ix0NbPvey475+kvI=; b=rn/iI7UDZbYMHSCkBCKjbT4jk6oqEdBsaU50nfTY3rbgWen7eNfJ+R7WqbG34NctRm cN7YrgO3bZvppPoLu2a3pxIomMajXRfnkc7TaEwlSaPqQ2QC2PK07Gk1jZ82c/G8ZbIt tCwi2WO2OJdWRM7o+dvQVD8ORglorp+hq4D1gg6sBiLwNX/tNdtcASv9YG81ZdxvFIOf UZ3WyQXIA2NsUGuDMNt4k22gRutDaox0mCw2JJp7BkN9Ak0KQza9nT/ZdxfIjuPYhQpt traKkRp+t40iWprr+M8kq/ffLGS+8na3/QAaN/98q2WEGZ90+smTrEmyZ5EFOSsdAKOD nb1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746124718; x=1746729518; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YNiEylsO3oY9vgtqAxWvkDME/V5ix0NbPvey475+kvI=; b=eB15i9Ggl2ewCQfgJKXr9o/xJjZqGJD/Fre6ss8rBnUITJ4qrBUrfhmbXAacXSn1+L P5RBrBJVydu6FtajSOfGkBTw1GAtS0aPfVmOj7w5sv2k/83WOQ+95ug8rWjl+34U3yPV uvIumYt3wQWvCNYPfvgmflyQ8WF21V5BOtBL+T4lekjzzgfW2iVebQXUh6g0orZ9iWnd LWnbA1sKT4r/SY/b7Hz1nYnLYZoBL4shzBNoEP4UEx4Nu7ogqzT6fn2RSaykdxoxJCIk jITEixK2MA0u0I6R2MiQISIlAP9nLECkyQgayFE8kg8DPbfiM+t33sA9wdqNf4uAPjFU AEvg== X-Gm-Message-State: AOJu0YyktAF/+30igTEYBn7nXdfJjDvTa3KDJ7WK6h1RojR4LrKPbB7g ejwqZDwLpl9WvTWtirGS+W60qMD8VtsC5Z3IutpxlxlNqpx1O5jms4AZdiuFnU15hnXoYQWu6gU O X-Gm-Gg: ASbGncvIrXo9GNPKQz6grv8rsgvDoUJXhozef4JPxo7Ni1V0SqBLY+hMhxEsx9Cj+AW FEF5LgCsr/gKPPLI7bY5xPSMRuT0J5jlOd32a6JbGMGxvQ5T0cM5xP/q5N8SRSo5LYsQHVW6wRG Oqwsbzbe5Tg+FNaCl2Ddep5pHMgEPUo/pOVM+bv1duRHULZUdzD+ILlR93GMSUyUs0vWa+oH9hZ wc0ZGCvLSIOUx3qQ8xfoccXhs+Rb9WrK8zIivcmwaXoIAXlAw6aQaiSE830YSn9rfuoOFTAIBs2 w/qPPVLsxA+IM1DcReaRnYieY2xaLMqj7p8t/wAVUcBS7v/QnuW/5T1fyvB5Wwb3pkqatnNcjdD EmV7LAb5qE6hXpHiA65SF X-Received: by 2002:a05:6602:720e:b0:864:4911:f463 with SMTP id ca18e2360f4ac-866b348c723mr29008939f.10.1746124718559; Thu, 01 May 2025 11:38:38 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f882ee3c6dsm309761173.44.2025.05.01.11.38.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 01 May 2025 11:38:38 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Igor Mammedov , Gerd Hoffmann , =?utf-8?q?Cl=C3=A9ment_Mathieu--Drif?= , Yi Liu , Paolo Bonzini , Amit Shah , Zhao Liu , "Michael S. Tsirkin" , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Richard Henderson , Sergio Lopez , Laurent Vivier , Jason Wang , Eduardo Habkost , Yanan Wang , Marcel Apfelbaum , Ani Sinha , Thomas Huth Subject: [PATCH v2 14/16] hw/virtio/virtio-pci: Remove VirtIOPCIProxy::ignore_backend_features field Date: Thu, 1 May 2025 20:36:26 +0200 Message-ID: <20250501183628.87479-15-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250501183628.87479-1-philmd@linaro.org> References: <20250501183628.87479-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::d35; envelope-from=philmd@linaro.org; helo=mail-io1-xd35.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The VirtIOPCIProxy::ignore_backend_features boolean was only set in the hw_compat_2_7[] array, via the 'x-ignore-backend-features=on' property. We removed all machines using that array, lets remove that property, simplify by only using the default version. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland --- include/hw/virtio/virtio-pci.h | 1 - hw/virtio/virtio-pci.c | 5 +---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/include/hw/virtio/virtio-pci.h b/include/hw/virtio/virtio-pci.h index f962c9116c1..9838e8650a6 100644 --- a/include/hw/virtio/virtio-pci.h +++ b/include/hw/virtio/virtio-pci.h @@ -149,7 +149,6 @@ struct VirtIOPCIProxy { int config_cap; uint32_t flags; bool disable_modern; - bool ignore_backend_features; OnOffAuto disable_legacy; /* Transitional device id */ uint16_t trans_devid; diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 8d68e56641a..7c965771907 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -1965,8 +1965,7 @@ static void virtio_pci_device_plugged(DeviceState *d, Error **errp) * Virtio capabilities present without * VIRTIO_F_VERSION_1 confuses guests */ - if (!proxy->ignore_backend_features && - !virtio_has_feature(vdev->host_features, VIRTIO_F_VERSION_1)) { + if (!virtio_has_feature(vdev->host_features, VIRTIO_F_VERSION_1)) { virtio_pci_disable_modern(proxy); if (!legacy) { @@ -2351,8 +2350,6 @@ static const Property virtio_pci_properties[] = { VIRTIO_PCI_FLAG_MODERN_PIO_NOTIFY_BIT, false), DEFINE_PROP_BIT("page-per-vq", VirtIOPCIProxy, flags, VIRTIO_PCI_FLAG_PAGE_PER_VQ_BIT, false), - DEFINE_PROP_BOOL("x-ignore-backend-features", VirtIOPCIProxy, - ignore_backend_features, false), DEFINE_PROP_BIT("ats", VirtIOPCIProxy, flags, VIRTIO_PCI_FLAG_ATS_BIT, false), DEFINE_PROP_BIT("x-ats-page-aligned", VirtIOPCIProxy, flags,