From patchwork Thu May 1 21:20:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 886432 Delivered-To: patch@linaro.org Received: by 2002:a5d:430f:0:b0:38f:210b:807b with SMTP id h15csp521667wrq; Thu, 1 May 2025 14:30:47 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV7xWyDmd6EDdNrbnopBP8pJjZzce8EV4v8GA186reiT55wQZGNC/1UcOyEtLUm1WvFQA7L+A==@linaro.org X-Google-Smtp-Source: AGHT+IE90CPv2dAj5Y3V6DWZpx9lXLm+LhZ2pw3bP/BZCAj1mtmgwl+al+xHpLpv0fBFenRZ/igr X-Received: by 2002:a05:6102:80a6:b0:4c4:dead:2f36 with SMTP id ada2fe7eead31-4dafb20efa3mr712064137.0.1746135047528; Thu, 01 May 2025 14:30:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1746135047; cv=none; d=google.com; s=arc-20240605; b=P/xoMy/YOCJfeS3EBhP6VcniGiNUW6PFL3nssQjlCdGenfD1HlBMx2pBnVTsW7RH26 4qqrdaLJkS6OVLMukW/g+2AaGZ0PzPruDajrYqzg6JWR5BqoeqUd5rNb84XSlh+bo+DJ JMeOs1U7vzEF+opZP+SE3qGglrmGP+FHlA5GLdRlMfokMEYp38QgEJqVdBTT0Ajy56b3 IQ+T/08thxKtaPBCmnwp/ddXzrS69HCtRR8FsPU7K3UXz+icH7vnnqZkIXPTNl3MsNvm ptF4UerRWxuHGfkqdaASb+6eMdX/gR2kmHtMb1lM4O10Q9r203Eu4+TqxdH7XqiA4x/9 wT3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OXwcdw9KH2AB3C2RsE6WjSiCvh4jeWGeibDuA8DDVDs=; fh=vm85eyWrvOAHduw3sqEA+cYBqvHB7M0MHFcRJg7VWOo=; b=MiKtlrxFW5964XEJX3iOardI353VHAvhRDOnTcx37HqAvEpobTKfv9nlf29u1k+eNt oQbaCnQlCAdp4YHNyMs/haZzAuQOY+utIoEOovC5F+NoRMy4KdKKbfuyPQad69SZp9P1 S2c32/5eXRP8g5Eczn/MaKceXtqU9ty70j3sHoFRBnMoKnTpVEH4GIy2gyeXYOTVmlBC YzjcoDx+SQPKJrtEtsazjArYkYPWr4AwUOgNgj0Fte/yTxPva8NX1MoV8gLxrxSUzKgp TyIPlFPn1HVjEFp0NWDxLa1US5T5y9Xh6Zl6gLRUJ5K9StvUHHR7e41666oIMI94LKNz ltZw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jvopjJMI; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a1e0cc1a2514c-8780b2ab943si53669241.153.2025.05.01.14.30.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 May 2025 14:30:47 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jvopjJMI; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uAbLo-00011Q-C7; Thu, 01 May 2025 17:21:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uAbLj-0000xq-HZ for qemu-devel@nongnu.org; Thu, 01 May 2025 17:21:43 -0400 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uAbLh-0001YU-K7 for qemu-devel@nongnu.org; Thu, 01 May 2025 17:21:43 -0400 Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-3085f827538so1909457a91.0 for ; Thu, 01 May 2025 14:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746134500; x=1746739300; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OXwcdw9KH2AB3C2RsE6WjSiCvh4jeWGeibDuA8DDVDs=; b=jvopjJMImp2yERBUOFE3viwgzwx4ylQsz7ALjjnJlL7NB75QXOg+I20wcM2TWe6PSL ie1LPa+Y2/ueVIMvCniHN4D9nwIUL7krd6McBbzyvfA9yzWA2Ev0szl243qt9r3nl4c2 vfjBO75mVPsOtV5BSKvm9oqlOcI1X4dznwKnAKGA+LMTA/4Xg36AvXNDcCgpTBnEOldN 8MUWPT+AOkaCSabYR1ZGwyd2S+wdlXIlVcPGmqqQ7Tkt6iwm9YsP3W3Y62KiugCRDMnV WCF8SMEInDl08ORbq9fQoLW+LoDkTZBAMoZy2QtgCBbTt/px+JFUg1L4UZ0Gb3YOt/8f TCkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746134500; x=1746739300; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OXwcdw9KH2AB3C2RsE6WjSiCvh4jeWGeibDuA8DDVDs=; b=a3UlaP4MmY9W/49FEhJLpHTjU3xogfm/fnSVSmSkFmDY55w609kK038mBKN0Vt/U2v jTAJEo+IqotHMDVsfNprVLSv+iRQb/lPPWpzTOfnr8YRslqK0ox7ONFbZDHqWl0UsgLL gY7yczAOdDeu4jdjJszO0/1oxCreo0lEIe8Q7Vj8AWpfqRnX0MS3tv05GP/Jbjl4pYoF qLcOd4kY/CtVlPy5sT7zT3tr4LuUlAJeQqxxzPECqGscL9ZqhZHfcDolkaj7NjB1g3Sd GvqJime5koLtGJ3lUQcRYAnrsxTVAKAy4G4ORlxKTzN4iPqKGLNcDt9HotZOj+oHYqtn bFSA== X-Gm-Message-State: AOJu0YyL6HSWG1/BObgbl61hTqcMZZ/tY4bOwosr4i0ODDNAswShqO7l g3J5caSoWvdTuHhOX3ITb/OAc/EGiT5WTZxMqnIwhuBzX9PH9TI+LrK9iqtQIFMhBwZgy81fEWx y X-Gm-Gg: ASbGncsFIi2oaV+iTMxHpWJ2VlLGjFM3rUZTjUbPLSZTjNCSNyTU7mxjjCM3p6Mn7xE GdtTu4O7DD6FkRY7RO5AjLeDSm5ok+OLvJ9Fd92u//sXBHXpH7CLPjWF32x6z8Fk5hYiQGpvuGW lrRX4T5jvMwijTGK0iRovDCeuvguu12X1vxtXXzqM0AyTb764tnd4UOI2788Q6QRUwqqjYytiO2 ZJrfAcahRxYJD57W1o1VYOWo4ksrlfgMaxE3AgeyBmwpNKvCwDZ6f18txqwa03VbcG3h1OuxDfQ uz6nojzQhykg0mr2gsZ9n9F6+p1upLtQsx8D+nokdvZzlNfEKfg82vyRfoqF82chvLBjupAmdE8 = X-Received: by 2002:a17:90b:2644:b0:2ff:6167:e92d with SMTP id 98e67ed59e1d1-30a4e6adf1bmr753766a91.32.1746134499701; Thu, 01 May 2025 14:21:39 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30a476267e0sm1384573a91.39.2025.05.01.14.21.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 14:21:39 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Pierrick Bouvier Subject: [PULL 30/59] target/arm: Unexport assert_hflags_rebuild_correctly Date: Thu, 1 May 2025 14:20:44 -0700 Message-ID: <20250501212113.2961531-31-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250501212113.2961531-1-richard.henderson@linaro.org> References: <20250501212113.2961531-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org This function is no longer used outside of hflags.c. We can remove the stub as well. Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- target/arm/internals.h | 2 -- target/arm/tcg-stubs.c | 4 ---- target/arm/tcg/hflags.c | 2 +- 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/target/arm/internals.h b/target/arm/internals.h index 4d3d84ffeb..382a4d1015 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -1906,8 +1906,6 @@ static inline bool arm_fgt_active(CPUARMState *env, int el) (!arm_feature(env, ARM_FEATURE_EL3) || (env->cp15.scr_el3 & SCR_FGTEN)); } -void assert_hflags_rebuild_correctly(CPUARMState *env); - /* * Although the ARM implementation of hardware assisted debugging * allows for different breakpoints per-core, the current GDB diff --git a/target/arm/tcg-stubs.c b/target/arm/tcg-stubs.c index 93a15cad61..5e5166c049 100644 --- a/target/arm/tcg-stubs.c +++ b/target/arm/tcg-stubs.c @@ -21,10 +21,6 @@ void raise_exception_ra(CPUARMState *env, uint32_t excp, uint32_t syndrome, { g_assert_not_reached(); } -/* Temporarily while cpu_get_tb_cpu_state() is still in common code */ -void assert_hflags_rebuild_correctly(CPUARMState *env) -{ -} /* TLBI insns are only used by TCG, so we don't need to do anything for KVM */ void define_tlb_insn_regs(ARMCPU *cpu) diff --git a/target/arm/tcg/hflags.c b/target/arm/tcg/hflags.c index e530f65ed7..5315264c28 100644 --- a/target/arm/tcg/hflags.c +++ b/target/arm/tcg/hflags.c @@ -499,7 +499,7 @@ void HELPER(rebuild_hflags_a64)(CPUARMState *env, int el) env->hflags = rebuild_hflags_a64(env, el, fp_el, mmu_idx); } -void assert_hflags_rebuild_correctly(CPUARMState *env) +static void assert_hflags_rebuild_correctly(CPUARMState *env) { #ifdef CONFIG_DEBUG_TCG CPUARMTBFlags c = env->hflags;