From patchwork Thu May 1 21:20:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 886411 Delivered-To: patch@linaro.org Received: by 2002:a5d:430f:0:b0:38f:210b:807b with SMTP id h15csp520289wrq; Thu, 1 May 2025 14:25:55 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWM7K0C5h4ND0sJXPRE43nCb/7BoNpQD8lBW+0IUl7Jzbvdemrmjhn2b6+kZ+PZlJ/CfvjNHw==@linaro.org X-Google-Smtp-Source: AGHT+IGKXX2ZoAJY2H61DSyYC/Ssg0Tm9UgrpDPr2wAh/2WSKuYnPNQ7z9q05169WBty5VPKtOEK X-Received: by 2002:a05:620a:c54:b0:7c9:5ebc:f048 with SMTP id af79cd13be357-7cad5b3ff6dmr78181685a.20.1746134755320; Thu, 01 May 2025 14:25:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1746134755; cv=none; d=google.com; s=arc-20240605; b=MqgeMSOadXUi8TNEGopxsKvYY8JCNoGv9W3lBunwhp7eU7HCoScyVgs5evQtnWZBUG tWnZTG4xy/YxpQlncboLBDMohw6dbFZNltiYAVEDNs84KwLT4CyBg2HNOEMSpnCA7njm rRTYstRLThwowGTA9LAygFNuo+CBK9DUbo6imMVmHTjD5GgmTaUPIqAeKLJ2llpG0eeC VukhcPW0+10G9nCW4X+PNYACQbd2tkofTtrL9Fp73wa2B58sav8Ot+H/7TJiYHrq16Wp xBZmFcbSxUJO6UX579EPIKQRq2WZ35gcKALnSCSwAUXvxBx6hwB9GJckzG5xWhnfYEha CfJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=bUlQyLw9XbRuGHrkcRVzrQwHQ4LewMHgS3C55fSZYyw=; fh=B7wqr7Y2RLYB33KpRwZqY06/+q+uXGO9HG0a/NZI+x0=; b=esWiRVSPSkfombCnWvRCWWHgPz3FhzGHQOelxZEs+PFh5BEUqXEr2YcETC4gKrOZje 6wKeAyKNtr/7+YQk8V/WAKn75dgVC3xw0eyOnJVFQwzdVFikiJ79adlolA98+T1CFmjv pPmDCPPHzuZC/ZR6FzIaNu08+A28Cy9wmNh2fI5hPPWSzq5zkL/LPjF7EZaFvx9Z2B7m EY79WPH3kl4er9T5uR9BijE8ENi4J0dRqanj3jvpIilOuVBZD2jeNpV4gsbjZD1qa+tt qMwes3MPMcSBcI52EftYJTUJimyDNbtwWiKTrIvni+YG8MT+mlHitOseuK2N/y9ucI8O Sf6Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Hukc2xo3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7cad2446018si148346785a.487.2025.05.01.14.25.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 May 2025 14:25:55 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Hukc2xo3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uAbOw-0005LV-HZ; Thu, 01 May 2025 17:25:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uAbOn-0004T4-FY for qemu-devel@nongnu.org; Thu, 01 May 2025 17:24:53 -0400 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uAbOl-0002BG-Oo for qemu-devel@nongnu.org; Thu, 01 May 2025 17:24:53 -0400 Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-b1f7357b5b6so964137a12.0 for ; Thu, 01 May 2025 14:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746134690; x=1746739490; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bUlQyLw9XbRuGHrkcRVzrQwHQ4LewMHgS3C55fSZYyw=; b=Hukc2xo3bz7fOKAL5zcQfbUAo+ZgsPqGbicB3OcDlvbdrKWnFQuZuqyOQzZLwwHEl0 A0e/70XqDpgtYTFYzPJp39F0rD7IY46cKFT2CsjCWsaCIimcta355bIzF0sziI88JZ85 uxoGc/S6uYWIBAP4aaeYH8Su0wsVO0WEYvquugHrn4VFQ1ANE+IUEInfENBQGwv7Q/mT UrH/ZdUyBATw1tg2A/jCZqql48r9LRQYKBkG6+A4P8u+YlP1movEDBg6QHHRpM5U+YCU wS2n42+M2wl8rMD+Cku00VVQU+VOkTyUke5Fzp6z5Ug+n7Fw0J8lsYXDTYMUL2WCPAbz hTQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746134690; x=1746739490; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bUlQyLw9XbRuGHrkcRVzrQwHQ4LewMHgS3C55fSZYyw=; b=nKjuzo/fR42VaYNEuYar+YZorz3dnlwO2MDhDQwSqxbEckl1/kHNeLKLny28zB7Hcq IPijfYBTEofetYmv4h7ratELW9/NRpmDDUBXELhLBpMGlcXoesriwBSI0dblKwC7Zo+n fhhiF10R4jtgiO759nzIUjmEdNV99AYShu+6NHOkSonkdyOSQLx0bcAC0VS3ceMEDV16 A83IbB1B5kD8tRs/tWSaLIy6NSoCf4K9vCt3KDU1KD0sQeHd1ngwLb8q384toOnd0jLk f5wo2l7fG0ZZ9vxAXaICpNLih8qsEYbjGD9HaBpjw66do68ROifvVTQcH/UCVKO1JMNY 5okA== X-Gm-Message-State: AOJu0YwGtlaFTqUlit18hXvlWZp+f7hTKwbDjImX6ZqSgCtMiq0aymCz K3XS+OHg0P9YiNMlMKrTY12Z2in6rgXOO2GDGGm8RK72Ouq+1bY/ADLyfU1j+SHjbGYmHV+kOTB t X-Gm-Gg: ASbGnctn7FefPTb+fdGu09V8ziuNXHyf3fNeEMhZsold2kjWKWMjSq6QVP4HZDTgBf/ cYPXk1we425cx1/eYJXrtUdE9+ahmQeZVrRN2dFex/aKHEJpsiuTpUI7HBgvxP0OU8Sl1qtTl1o 6TsSPPVBGcnHMmxc1POuFAb/nd4SSOubqCqnP4GFOxJnk0VgcKdWhg1FkgsmQ/kTPEqvk0qfseb 9A4wwcGAYKAEgkAYow+iwrAm+LwyJdRr5AePit701YiXGpO4RXdlnjngpZ8R5szz84a5l9PczZ1 4WXLT4OogfuxOjLy+uY4tdV6hHkQtlJ3MI1b4dolg62VE0vc2DYdL/ljoT0ZgCdEnO3bRkKfrkA = X-Received: by 2002:a05:6a21:6b86:b0:1f5:7ea8:a791 with SMTP id adf61e73a8af0-20cde857068mr556349637.10.1746134690102; Thu, 01 May 2025 14:24:50 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-740590610desm135897b3a.146.2025.05.01.14.24.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 May 2025 14:24:49 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL 44/59] accel/tcg: Don't use TARGET_LONG_BITS in decode_sleb128 Date: Thu, 1 May 2025 14:20:58 -0700 Message-ID: <20250501212113.2961531-45-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250501212113.2961531-1-richard.henderson@linaro.org> References: <20250501212113.2961531-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::52a; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org When we changed decode_sleb128 from target_long to int64_t, we failed to adjust the shift limit. Cc: qemu-stable@nongnu.org Fixes: c9ad8d27caa ("tcg: Widen gen_insn_data to uint64_t") Reviewed-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- accel/tcg/translate-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index fa4998b341..acf32e6c08 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -109,7 +109,7 @@ static int64_t decode_sleb128(const uint8_t **pp) val |= (int64_t)(byte & 0x7f) << shift; shift += 7; } while (byte & 0x80); - if (shift < TARGET_LONG_BITS && (byte & 0x40)) { + if (shift < 64 && (byte & 0x40)) { val |= -(int64_t)1 << shift; }