From patchwork Fri May 2 18:56:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 886644 Delivered-To: patch@linaro.org Received: by 2002:a5d:430f:0:b0:38f:210b:807b with SMTP id h15csp963588wrq; Fri, 2 May 2025 12:03:20 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV/yqvy5dnjKYlOixjp3yIfrmC+MPOsgB6EEAU0xDevnjvP2ORRZfgToC/MnYCWRbV2mB1sKw==@linaro.org X-Google-Smtp-Source: AGHT+IE2S85iUNxzAJn0ERNoXjlEbmDvmPEYkJgWgVSlz4tCpQMrwLeoWQ4ionDFEpBSsdzt+JVj X-Received: by 2002:a05:6102:8016:b0:4cb:5ec2:52ea with SMTP id ada2fe7eead31-4dafb6e514bmr3503786137.22.1746212599840; Fri, 02 May 2025 12:03:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1746212599; cv=none; d=google.com; s=arc-20240605; b=Pmo5o1LPf1gfdmFpgJyJklb3zbwSDE5+CMrOXGqkahNx7Sj8sS1cE3lqnV7eXb/v1+ qpM+UeHnyVh55Zxcfyg0vq3JNRncai19gYFOueuPnSmP8kVLpMY1ZtVWrBsTzuTqA3El 0J5wdi9PseO/aD+W8323G0Mz/tuK2EcOy30an5IqNOo4TuAXsnOz/onGVgiFmcV1YSih Vf74UcaxP4+udd5PIPdNN2wzHje/FUyu5c6ZEEMa3ufmzJGGiFA/bYX+r9R+I+l2Bc/W lICvKfMVJYbgjfeDLVPXdFNi8J6cnjJWUUyvLR1GsPrtfCbGmKrianpkT8XCsZ2yMRig Mqjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OvirrR3TiqgBPme4BwNGSV4VqzG47GBw5DwB3TzFavY=; fh=zA7MiWWYdZ7nPYzFPsisQ1XfjLk8wRfRNbrxI2kr3EE=; b=E6WAHRPtUvokfuae2881ga3EJIg/lUkKudL8Yg3APe7fyzXWMD3Dn6Z6maKH2vkPTI eBIiuNTi6jdPpYTJpiYVvrDY0tcd3lgEgl5vIMD0/+vNQ/DtOCY4bq/JDnsFhNFx3opO Xbflu9ruNlpp2coctiuPZOJAh3X79TNRVlgNkroaUHKWB5WiyQ8nZynEblT4UbvLOLQE 6dGBz80JOAmeQMUmsRMc/FLAp0nRyaOT6DGyJwRp+n2VEyc3eI5F0DUdTZT8ylEp4Kz6 lFfxsLmx4HW/yqSld3sp1llT1LZwM1wfZiWM1li1zWRSReQwgiczftAaqog6ZzK9qsHF 7vlg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=afZqr4MI; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ada2fe7eead31-4daf2584a49si962792137.356.2025.05.02.12.03.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 02 May 2025 12:03:19 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=afZqr4MI; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uAvbb-00014E-V8; Fri, 02 May 2025 14:59:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uAvao-00079b-9B for qemu-devel@nongnu.org; Fri, 02 May 2025 14:58:38 -0400 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uAval-0005go-E3 for qemu-devel@nongnu.org; Fri, 02 May 2025 14:58:37 -0400 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5e5deb6482cso6238450a12.1 for ; Fri, 02 May 2025 11:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746212313; x=1746817113; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OvirrR3TiqgBPme4BwNGSV4VqzG47GBw5DwB3TzFavY=; b=afZqr4MI3noG/qSTyUTCbppF3OXeyj01ByXbyxvhFCFT6XKWo2+q0XnaI+VMonWfFV JbeNsKCMWRhtPLc2OU4TgY14d5ra0hGMkVPGdB+mgvyFUhlx+0+l5cLLB4SV9XtouMCh lt7j+aX7KOiMyGGTCnS/l5ApkqOAqgc4MsrAIxi4zsnrbHkOnQBPubptp6h9T9LDuup0 3j7vv+U74vDjhLEoceHDptg/cQRzwfpr2e7USeiaM+UXVUsdMW67BmeqXM82/b7r0Ze7 vVUxGsSFkgjtIz2JU+kMieftADh7sFmJKvIcV3pGw3yPLZJZv40X5b50wqStKBlhcYTJ JwdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746212313; x=1746817113; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OvirrR3TiqgBPme4BwNGSV4VqzG47GBw5DwB3TzFavY=; b=Op+d4TvJU1/qaCBoHGD5ukD2d6XKtbbXOZmqZ/TaPmjFjb1ohXEB6d82MftgvT7Tw5 g1+td4ciBZnNMN0JtbSE/5B2q8zRybeEO/guun1LfvpIvx5p7DtMLRRGVr64wGVpckMo dcr4MhyoRbhizCTDn5MOuXN4N5qDltpPy8YEwxLRZpogaEFTzbzuT03P3xlTQfp10R24 0I0VRm421ipZet2OTUPtG8efC+SrEJFTEBJXAB5OcFmFIRJDgwpGEcKO8NIuDCgjXa0D NoO4OV2EoEegKGAUoBfUglHVz9heSHgnFG3A7I51t2aUoEBbsPWb/GAg8tVyaJAMZoKa Vc4w== X-Gm-Message-State: AOJu0Yxw1ytJvQvZYeCbg0OPrEpMnZL30prIpGFEEnDXz1Ypwncjr0nv /Cm3QOJPi2KlpFRFdiZFb1gYQ6k9j5JepYvF8fyLn6omu8rYGsEWPGew0G4WiaZFbLxgkHlXlxW 4 X-Gm-Gg: ASbGnct58kdvocslDh2jpShZ4BAelocux77/4pOMl6HEE5bHC+DSNZhh67H3FkVI7dp JAO8xY9Uh3OoObr/VQg7MlND00ojxDrzNbQR6USkdDWPKGVoXWtBHVAVQRRhFgl/6TjS0SaJg5A 8xHDtrx70finPvmet+DjppfQYWrH0siVs8jL0h67PwzYsA5jvbQtpP6MTn6m8GLp0MyBd9qAi/y wG/xXpEopLFzdF7MaJvoO34SjoAOnc7mVcBJpZpH0NdxfGavMfjWVgy+gL6RB0Sgx8i2N4jWAcC WEhLefDNBEW2QnUY+mqwPesqZ+utC+bLffDN7xPdFpef/n+imsgujJ/nCwbjszKTCc01cKFdi7y Js7MTbcBKNmwMq5C5G5uLuqfXH0GrSZQ= X-Received: by 2002:a17:906:4fc5:b0:aca:c67d:eac0 with SMTP id a640c23a62f3a-acefe63defemr673247266b.0.1746212313493; Fri, 02 May 2025 11:58:33 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad1891a311bsm88214366b.54.2025.05.02.11.58.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 02 May 2025 11:58:32 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Laurent Vivier , Igor Mammedov , Huacai Chen , Amit Shah , Marcel Apfelbaum , Sergio Lopez , Ani Sinha , Paolo Bonzini , Eduardo Habkost , Jiaxun Yang , Jason Wang , Richard Henderson , Yanan Wang , Gerd Hoffmann , =?utf-8?q?Cl=C3=A9ment_Mathieu--Drif?= , Zhao Liu , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Yi Liu , "Michael S. Tsirkin" , Mark Cave-Ayland Subject: [PATCH v3 17/19] hw/virtio/virtio-pci: Remove VirtIOPCIProxy::ignore_backend_features field Date: Fri, 2 May 2025 20:56:49 +0200 Message-ID: <20250502185652.67370-18-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250502185652.67370-1-philmd@linaro.org> References: <20250502185652.67370-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=philmd@linaro.org; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The VirtIOPCIProxy::ignore_backend_features boolean was only set in the hw_compat_2_7[] array, via the 'x-ignore-backend-features=on' property. We removed all machines using that array, lets remove that property, simplify by only using the default version. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland --- include/hw/virtio/virtio-pci.h | 1 - hw/virtio/virtio-pci.c | 5 +---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/include/hw/virtio/virtio-pci.h b/include/hw/virtio/virtio-pci.h index f962c9116c1..9838e8650a6 100644 --- a/include/hw/virtio/virtio-pci.h +++ b/include/hw/virtio/virtio-pci.h @@ -149,7 +149,6 @@ struct VirtIOPCIProxy { int config_cap; uint32_t flags; bool disable_modern; - bool ignore_backend_features; OnOffAuto disable_legacy; /* Transitional device id */ uint16_t trans_devid; diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 8d68e56641a..7c965771907 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -1965,8 +1965,7 @@ static void virtio_pci_device_plugged(DeviceState *d, Error **errp) * Virtio capabilities present without * VIRTIO_F_VERSION_1 confuses guests */ - if (!proxy->ignore_backend_features && - !virtio_has_feature(vdev->host_features, VIRTIO_F_VERSION_1)) { + if (!virtio_has_feature(vdev->host_features, VIRTIO_F_VERSION_1)) { virtio_pci_disable_modern(proxy); if (!legacy) { @@ -2351,8 +2350,6 @@ static const Property virtio_pci_properties[] = { VIRTIO_PCI_FLAG_MODERN_PIO_NOTIFY_BIT, false), DEFINE_PROP_BIT("page-per-vq", VirtIOPCIProxy, flags, VIRTIO_PCI_FLAG_PAGE_PER_VQ_BIT, false), - DEFINE_PROP_BOOL("x-ignore-backend-features", VirtIOPCIProxy, - ignore_backend_features, false), DEFINE_PROP_BIT("ats", VirtIOPCIProxy, flags, VIRTIO_PCI_FLAG_ATS_BIT, false), DEFINE_PROP_BIT("x-ats-page-aligned", VirtIOPCIProxy, flags,