From patchwork Sun May 4 05:28:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 887180 Delivered-To: patch@linaro.org Received: by 2002:a5d:430f:0:b0:38f:210b:807b with SMTP id h15csp1492745wrq; Sat, 3 May 2025 22:37:07 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXqSkt/WMB9Yi+1aDNV0DNH/0f1AIo3aysU3pWQGfiZjkFRh+J594IeQvNMUD4KLSBwouB60Q==@linaro.org X-Google-Smtp-Source: AGHT+IFQB3uSCYV2mIjR4HJHiHj3SX0v67FXfUalx1YZtqt400buEdfqFJy5w7NfvQedmzsLqBoF X-Received: by 2002:ad4:5be2:0:b0:6d8:9062:6616 with SMTP id 6a1803df08f44-6f528c3693bmr53752096d6.7.1746337027080; Sat, 03 May 2025 22:37:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1746337027; cv=none; d=google.com; s=arc-20240605; b=X3eiKN7BXft8+D9VYEDsigBNlMB5FDrN061YKQDdTiIrpB3crX78JkHVvqFWv7Yp7y ble8sRJIVT12aoDUyC9dhEBC/4mY2BumtV2qffGsi8j0wYQJRfO7FLrr5BGsIFFEYPDU JfgyvInj6lqD+i9IhANlF5imkYY8xxhD/AttAQlelbpf8LNfTPkd6VXM/KDgLxVH4fz8 9rrpxwMMuELh2OihgME4BjroTBrREiY3hCDscbYYOxmJN/ZDmm9GOSM2dGPpI3zZeC/K ut4T7GzHJ2BauIL9qtv30WnOTaHQ4367DXuP3e9kDNICF9HX+ETbC4V3GWI2oCUFNag1 jM1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=v1JmSJqnxYquNU/v4UOEtwOcqbxnEb6aDiKyyBWqJ6s=; fh=02AUoSaH/mYMQTzo2+A6j8m/qDfXAxVzTrBZ7wPvRqc=; b=IGeMWZ7tVtTSXhnt9MaI32w203D8JGdJVrePok0oJYlnbArCS3LYaVNtESKfj+GmQe Rk0RMRD347Q2hkrhkxcLpPRJ1C7iU+ZdCcYnnjx6KX061wa1FeUoNQHyMfHFRiDy/FZF LPkcziBRLbAlN6Pc5rAejuMyogE+lMobwfHznX4ve1e5/Zeq/db1nJCXOp1yc8EC5bQL QLJvoDAZBO6wFAHoBkKrrQT2hwgSC530G9qSMMyvRUlfNf3MMMYZgKbdHTFlsSzXqYxl V0Hz1O80eKQgzYB9PKGCL1QHASjWuXlQhjxLMCDtkabLZCCXwCqdL8/4QEpW8RNAVH0X sTZA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DK5EXCDB; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6f50f3bf3d6si68632286d6.162.2025.05.03.22.37.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 03 May 2025 22:37:07 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DK5EXCDB; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uBRut-00020d-1E; Sun, 04 May 2025 01:29:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uBRun-0001xP-WF for qemu-devel@nongnu.org; Sun, 04 May 2025 01:29:26 -0400 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uBRuk-0004FM-TS for qemu-devel@nongnu.org; Sun, 04 May 2025 01:29:25 -0400 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-2260c91576aso30454995ad.3 for ; Sat, 03 May 2025 22:29:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746336561; x=1746941361; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v1JmSJqnxYquNU/v4UOEtwOcqbxnEb6aDiKyyBWqJ6s=; b=DK5EXCDBdOpqJ/Y0yEOXTOV5HFi9J/+h6fDak49CwfokFk62mPToaxvmhIqSUCTav0 XfTsn+hMNHPsPHe+KM3BOrVC+GiiMASTcDPUb36rqUBX48QmYZDrtyFHLM6nNNWgYjIL mICeVM9cmGT58GkFo+S1HCdKBe3SZMGc+tuLUSIBPLl1mQimd4Rm6aIOW93l0pGCOEKt VjMHLCCb+f2SIAkF+4u/Xqp3yzrhYUhAn7KdF5Bcke79mgMYNTv48v9BEB5xtSwZ4nV4 jY/qIrATpGInPb/WmfoWxff920qPrLZ1IheLNvXYf8BC6MwpMY1Asp1svN7UGu7bhHtK +hIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746336561; x=1746941361; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v1JmSJqnxYquNU/v4UOEtwOcqbxnEb6aDiKyyBWqJ6s=; b=XlmgaONDqxjIIe1IYrktvxdPHz2YXm7FMwVUmgXc3yTvr5Cnlsv2R0w9Sy6m/4kyBp AiQv6S1JT43yB4rsfW7nMbvAjfPdXUDRShdx3Rq4bUxjJLjfdT6Lj45Nz/VuBA02BNSI aNzl4g8jmWxyRGxneLXuljpZCqcvmgy16XZSDCIbGAzPAsT0t18zzutN86UW8/NbesL8 T+LqQ0C5G5RBj3mxv/fQIQd7lxJ03MjSK325tyaX8AVNBWuFXEwpCk3pOTc1azsFIHyv 9xtymrZ7HR2XX9lol7BC/bPNgqHBbGt1z3UDxkc27ulPhsa2ofdXxZu4v5v5ufgAQ8uP 6Rug== X-Gm-Message-State: AOJu0YzsQHryO8npyawl1otyPVqjl2MN+vR0WMUKoeQKng/GuOzo9hlY AVDNcj6YY/gxCGbh2hOR/8E/iDoDyyBaXYmW7wFpfFhNsgqXrw52F73wJMcGuV1nPPeUHJyJplY rpzo= X-Gm-Gg: ASbGncuwWIxG926cSVrtd+9+Q1UUGHcCsjdAhXDEgZBNWzuvOtA13mz6ASxf1AbHAkZ tFtkDXkO9ObLhWZUBREhtHIwX9ZKkoweTZ6B7BW3BXS+o3CuH2xK+WSc/+KjdqpCuZZD3RRpeTv HuMAKk3v2Yr8s8spy91UZtGarxIvsMKMDTqA7bTbzn7VZ1D0nK7RWA3OEFdEZy5tqPJyo4EI9hT +97DQ/OIji+pSC5GslJpBC6F5i5IonKyEk5ycSfJJBeRSZFLdTn9XR5bFS/UhuifxcsEH4zFr56 3GWuT+dCk245iTO6WEBJOKMLMhe8XNSnVT6fbaR4 X-Received: by 2002:a17:903:1246:b0:224:e33:889b with SMTP id d9443c01a7336-22e1ea3ced2mr48331655ad.12.1746336561460; Sat, 03 May 2025 22:29:21 -0700 (PDT) Received: from pc.. ([38.41.223.211]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-740590207e3sm4400511b3a.94.2025.05.03.22.29.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 May 2025 22:29:21 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-arm@nongnu.org, anjo@rev.ng, kvm@vger.kernel.org, richard.henderson@linaro.org, Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , alex.bennee@linaro.org, Pierrick Bouvier Subject: [PATCH v4 01/40] target/arm: Replace target_ulong -> uint64_t for HWBreakpoint Date: Sat, 3 May 2025 22:28:35 -0700 Message-ID: <20250504052914.3525365-2-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250504052914.3525365-1-pierrick.bouvier@linaro.org> References: <20250504052914.3525365-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pl1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé CPUARMState::pc is of type uint64_t. Reviewed-by: Pierrick Bouvier Reviewed-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- target/arm/internals.h | 6 +++--- target/arm/hyp_gdbstub.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/arm/internals.h b/target/arm/internals.h index 4d3d84ffebd..c30689c9fcd 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -1949,9 +1949,9 @@ extern GArray *hw_breakpoints, *hw_watchpoints; #define get_hw_bp(i) (&g_array_index(hw_breakpoints, HWBreakpoint, i)) #define get_hw_wp(i) (&g_array_index(hw_watchpoints, HWWatchpoint, i)) -bool find_hw_breakpoint(CPUState *cpu, target_ulong pc); -int insert_hw_breakpoint(target_ulong pc); -int delete_hw_breakpoint(target_ulong pc); +bool find_hw_breakpoint(CPUState *cpu, uint64_t pc); +int insert_hw_breakpoint(uint64_t pc); +int delete_hw_breakpoint(uint64_t pc); bool check_watchpoint_in_range(int i, vaddr addr); CPUWatchpoint *find_hw_watchpoint(CPUState *cpu, vaddr addr); diff --git a/target/arm/hyp_gdbstub.c b/target/arm/hyp_gdbstub.c index 0512d67f8cf..4d8fd933868 100644 --- a/target/arm/hyp_gdbstub.c +++ b/target/arm/hyp_gdbstub.c @@ -54,7 +54,7 @@ GArray *hw_breakpoints, *hw_watchpoints; * here so future PC comparisons will work properly. */ -int insert_hw_breakpoint(target_ulong addr) +int insert_hw_breakpoint(uint64_t addr) { HWBreakpoint brk = { .bcr = 0x1, /* BCR E=1, enable */ @@ -80,7 +80,7 @@ int insert_hw_breakpoint(target_ulong addr) * Delete a breakpoint and shuffle any above down */ -int delete_hw_breakpoint(target_ulong pc) +int delete_hw_breakpoint(uint64_t pc) { int i; for (i = 0; i < hw_breakpoints->len; i++) { @@ -226,7 +226,7 @@ int delete_hw_watchpoint(vaddr addr, vaddr len, int type) return -ENOENT; } -bool find_hw_breakpoint(CPUState *cpu, target_ulong pc) +bool find_hw_breakpoint(CPUState *cpu, uint64_t pc) { int i;