From patchwork Sun May 4 20:57:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 887210 Delivered-To: patch@linaro.org Received: by 2002:a5d:430f:0:b0:38f:210b:807b with SMTP id h15csp1753384wrq; Sun, 4 May 2025 13:59:08 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUVBR0CFsRSxBhxRnqQJgMf4uvArUoGBL7gXrvlJ9rhJz1ImJlGHHftldXLMTPAXVxxARVnwA==@linaro.org X-Google-Smtp-Source: AGHT+IGJ2GYWuroIH+WWWLhBvYtAK77Ewxh6kLG5gUzF0WkBK+fIO5hHl4kye3wJOz+2CqsK88Xm X-Received: by 2002:a05:622a:2d5:b0:477:6f28:3eb7 with SMTP id d75a77b69052e-48dff2e4cf4mr82335301cf.3.1746392348189; Sun, 04 May 2025 13:59:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1746392348; cv=none; d=google.com; s=arc-20240605; b=kg7GQ7D9n3ckcJTE0h8fmdNa6/cZnxcweilwnzIAysw6GP0nHvCF+xBfpqaKV5YRw+ D9ZHrd/x7z+k2jQnYl6wSq5V+/D2FmqJTlrshC1PL7XVhF+N3pmnSZAdeXYhCTW2JS6M ugCIWlcj/ixYbE//YsX8Ojb8t/Oqbj/SMX6eFcUDHcN4GMlH5ToMm/MZFuhFb6fszskU BbChY3AY0MNPwymz/q5cWVKtQs4k/mOVLnvrVUhRGSWGjnR2CnkQls8NVhUPpBqnAV7w DP3kcZ+g8JKCGQwdH98SnI/DknJB26NQlUtNRY0QT6LfXLH1JojV+sBqfR/kskl3sZSr WObw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OmHqHslUT/R30MADH7naEbPJDNCBfrJgNIi18eIVP5E=; fh=p4CKtYrQK6yyWfCx0ot7WxlRzfTesnQjI81xstJJeSc=; b=R2tqfol0yuf2d5rOOdAdw4ITVu8FaDDz/wUvvK2UwQ5g9EmLjbCrp7FH9Q5DmITTd4 pUx3NwLILa0k4f0j5LwKZju1divDPCR5+J5Oqide5/nijfn76c8d20jG573rbXLdEY1I hCEHN1PnRppVClPCComTu3G4RnBqUhs3LxsrCYDnlPaKPMUj4UnnJG1pyFqymrL8VA5C 6s54RFV0XyN9PLsmTexmIIrZbbtYhO9THR+sr5yfeVV7VMqMJwkqOJ6mh+ZCO/xAwOQY fzK95zqWVET+U0Nk1rNEHwc+BusZ31RK0z/A8DViKoLjY2DqBfJA+wRw8gvj5qDRQKZM mvCg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=K5u+E651; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-48b960ce216si80690331cf.116.2025.05.04.13.59.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 04 May 2025 13:59:08 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=K5u+E651; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uBgOx-0008Q0-Qa; Sun, 04 May 2025 16:57:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uBgOm-0008L6-NQ for qemu-devel@nongnu.org; Sun, 04 May 2025 16:57:21 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uBgOk-0006vv-GB for qemu-devel@nongnu.org; Sun, 04 May 2025 16:57:20 -0400 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-223fd89d036so41535795ad.1 for ; Sun, 04 May 2025 13:57:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746392237; x=1746997037; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OmHqHslUT/R30MADH7naEbPJDNCBfrJgNIi18eIVP5E=; b=K5u+E651IscuzU6KpLuc0vkrzE1la7iVtoVZoQBUfq9WtxrlZRf0SQMUMIDY8qe00M tcU41jJ7LSCCw6oC/1M9anUhOJdwhR7q9jyPTHTIe2t6N1+lo9eNgfh1HuUU2E63nXLV 1MrnuIf/8GtCZ1NhRfm81HXq2t0i/g15j7zU6e575x+Y1Wkubko1RZ1+n6iXEe/7nJHR 690kPM5XNq6wPpKxYajxKt/IYn3ASsCk+IX/KN1wyFnuoHBTseFp+eHovFG51pyfpkFo 08yIyLtUDKANw5gWM5x/KlFcV/aeNPfZp3Fdni20wHJE09yS8f+XH4gZdBg8TonDR9zq JMHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746392237; x=1746997037; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OmHqHslUT/R30MADH7naEbPJDNCBfrJgNIi18eIVP5E=; b=RAzvsYeA9JkrBhBzjNaHmL5EgcKS5gePb1BMovetzZ7KSgvOEMKDP6B7KN2knB2FeU 8xCLh7QdSwwtgO3P2BzcCKcSZH4NKOAUUUEkxQ17Wb9V7MdbiP1uJ6Iwmp9F+zelyJno mFgnvKSqMCMAeL81fPkMWob/LIbZZBtcF0WYv9h4CKLkhRBfI8aO1bgmeGc/n/5U8JG1 5O9hHY0kTMRKhZKR6e1UKVFrxlm4iDW3pWj+TCc4C9zgUwHSgDxyJMfaKtmb3TxTSma2 EKkpYncdAxCQDUQflyRkHq0Vg4Jo0M9Wqr5lGulyvqpSsL+e814eIt+6kjLvvgBF7GEJ bNpg== X-Gm-Message-State: AOJu0YybcIQJTmhwfa5TJBjnTz/KFefyHv+4RDp3ArTZCSFh6WsclEHa Rv9IQ3TDbIGkWC7yUWg6IRlYtopyo37dvEkbkn+F+GjH3i+nURCuZh69KYF/6tYbTRb8hCKrK+U Z X-Gm-Gg: ASbGncsWV+kFM4No7tJhSfUbrFAKxtI5dCdi0xDmLK0Ak+wrxb21d9VGxX3XTzRzGBE nM5CRyUnUOnN9hMIQLLeBMRRZxrNDhB6svQy/kCsQJbhrY01FmWV3KRoaoE9nKv9NWJVRS9/OR0 4dYvzRjt6ABA9ik+rpdQ/aS5tYklvhD+YLLDy/yQDPCukllkndbYOkhKf+mkEQykDjf3YJxwi9o yXsvA3cicCL8mD3cn0HpkWYECVJRm1bbbFMw9IZhRlpm5HrLkwpy1tCFi4i1CKyz6Hp39UZ0xio daSYDh/gaDXocl1HzMtwCU3Uoh/BqgEW9izFDPKW9JAVVfeL/VFNkUYLAOejLwBeqoGAeg/sg+I = X-Received: by 2002:a17:903:1aab:b0:225:ac99:ae08 with SMTP id d9443c01a7336-22e1e8c1fc1mr67896135ad.5.1746392237069; Sun, 04 May 2025 13:57:17 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22e150eadfcsm41346425ad.32.2025.05.04.13.57.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 May 2025 13:57:16 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: foss@percivaleng.com, Helge Deller , Yoshinori Sato Subject: [PATCH 02/12] target: Use cpu_pointer_wrap_notreached for strict align targets Date: Sun, 4 May 2025 13:57:03 -0700 Message-ID: <20250504205714.3432096-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250504205714.3432096-1-richard.henderson@linaro.org> References: <20250504205714.3432096-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Alpha, HPPA, and SH4 always use aligned addresses, and therefore never produce accesses that cross pages. Cc: Helge Deller Cc: Yoshinori Sato Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- include/accel/tcg/cpu-ops.h | 5 +++++ accel/tcg/cputlb.c | 13 +++++++++++++ target/alpha/cpu.c | 1 + target/hppa/cpu.c | 1 + target/sh4/cpu.c | 1 + 5 files changed, 21 insertions(+) diff --git a/include/accel/tcg/cpu-ops.h b/include/accel/tcg/cpu-ops.h index 83b2c2c864..4f3b4fd3bc 100644 --- a/include/accel/tcg/cpu-ops.h +++ b/include/accel/tcg/cpu-ops.h @@ -322,6 +322,11 @@ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vaddr len, */ int cpu_watchpoint_address_matches(CPUState *cpu, vaddr addr, vaddr len); +/* + * Common pointer_wrap implementations. + */ +vaddr cpu_pointer_wrap_notreached(CPUState *, int, vaddr, vaddr); + #endif #endif /* TCG_CPU_OPS_H */ diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index c394293d33..75cd875948 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -2932,3 +2932,16 @@ uint64_t cpu_ldq_code_mmu(CPUArchState *env, vaddr addr, { return do_ld8_mmu(env_cpu(env), addr, oi, retaddr, MMU_INST_FETCH); } + +/* + * Common pointer_wrap implementations. + */ + +/* + * To be used for strict alignment targets. + * Because no accesses are unaligned, no accesses wrap either. + */ +vaddr cpu_pointer_wrap_notreached(CPUState *cs, int idx, vaddr res, vaddr base) +{ + g_assert_not_reached(); +} diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c index 890b84c032..2082db45ea 100644 --- a/target/alpha/cpu.c +++ b/target/alpha/cpu.c @@ -261,6 +261,7 @@ static const TCGCPUOps alpha_tcg_ops = { .record_sigbus = alpha_cpu_record_sigbus, #else .tlb_fill = alpha_cpu_tlb_fill, + .pointer_wrap = cpu_pointer_wrap_notreached, .cpu_exec_interrupt = alpha_cpu_exec_interrupt, .cpu_exec_halt = alpha_cpu_has_work, .cpu_exec_reset = cpu_reset, diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c index 6465181543..24777727e6 100644 --- a/target/hppa/cpu.c +++ b/target/hppa/cpu.c @@ -269,6 +269,7 @@ static const TCGCPUOps hppa_tcg_ops = { #ifndef CONFIG_USER_ONLY .tlb_fill_align = hppa_cpu_tlb_fill_align, + .pointer_wrap = cpu_pointer_wrap_notreached, .cpu_exec_interrupt = hppa_cpu_exec_interrupt, .cpu_exec_halt = hppa_cpu_has_work, .cpu_exec_reset = cpu_reset, diff --git a/target/sh4/cpu.c b/target/sh4/cpu.c index b35f18e250..4f561e8c91 100644 --- a/target/sh4/cpu.c +++ b/target/sh4/cpu.c @@ -296,6 +296,7 @@ static const TCGCPUOps superh_tcg_ops = { #ifndef CONFIG_USER_ONLY .tlb_fill = superh_cpu_tlb_fill, + .pointer_wrap = cpu_pointer_wrap_notreached, .cpu_exec_interrupt = superh_cpu_exec_interrupt, .cpu_exec_halt = superh_cpu_has_work, .cpu_exec_reset = cpu_reset,