From patchwork Mon May 5 01:51:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 887422 Delivered-To: patch@linaro.org Received: by 2002:a5d:430f:0:b0:38f:210b:807b with SMTP id h15csp1824815wrq; Sun, 4 May 2025 18:56:43 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUchU0Qx1wAyj5EDAyNIBOeE/AuDNRcVm355hjKNQL7at36P9gtQ+5DEvaTAWmuU5yRK1Fasw==@linaro.org X-Google-Smtp-Source: AGHT+IHyplz3jk6HbjYvFoP5EUa1b+RokdZ20MN5PMQlhCpb0aPOr7BsIOtPsPLoqtiVzPbn7haG X-Received: by 2002:a05:620a:f0d:b0:7c5:af68:5019 with SMTP id af79cd13be357-7cae3a9f7fdmr631437885a.13.1746410203315; Sun, 04 May 2025 18:56:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1746410203; cv=none; d=google.com; s=arc-20240605; b=RHAyjxUtv+wu9SOc1bnM8nucXCfQngXiA2jlAUjzO0NsXT3MJWxJOayMr8kKxHsKJD nsu6dng5Hjcb0xxcKmsYVXEFpg58y2PU44z7z0cVvMUuhNKl5Q+zAx+GlyVfXmfn/RRf LYm3QCcadNmwvy8hmgdjD592nmpY0k16P7ti/vXrrZmee98S0zn+AmA0RCSA2YE3EXdr 2bSp7Lx+EUA15Ds/KJmG9cCkWf48QbxoEf+1NscWcQ497WMKNZQUSctyOIJNWQhK8sOd sFuDTAcYZznuQOOfMeglDoPDN6MXOvEeECOw6NEY9/IasR/q4/kHu5g5pegoF/wogkye 5j1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=v1JmSJqnxYquNU/v4UOEtwOcqbxnEb6aDiKyyBWqJ6s=; fh=NjGqp/B1Bwp2wtTnyHxTvlXYBfwRSGY9cE7hmKIZquY=; b=LTjBD3emBPxN0dFyZi3ywrSuKi06wv5ANKHKFvPOKMB6abYa47JLN1lOyOheVpdCff oAQejlPWo9H3FiqQppVms7qtLtaZtKNCuTseYSDvPzssfYg/iD1BnVxaVFzl9i0gDm9s c5KXcUfTOB1CaZ1yDBqKuxG00JxjOeaI9PgAzxHNTGsh8RMB/Nv8UOx/2oYqf/oNxmsf ms3HaawVgMYqETNvcEV8xNfyLbxDWgn+3fEANCSP2elGyV4kcmzoXlfhEsqMbKY8/yik s0zSFklAxLaRSROWh6EyLL3/60asKBSRZvFFrcwJL0BqEk7kezxccATYc736OC4QdAH4 WalQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PvV61gtt; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7cae90b1b2dsi163061585a.581.2025.05.04.18.56.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 04 May 2025 18:56:43 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PvV61gtt; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uBl0X-0003ph-Uj; Sun, 04 May 2025 21:52:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uBl0X-0003pC-4c for qemu-devel@nongnu.org; Sun, 04 May 2025 21:52:37 -0400 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uBl0P-0002TU-5S for qemu-devel@nongnu.org; Sun, 04 May 2025 21:52:36 -0400 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-736aaeed234so3388599b3a.0 for ; Sun, 04 May 2025 18:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746409948; x=1747014748; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v1JmSJqnxYquNU/v4UOEtwOcqbxnEb6aDiKyyBWqJ6s=; b=PvV61gttBEt9KLNkVapC7/cLVo62EqS7t0Q4TH86BH02CeFTMYn+wH9Qe8PZ+OHTj8 L3R5hQ/ptb2/0i8lCt2nYBRmGj9z1U4xFtQZO/Bet5mF39i8fpTXPAfN7nA7UuubPcYt kPHg1ti09cMJ/npjsyazHQTEfqWqFL3UsTcXnbx54Yi9klcvsKU9vnNvx9yoNxxzFmwH L+fTQo6koMLnnfzuBf1NsqAAvlY9EjzT3ZzQR35Ik8qTRHq96359eFMbJkNcFXlZ2AZb LYSwu3ID7QsVlSNmHA9Tz3QWjcssbeB7VUJNYvVwGpsAVr5NRO0tG9PtVl/obos8Ppaa TWzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746409948; x=1747014748; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v1JmSJqnxYquNU/v4UOEtwOcqbxnEb6aDiKyyBWqJ6s=; b=gr6juMZYB81JY2bfUMkLYClgpWRMPaHWc95JbxZdeEPg7wzJDr0vfWSdhys8RHQ59f ZB66/4kOVq7gZNvvnnKolXavQCNaYIpe7CWcellVhx3Nvk0vuPrY86CBqelFaKkckkz7 4nXffi3WqWTJC3tO/w8e+VUrbyGLc/D0R5G8qfwfg8E4tdhMV2QzNrYknL7MdYLfaIhM /gPABsKvzhLdObEqCtnZfyeCaHY5xne7e9GXJSTA7BqAE1XjZLdQ3OmlZ1mG6cwozoNh y+KEAo6vuIfvDr7b8oAHRrW8LPpiXw1nGGNMIIwOz8Ax0LWg+fIDeBf4fIY2s62lYvoT RY8Q== X-Gm-Message-State: AOJu0YxfV1bbz+JoyEXYSqIAW2az5IlNvSNNzeBsfUmbTs7PYsmaYaqf L1PgVGUxYq8Nr4wO+uneI5PLW7LyehRUPAnTKEcYC4YVbm2K33K7+gKxkU3zsDbWCc2Pug/e5nT C+3M= X-Gm-Gg: ASbGnctXVdnRTayWkyGo3wWfzam1s1pfDNyg3lGMKJgp0w43piSn2W1dYQcLTsPqI4b GG6uA7duO5hb8Kqg5qSu4SmndFbM8dveCf+XPibV6rN1XIrKE36bQZmhFRsd7G/NJJt2Jl/U+vR FEURtQ3l1Ok9HR8PlI0kMfJJOnkHfbGF3RU+y5286IXTfFSzx5dX4vJd6vhWeOGb9WfUR0/sozo RteVCoB1rKxdJDCBg6UzShcFuqFjERQ2BtiaTj228TvktMjbjxiiPHkfkUuLplHLmxuruKzez/u xNNkgH/sZDQ2V5YkEVys15/6XjWUzwp3QlLGAAlC X-Received: by 2002:a05:6a21:8dca:b0:1fb:e271:82e2 with SMTP id adf61e73a8af0-20e96605502mr7410585637.11.1746409947932; Sun, 04 May 2025 18:52:27 -0700 (PDT) Received: from pc.. ([38.41.223.211]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b1fb3920074sm4462101a12.11.2025.05.04.18.52.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 May 2025 18:52:27 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-arm@nongnu.org, richard.henderson@linaro.org, alex.bennee@linaro.org, kvm@vger.kernel.org, Peter Maydell , anjo@rev.ng, =?utf-8?q?Philippe_M?= =?utf-8?q?athieu-Daud=C3=A9?= , Pierrick Bouvier Subject: [PATCH v5 01/48] target/arm: Replace target_ulong -> uint64_t for HWBreakpoint Date: Sun, 4 May 2025 18:51:36 -0700 Message-ID: <20250505015223.3895275-2-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250505015223.3895275-1-pierrick.bouvier@linaro.org> References: <20250505015223.3895275-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pf1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé CPUARMState::pc is of type uint64_t. Reviewed-by: Pierrick Bouvier Reviewed-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- target/arm/internals.h | 6 +++--- target/arm/hyp_gdbstub.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/arm/internals.h b/target/arm/internals.h index 4d3d84ffebd..c30689c9fcd 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -1949,9 +1949,9 @@ extern GArray *hw_breakpoints, *hw_watchpoints; #define get_hw_bp(i) (&g_array_index(hw_breakpoints, HWBreakpoint, i)) #define get_hw_wp(i) (&g_array_index(hw_watchpoints, HWWatchpoint, i)) -bool find_hw_breakpoint(CPUState *cpu, target_ulong pc); -int insert_hw_breakpoint(target_ulong pc); -int delete_hw_breakpoint(target_ulong pc); +bool find_hw_breakpoint(CPUState *cpu, uint64_t pc); +int insert_hw_breakpoint(uint64_t pc); +int delete_hw_breakpoint(uint64_t pc); bool check_watchpoint_in_range(int i, vaddr addr); CPUWatchpoint *find_hw_watchpoint(CPUState *cpu, vaddr addr); diff --git a/target/arm/hyp_gdbstub.c b/target/arm/hyp_gdbstub.c index 0512d67f8cf..4d8fd933868 100644 --- a/target/arm/hyp_gdbstub.c +++ b/target/arm/hyp_gdbstub.c @@ -54,7 +54,7 @@ GArray *hw_breakpoints, *hw_watchpoints; * here so future PC comparisons will work properly. */ -int insert_hw_breakpoint(target_ulong addr) +int insert_hw_breakpoint(uint64_t addr) { HWBreakpoint brk = { .bcr = 0x1, /* BCR E=1, enable */ @@ -80,7 +80,7 @@ int insert_hw_breakpoint(target_ulong addr) * Delete a breakpoint and shuffle any above down */ -int delete_hw_breakpoint(target_ulong pc) +int delete_hw_breakpoint(uint64_t pc) { int i; for (i = 0; i < hw_breakpoints->len; i++) { @@ -226,7 +226,7 @@ int delete_hw_watchpoint(vaddr addr, vaddr len, int type) return -ENOENT; } -bool find_hw_breakpoint(CPUState *cpu, target_ulong pc) +bool find_hw_breakpoint(CPUState *cpu, uint64_t pc) { int i;