From patchwork Tue May 6 12:57:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 887767 Delivered-To: patch@linaro.org Received: by 2002:a5d:430f:0:b0:38f:210b:807b with SMTP id h15csp2532145wrq; Tue, 6 May 2025 06:03:01 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWeVTbPVVTbdKSgri7W8FOR655N1eG/laedFS0cBbrxoQQ+w+cXzLShbJVKCT2Hsq1zPnY4dQ==@linaro.org X-Google-Smtp-Source: AGHT+IGsAH0+aenzcEi6RM7NHnrmcrxSfPz3LYh5R3wNWWbmo3jPX3d24LtliUJ5tTlLvKVCpTOt X-Received: by 2002:a05:6122:3181:b0:52a:bf74:7e43 with SMTP id 71dfb90a1353d-52b06668fb0mr4728889e0c.0.1746536580913; Tue, 06 May 2025 06:03:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1746536580; cv=none; d=google.com; s=arc-20240605; b=MbaNHPWPocj70zH/rAK+N2Fh7PdLgWfzZ88zcV2Ky24MhtSUWVDN4JwXr0nvGTSooe uyVeU3LaeaOOg4C0MkujVOX/qTIhWyx8DoVkKdEdXu3Yl9y1Jc51hF21O6nekzT4AMwg Z08vJd4Q1sSRA2ZD0TsZMUI1GG7LOmqYiOknVW6MPiziBdMlreka2JVuTMUNfyGkBaOw d0RT79/EgrE8Jp0nQY9nYimK5XSXmVtSfCDmaz9uSxBXXhC3esRmY5e7BqiZSG6giE0q CYXhJfwG4BFtsAmomV7wKJHidWle8Pa/N4KpOFfgzLcVM3x36m8O+KPocnuzOKgjAFiH 74Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=EQgFawT5s/msfN0Ty0yYdLDwFLO4xopk0Jf5DyIhBiU=; fh=S2o+fCk3l/gY4fAPMZHpG+liFqodIM8cU1n0Cx40tZ4=; b=gErik8nVciifKzvt7S0DFXqkTfSz09nmhkS7VGVfWAqtGeFib6LmAddOpad12QR94b cfj3xJea90GxJ1OcB/iLDUELNKbPGIZ8Ur6ZjJmfMvVp2oiJFwIFf/fni8Mwx7VH1N0D PidprIZS7FcX+oed+jX0EkFSc1QnNyQtvZcbirfvWz3mchSE8+MczdLz97e2Tmll4NkS /HGdwdy9hZ35ko0yERBPWxdjvIsJ5ikVV8jyb07CSDInRsLYJksDfLhJYlAo8dyDq3Id 7RVXkvokezNhsl5tf5m0NtDdKQMvksU5VzL64mt8hM6cYl/nHCNUeYgzxCPkexHTtFr+ mRrw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gTsdj5Ji; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 71dfb90a1353d-52ae4001f83si2795688e0c.15.2025.05.06.06.03.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 May 2025 06:03:00 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gTsdj5Ji; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uCHrt-000491-Fa; Tue, 06 May 2025 08:57:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uCHrW-0003Vl-Ow for qemu-devel@nongnu.org; Tue, 06 May 2025 08:57:31 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uCHrR-0003sL-Rc for qemu-devel@nongnu.org; Tue, 06 May 2025 08:57:30 -0400 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-ace333d5f7bso1060087266b.3 for ; Tue, 06 May 2025 05:57:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746536244; x=1747141044; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EQgFawT5s/msfN0Ty0yYdLDwFLO4xopk0Jf5DyIhBiU=; b=gTsdj5Ji21JeIrkpz3igLeZPhMUSE/GoGKz5jMo7uPGIGr0N+efOTzf1akyihKG8X6 2RV++LnRpSsZB5jgNFUOTSR4LWqN/kZemzUHnLlIpO+YgRBJshoRUoNaomnFDEf+Kd66 z+w9s1kAIgDZJuZh7wr03/Aq+EfRtAH6j5IuV+YVAxutcoJyuVv4lze1Pz+byOUQntf+ ANROAQMy8KZBhgSeH9BYQOe0DHH9tqPHvCqqTl2h1CqcvFg2IOhdyYK/6WBpDXV3U1RP cEXDPjxtzau07KJCjJXMlwR5Bu/XGTgcUMeZKCdRE7NlQ92KpJ1QXTStp4/Nmuxm//aw NiJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746536244; x=1747141044; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EQgFawT5s/msfN0Ty0yYdLDwFLO4xopk0Jf5DyIhBiU=; b=cRM43wVJTHJICXsDwioTlv893GknWU15jESrJePLSLcMUx2OI0sWD7qnTh8JN5Rdjo T2CwlqZY2VoButqrOTfyWlKp9ZAfZ2HJqQmVnYLFAWEp5pRxwhmiO2bX7wlyA+6I7Xas slLeJiiEK5mtf1YWGZEsAfFIIZEk9r1gizU8qMhV+6GSAOuqtiO4UpuWzDQp6xfw67vr vqs8CO8wLmu8UFfVNBCTUZmqefRNaKfGoUnt8YSFIMvRBV9F5i9OVDWFhgW4pVMNFuvX Q4CuOrJ6RqAGFAkch2gNmwdHYUqhrHNf/SfgE8F9iA/+IOCIdlXjz1FhQNj+FMY9lxIZ 136Q== X-Gm-Message-State: AOJu0YxScQtBV8Jo2hhfOJED9YXnSkMoMGpOYGA5rtsdskBxQpQtpvdR ziBAqyBgOYB7s7LE2Tvehr+KnG0Z41uaduye/dez1sZpC7hbMSKLv8IR+f36nZU= X-Gm-Gg: ASbGnctie7a5ayyHoDFoMkzGt+oFY0+vDr66Vvzbv9JLlMB+DDm7/dahwvd82geyoAS ZfAGtubgkldPgwKcOKDhikhOge3fg5mGoITP3zNCScA3EPDD95m4YTnEspGkROjLdFopK8Ec8A5 adlM4zv7scui7oBxkUqenjQIueT8XTT9efV1DtWJZW+lKP9VKxmOBSTgRBqFXes9LFb9CyoPgyM oL3XXbZQQmI9zCWbCs8/gAFfm8GzuxeQ3MEyWFEoqKSoRLIZ4TRCHdtGweCGH5cXVjEhpI8jPnb +cAf6rG1EPqHYqbsEzRAfO1V+WxCF8LhqCEz/MszyLc= X-Received: by 2002:a17:907:2d25:b0:ac7:391b:e688 with SMTP id a640c23a62f3a-ad1a4b7c2e9mr1079826866b.58.1746536244060; Tue, 06 May 2025 05:57:24 -0700 (PDT) Received: from draig.lan ([185.126.160.109]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad18950b5c3sm696344566b.159.2025.05.06.05.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 05:57:22 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 3F95E5FADB; Tue, 6 May 2025 13:57:16 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , David Hildenbrand , Akihiko Odaki , Dmitry Osipenko , Laurent Vivier , qemu-arm@nongnu.org, Mahmoud Mandour , Markus Armbruster , Pierrick Bouvier , Paolo Bonzini , Sriram Yagnaraman , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Peter Xu , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , John Snow , "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Thomas Huth , Fabiano Rosas , Peter Maydell , Alexandre Iooss , Dongwon Kim , Vivek Kasireddy Subject: [PATCH v2 12/14] ui/gtk-gl-area: Remove extra draw call in refresh Date: Tue, 6 May 2025 13:57:13 +0100 Message-Id: <20250506125715.232872-13-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250506125715.232872-1-alex.bennee@linaro.org> References: <20250506125715.232872-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x62c.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Dongwon Kim This partially reverts commit 77bf310084dad38b3a2badf01766c659056f1cf2 which causes some guest display corruption when gtk-gl-area is used for GTK rendering (e.g. Wayland Compositor) possibly due to simulataneous accesses on the guest frame buffer by host compositor and the guest. Fixes: 77bf310084 ("ui/gtk: Draw guest frame at refresh cycle") Reported-by: Dmitry Osipenko Reported-by: Alex Bennée Tested-by: Alex Bennée Tested-by: Dmitry Osipenko Reviewed-by: Alex Bennée Reviewed-by: Dmitry Osipenko Cc: Marc-André Lureau Cc: Vivek Kasireddy Signed-off-by: Dongwon Kim Message-Id: <20250214170813.2234754-1-dongwon.kim@intel.com> Signed-off-by: Alex Bennée --- ui/gtk-gl-area.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c index 2c9a0db425..9f7dc697f2 100644 --- a/ui/gtk-gl-area.c +++ b/ui/gtk-gl-area.c @@ -129,7 +129,6 @@ void gd_gl_area_refresh(DisplayChangeListener *dcl) if (vc->gfx.guest_fb.dmabuf && qemu_dmabuf_get_draw_submitted(vc->gfx.guest_fb.dmabuf)) { - gd_gl_area_draw(vc); return; }