From patchwork Wed May 7 18:03:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 888085 Delivered-To: patch@linaro.org Received: by 2002:a5d:4683:0:b0:38f:210b:807b with SMTP id u3csp514735wrq; Wed, 7 May 2025 11:06:46 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUeCl3kKQKv4oHTg9jC35aMdH1vp/G+7LIBjpSU43gy6F9h5510qXaSA0KBfTk06owp0kLetw==@linaro.org X-Google-Smtp-Source: AGHT+IEcSb1BCywu92aWme00JkohsSwMQ+5bCXfWGFQ7Ke8oP45T0llWRndmuRQSe3M4VWRRPEEd X-Received: by 2002:a05:620a:4891:b0:7c7:694e:1ba0 with SMTP id af79cd13be357-7caf73fdb46mr684914685a.44.1746641205859; Wed, 07 May 2025 11:06:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1746641205; cv=none; d=google.com; s=arc-20240605; b=Dqx4SWpCT52xOSpF6HZEaTV7+wCBFwE/2QwtL2EKf70uRxsPQGPozkNIZqUe5J2IPq KwKKWSIX2Tj7jh1UXHUPAI+ZBvD5ib7U4JSbZmkZOX82BFSXQSCvm8wIqDEiTvAXD7XX o9npknGP4Kx+/1pioMtON5zFPUCwZYkcHU5DXvOYl2xC5FOFQcBoIyRYRHaHPL/kIMAO 77DWZmrmS5XsujbDuqJ3rI8znD2Hs1FqbzaJvssYk2X00i5VFZGcn4Dial58cdvu3RPv qae5elRDCtusSsHCUq1Ufb9P34OH1P/twAOu5Rf36N1Qzhcs8HA51uoFGMTQr3eqh7KD /BnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=zowgzkLcZbu4uM1lC7hMGx2wqyEdXYgxko4OxnI+/vI=; fh=IwCXGV4wPY6ObB9cIuDHqEqMPAzAKMp05WxPgfySCiA=; b=QEHJhGetab6FQ9NYgV74rOC0BZeREDzheE83ollLDW8uLU+pXEFZdP6wfU9KzFzE9x Fky5Cw4FHRez3E2DEY/YWWslYQIAYlI2p1hF1WER5w0CsIA85gY3b7WuFlV+KCl2lSwS sDUFmf+c2mOSmhZO25ky1F1gG36pulQDR569iYQZj+0x4clp4S9O9eqUjKkYNQx0TK91 GxqFw30HwZIC5kVpZp7d78H723PGWxF6KYdKZU6n/He/Ma5+Ca1x3TKyzPsMolzU/Oyx swYzMvWnroTsNim/RNx9JgufQ5FJc+b0EAfAiTTjNyI35HXS27gCyQ+Gx6kTXJDu+3bi GuRg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7caf751e7f9si252522585a.70.2025.05.07.11.06.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 May 2025 11:06:45 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uCj8X-0008FR-Bc; Wed, 07 May 2025 14:04:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uCj8B-00089O-NK; Wed, 07 May 2025 14:04:31 -0400 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uCj89-0008Ay-Th; Wed, 07 May 2025 14:04:31 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 36AD911FEFB; Wed, 07 May 2025 21:04:00 +0300 (MSK) Received: from think4mjt.origo (mjtthink.wg.tls.msk.ru [192.168.177.146]) by tsrv.corpit.ru (Postfix) with ESMTP id 09157206700; Wed, 7 May 2025 21:04:13 +0300 (MSK) From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Gustavo Romero , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 06/21] hw/acpi/ich9: Remove ICH9_DEBUG macro Date: Wed, 7 May 2025 21:03:57 +0300 Message-Id: <20250507180412.182797-7-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250507180412.182797-1-mjt@tls.msk.ru> References: <20250507180412.182797-1-mjt@tls.msk.ru> MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Gustavo Romero Remove the ICH9_DEBUG macro, which is only used to dump the value of the pm_io_base parameter, passed to ich9_pm_iospace_update(). It provides little to no value and is not worth converting to a trace event. Signed-off-by: Gustavo Romero Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/acpi/ich9.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index c7a735bf64..9c0b7437b7 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9.c @@ -41,15 +41,6 @@ #include "hw/mem/pc-dimm.h" #include "hw/mem/nvdimm.h" -//#define DEBUG - -#ifdef DEBUG -#define ICH9_DEBUG(fmt, ...) \ -do { printf("%s "fmt, __func__, ## __VA_ARGS__); } while (0) -#else -#define ICH9_DEBUG(fmt, ...) do { } while (0) -#endif - static void ich9_pm_update_sci_fn(ACPIREGS *regs) { ICH9LPCPMRegs *pm = container_of(regs, ICH9LPCPMRegs, acpi_regs); @@ -135,8 +126,6 @@ static const MemoryRegionOps ich9_smi_ops = { void ich9_pm_iospace_update(ICH9LPCPMRegs *pm, uint32_t pm_io_base) { - ICH9_DEBUG("to 0x%x\n", pm_io_base); - assert((pm_io_base & ICH9_PMIO_MASK) == 0); pm->pm_io_base = pm_io_base;