From patchwork Wed May 7 21:12:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 888093 Delivered-To: patch@linaro.org Received: by 2002:a5d:4683:0:b0:38f:210b:807b with SMTP id u3csp586665wrq; Wed, 7 May 2025 14:13:54 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWw10i6xHS4AfQOEoU/k7vw70RZjdv05s4zNv3shEaVi9oWI7lFtnaiomjMy2eL4F04cDTylQ==@linaro.org X-Google-Smtp-Source: AGHT+IEm2y4wPBlKBcllszjjIN3sFt3/YRhVLZnHkrAInAkg1qEMSITvfBpdPuFP7O77Y9MWwRQg X-Received: by 2002:a05:620a:24d1:b0:7c5:e92a:cba3 with SMTP id af79cd13be357-7caf7419852mr799563085a.49.1746652434678; Wed, 07 May 2025 14:13:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1746652434; cv=none; d=google.com; s=arc-20240605; b=VMEsdVORw9nAknmn88EGr1Tj9SxlI/IJ63K/PqTbC1sDwmtsdvslkuWAo+1bp5P5U3 m0k8EkqpbpgJR/FDFlGW99AritlTcuCpcbujsnRcvd0O/UsiEtJCDHHjZpCmc7dNBuqz jwusSxk7ehzVw+NjiZ9KZsA7oQWu3jHZwZ7pDpslBbMssAnxABXzSmNaBkP90+UBSCOv QE38WDOp5o4gV6Rfm+n4t/hHPRt6CjUWnHzEPnCY7dnaPKW/y8Wgz3nHG3MP5iP0j8N4 lU/WCQ0mE1LkcdTJAiMjVl9HlLFonGuby7pr3vjGzMnncuBWla34M3a3I2XOI/C+38SD EHyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jk4EjQefaC29HViyknRVvmNGslUguEBFOQzXT/8c2wA=; fh=oTVbKRIO4+2hI+bP68B7Af9cjxdBfd9rIDcM9SyAXs8=; b=a4R7VAQMm3HcXEzSc/7nU5lBescQdOeWmaDBmgVQoJmqjpdPXXmnVoeTdNDRfrICwk dLHLTtlIMTax4wcL77h1xmkC0KS/7oBEdlb0DZW4uIfhGT1pJO059jBBCNZr8hqiTT1g 4NCPtBkMQS3jSHG7x6aPkLQl9hLGA22sIDw8qxSNVdX/tW1rRV08M8n7OLY6EUFluCBY kVrHO17soXDott9PLFpBCPafp3lYCz3qi03uZ1eXty9xvA/kvWGbbP2oROiAvje86+H5 +SO9Gj0p7W8O4HJX2/94LhWh5e0S7/jud1e4pat38Y2IrQDadAzTWNRiL/WCnyk6CuFJ bBmQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="r/EcXkfM"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7caf752b2besi286477685a.175.2025.05.07.14.13.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 May 2025 14:13:54 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="r/EcXkfM"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uCm4q-0006BG-VE; Wed, 07 May 2025 17:13:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uCm4m-00069Y-D4 for qemu-devel@nongnu.org; Wed, 07 May 2025 17:13:12 -0400 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uCm4k-0006D0-LS for qemu-devel@nongnu.org; Wed, 07 May 2025 17:13:12 -0400 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-7376dd56f8fso472405b3a.2 for ; Wed, 07 May 2025 14:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746652389; x=1747257189; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jk4EjQefaC29HViyknRVvmNGslUguEBFOQzXT/8c2wA=; b=r/EcXkfMF1rkZMY1ZZ7gs4V6kl1tpwyBXJTLoUA9avUOZWKZ90u4VUuAo99MhZD6+0 580Ia8WYeh2GGUiHEf2Y31KuXC93BdFetPfWewkFuhkjo1i1WhDNLdtaUjDpyUtKpUuM s+eliB2N3CcvyAFzJKJPSuwBMq1wgjf/cZXJmWhICXbrRvJ0y4hutCEs4aDtRfrOxUNW gQrTIGZUcnDdn+B8Qevgaw5Fnp496aOlQtUOE2g7m19SPx2BfFypdAtz3u/runHdBwcg P4900HKPkVmgANDXBx2LlHgqVEAkpnfC+V4F9OzN/if4SHxGq6NBuMAMe+D4BJR0+fmA Vsfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746652389; x=1747257189; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jk4EjQefaC29HViyknRVvmNGslUguEBFOQzXT/8c2wA=; b=rqay7jBVwmdM9ni5IPRAI19jAsFmq7cI8dYDdIwuaprT3LDN6T0HQc0wM3/FkvPa35 EWHP3Hvi7LlT0aLt8S8hzsDaf5qUuFsdsagZ31vefyOj+sEUGmF+DMKjxhcDtmEM8VgZ SkGvidFJLP2UXEggz1gtBo4DdrGg3zw9vgXWp7gfUI9lx2UoCOwf8+Vlh/p0WPTSqGb+ WgseZ86itg4Cxbrnnn5B6ahSso7F+jh0oHI/IjHLwbeF+vq0PfzkuM/tnfNcvDjXkNHb 5bQix/meCs5RwxmAIHIlrZ4GcbMYIeIuP/xvXxPc9aZkyxc37KGCoU20oyBeOmgC0Vxq /M0A== X-Gm-Message-State: AOJu0YyrxgDNYx8USmcjD5WBsd+M8furCc1omDFdWsxpE16hg3dQmw3A LxSwvQk9N316+8PD/rlnlZtIt9HFf86qA0dv+HmLGK30BnECj2NtLgCha+K3ZF6dR3U/N1wF15Z q X-Gm-Gg: ASbGnctwzzX/IjmESkWCPs2Jsa+dPmWZ9yaIvdRO61LqxUiSfpTZnjHP07KvNfgQV1n XglqPkHmH4iOVtFm1BeoWHOH52utdfljXuJ1Nv2JwZzTHemEXNHOEVwsCkubwXhz/VrxMF3gg6Z A67rIFKCTYsQwa/G9rh34q+/FDer0Iho0Jua2frOMHEUetlW+WA7cWRUJxW2XuG9LWtOdMRITbx icUeAY6LCoczLqqKiAp8qsJFFRxwGLy2S9kWiDw/U2eLqAYFOi+AGbtgCQVFllyO3U5XoBd4YN+ riUfpAxd3pBXJfI/WcWqBgBNm3jkhgLPogTx4N7f/R6hPZ8JFl/I/WWNOX0t0wazXqIjidBoD3k = X-Received: by 2002:a05:6a00:2a09:b0:73e:30dc:bb9b with SMTP id d2e1a72fcca58-7409cedc8b4mr6570611b3a.2.1746652388741; Wed, 07 May 2025 14:13:08 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7405902154dsm12255251b3a.90.2025.05.07.14.13.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 May 2025 14:13:08 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: laurent@vivier.eu, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v5 08/24] target/m68k: Use g_assert_not_reached in gen_lea_mode and gen_ea_mode Date: Wed, 7 May 2025 14:12:43 -0700 Message-ID: <20250507211300.9735-9-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250507211300.9735-1-richard.henderson@linaro.org> References: <20250507211300.9735-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The mode argument is extracted from 3 bits, and all cases are covered. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/m68k/translate.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index b9633e06da..f87eff3b10 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -768,8 +768,7 @@ static TCGv gen_lea_mode(CPUM68KState *env, DisasContext *s, tcg_gen_movi_i32(tmp, offset); return tmp; } - /* Should never happen. */ - return NULL_QREG; + g_assert_not_reached(); } static TCGv gen_lea(CPUM68KState *env, DisasContext *s, uint16_t insn, @@ -893,8 +892,7 @@ static TCGv gen_ea_mode(CPUM68KState *env, DisasContext *s, int mode, int reg0, return NULL_QREG; } } - /* Should never happen. */ - return NULL_QREG; + g_assert_not_reached(); } static TCGv_ptr gen_fp_ptr(int freg)