From patchwork Sun May 11 20:35:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 889175 Delivered-To: patch@linaro.org Received: by 2002:adf:fd8a:0:b0:3a1:f579:ae88 with SMTP id d10csp1334394wrr; Sun, 11 May 2025 13:38:15 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCX2SZQ6S6vKzd2D/XeePcoKzfaI0xPaCYJoNiBJTR/YyR4jptwRpBe9TYY69Su/V8pDMfvsgQ==@linaro.org X-Google-Smtp-Source: AGHT+IEDrrxGaWGdmo4i3X/P4/T5VQ9W37tyu3qO55keFHP0RsTGYNdUUuq+7RI5qFqqUciCT2t6 X-Received: by 2002:a05:622a:2cf:b0:477:6ee2:18cd with SMTP id d75a77b69052e-49452714aa7mr158206521cf.5.1746995894976; Sun, 11 May 2025 13:38:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1746995894; cv=none; d=google.com; s=arc-20240605; b=hNrqM9OUg0T3HyAIZ3PH3/SqJMgM6uyUKcFdn2VtCJu+EcQi9h8BZ6cqUdvzSv7cbu hugk25nd5eGY2YV7oh8m0ck7uRxE/AJTdS/NGBqLPTW/3+RmTLdmB4zsKgDcet4cnsYg oBSjxduV8GlKukiQfp7SR0Fj9MgcXgyEFOypueXlurfqTMHkggtO2iYQDOgWAzQ/Vbf1 Vtk3OYVb15Dnt+yuAq7FFr0BDXnYyXDbaTzLRUUQAFpEeezgJQnqNOkqfHWUIXqU4rCX Sc6aSMT/BvsAzJfeFx/xSUAql5hApTtOgIZLaFvYlvXw7wdqr2lQWClapGjwAMQsn8cv wRtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+UxEDBljyfqsOJ/6sF4OYF0K5MA05WdNFxTdb/zwknQ=; fh=821NA7tsXWF/ZNUQota793p9nRmBJe9C3PtgJkcpHns=; b=G/YXmo/64r9AJ3sbeJkmax3SS8QAHVF5gUF8xEoO7suBjXdTKN5SphS+gp3BYYGTAr Aph37yFcDsRDYrp08NBO2KXoTOcOmCFCRiNyjId/dprlWZ/bS5vbU4Lkmc/rIksZKva9 la4IHN/R9hgt4ImG+4Gs+HlBqvUkc8uDHCBlhe8vlJ6OqC04b7bW1fz4ht/izqEaIP21 UfC8DJoF20X+RMRCKTd+Lpoy56vQZypL5jUrmZN/1CD8K/e9wR70/7lSKGYvYL3UJC2n EjFjn2dTlQy7Pu6xFdKhybaF52jXfdy4MvhiDQzywvwkTKL/cAW1wddl6ODefGbfNdxh mGpA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hqr8ohCm; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-4945247f09esi74066141cf.156.2025.05.11.13.38.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 May 2025 13:38:14 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hqr8ohCm; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uEDP2-0003A3-Ab; Sun, 11 May 2025 16:36:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEDOw-0002eb-4W for qemu-devel@nongnu.org; Sun, 11 May 2025 16:35:58 -0400 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uEDOu-0006Kz-Gi for qemu-devel@nongnu.org; Sun, 11 May 2025 16:35:57 -0400 Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-30a93117e1bso5100499a91.1 for ; Sun, 11 May 2025 13:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746995755; x=1747600555; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+UxEDBljyfqsOJ/6sF4OYF0K5MA05WdNFxTdb/zwknQ=; b=hqr8ohCm+cQIV3g+wUlHqT/xM+yjsf9PNFd8OVltyjOfdjdkdSUXVQsEIFWMRGIdiY EBM7Et2LAPz2i5D2DXK6Y03eNyBlPlEei9+zzTCHLnaF9mrIm2o3w2HlwO2jlbnKI/gy eaZobzoKg8qo7+UUF9njY2dSHrjXiHVBcEpMHS/49+kYcD10ncFmWDPqDcWpVzLqE5QJ 3g6mT/N1GldX37ufSLE4Si/pGfeEluLyVBmkwNq4e6s7oAFNGGUu5o5ZsxVepZe6Ke0h AS6QTzbt35Tdo4kJLjdIiVZtG5fik1ehMPrTYoRTrMSq/ApwIXlwH+B+eTUB+UpDcL3G yRHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746995755; x=1747600555; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+UxEDBljyfqsOJ/6sF4OYF0K5MA05WdNFxTdb/zwknQ=; b=pqT7q+KSEtm37u+BkGlPjni10mIGrjTJ2HQLmbSJAHNvtd2nfx3+Y1fyAC7cFdqaUj K/tMCr2voOnI3VBpELdqbRXgWUQHFFNqLIO3PGh8LQZJi2wuDqV7oJVXZHkkj/Sc/n24 n+6oP4unRMuwl8qgv9ygiI7+9EbJOlbQxnNv9vOukIIotAZMZyKo2DfW7MM8bAblqSj8 taQl1rvgcZlGe5MQojl3/LMDLIWPTf0w+GJALWnQKvbM1OEgaW7/AGpjUhQ3pd4OlNoG 59Ha4AbSNYqTCAqNgsCaOH5/fFtVFmoUJ7cIdCH9nhzESXQrsapD2jjWkvqF80NLzPRD K52A== X-Gm-Message-State: AOJu0Yy0YFqnyCy3QN2VCgWTveaHEyQ2Hua6/+HezeN1u8oxMJt7Rz7v TAbgVwZzEC6GvXpkkDo7X+3/vsGiCUoptDwqFbg6uTGky7srHE8vEOzNe91hucKC5Yq+xcFhUvz + X-Gm-Gg: ASbGnctSDnGrZtc6ku1yyHM+h++bIISbspv8SWRAzuPGFwstmMQO45bNFo/e+/UOWlR UYB5QKkkICqjvPl87ZvKYIqADesxfre7BmWgCvzEOVXbpC41yOVFiEd5RV4uUEwsK+zqqygcxEU 0Q8ZyZvYQeiY/iAhEMSbcMAvEV9XsMQHd3FKZDqyZEXjbTsidwQNFLZUz+KYSBg+PqRX8hmiEhH M6uD5vZASvGldVwhOra/B+dYSzxCVYoLyOoLa6xxAl7B5xpS1Zcg3QazL7mw/wyR0Mrle2F5h7E HApWc1pw0fE5DAU00krb2CMVInJJyN+UKN2ayvKRmwZ5xw/wi+ncNNOaiBmhHw+Hb1McdmpUG9S V2SXj3U0uaw== X-Received: by 2002:a17:902:ced0:b0:223:90ec:80f0 with SMTP id d9443c01a7336-22fc8b339a8mr183093355ad.22.1746995754861; Sun, 11 May 2025 13:35:54 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22fc7544d86sm49955095ad.47.2025.05.11.13.35.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 May 2025 13:35:54 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: laurent@vivier.eu, schwab@linux-m68k.org Subject: [PATCH v6 09/24] target/m68k: Use OS_UNSIZED in LEA, PEA, JMP Date: Sun, 11 May 2025 13:35:31 -0700 Message-ID: <20250511203546.139788-10-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250511203546.139788-1-richard.henderson@linaro.org> References: <20250511203546.139788-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org For LEA and PEA, while the manual says "size = (long)", it also says that the pre-decrement and post-increment addressing modes are illegal. For JMP, the manual says "unsized". OS_UNSIZED is the way to signal gen_lea_mode to reject those addressing modes. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- target/m68k/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index f87eff3b10..b6d46c3bdb 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -2561,7 +2561,7 @@ DISAS_INSN(lea) TCGv tmp; reg = AREG(insn, 9); - tmp = gen_lea(env, s, insn, OS_LONG); + tmp = gen_lea(env, s, insn, OS_UNSIZED); if (IS_NULL_QREG(tmp)) { gen_addr_fault(s); return; @@ -2658,7 +2658,7 @@ DISAS_INSN(pea) { TCGv tmp; - tmp = gen_lea(env, s, insn, OS_LONG); + tmp = gen_lea(env, s, insn, OS_UNSIZED); if (IS_NULL_QREG(tmp)) { gen_addr_fault(s); return; @@ -2909,7 +2909,7 @@ DISAS_INSN(jump) * Load the target address first to ensure correct exception * behavior. */ - tmp = gen_lea(env, s, insn, OS_LONG); + tmp = gen_lea(env, s, insn, OS_UNSIZED); if (IS_NULL_QREG(tmp)) { gen_addr_fault(s); return;