From patchwork Mon May 12 18:05:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 889408 Delivered-To: patch@linaro.org Received: by 2002:adf:fd8a:0:b0:3a1:f579:ae88 with SMTP id d10csp1746656wrr; Mon, 12 May 2025 11:24:12 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWVoIvNaVg68jPwZZ2HhjLtyNNq1dnkNhJGg5Na2oSsGYOXXOaM5FyKe74cK1Lu6j9tTi7GyQ==@linaro.org X-Google-Smtp-Source: AGHT+IHANu4OIL2+b9r1nJDYJBm8iexHG5RN20+mQpY2+dhVQ9p9LNE3v9vZEb8InhLqYzIiqgri X-Received: by 2002:a05:620a:2552:b0:7c7:a45d:3a5 with SMTP id af79cd13be357-7cd01103d10mr2145194385a.14.1747074252168; Mon, 12 May 2025 11:24:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1747074252; cv=none; d=google.com; s=arc-20240605; b=Zeu2gNzw3TW21udaulDU+8swTwQvjzmQKtyVVM6rM9tGHlWtJ5VWb3H7vAuaIC0sag ysxFBQgvGnvnNHekZ1SAUe/t+eSGjCDxsQr/aBIGYdi0CDpPv0vOJK/nR1rFC49YchY1 XLjhkei+llblXGIVOEdJhBVr00jNMmguKLuZh49u84f64DKep/iGfL9MtihF9mK1UnGK cgw0unuMMESyTgWlCI5trGIROW+BYBiNk7EiZD6ycNYtlJMPE5jfsEqDY3lN8e1tffQM thE8oCzb18et++21C9iywGIDZ0tv2sb//vgm5nVYoaY6DvChq3+YyqEZdet0hAJVdeyp +V9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZWI42H1mGpC+qtJnGTlft49SFGxWloHLdh6QbAbdhzc=; fh=PlN3fUhDtems6Bb7y59zYD8EwBcqcc7pnzqldojq+us=; b=UhnDd+5EaHpL3jQneb4nk4Vh//s0Yk7dJh8oje61Amtr06cdaBpByfYXZEEFmKYfS8 gr4nVJZHQX3cgwJyKcSgPHYE2231/XtztbcvReQhJ8MEPusGKW3T0ROmT4x2ffepX2Bj 1fM8TAxls+evEHXPCfsgp2Rj11hjkHvLhXA4EX4nObXRCBmNCRwBdKZSx+nQ4aNa/ZR1 ONWNxk9X5c/R8eIoVoqa489kOJlndgjzZP+ymESvUyvyM2yczEuRrDRLpY8cVORibHse JiD1z1RfUYFZIRfj7wTKzicMnAeD74zQBnUMaSD086TkmAwDPL97/HCSCXBAsjU3RQbw L4Yw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cNLSHBU8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7cd00fd4393si933875185a.238.2025.05.12.11.24.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 May 2025 11:24:12 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cNLSHBU8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uEXcM-0003a5-07; Mon, 12 May 2025 14:11:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uEXaH-0001fB-VH for qemu-devel@nongnu.org; Mon, 12 May 2025 14:09:02 -0400 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uEXaF-0000Tu-81 for qemu-devel@nongnu.org; Mon, 12 May 2025 14:09:01 -0400 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-7426c44e014so1245027b3a.3 for ; Mon, 12 May 2025 11:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747073337; x=1747678137; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZWI42H1mGpC+qtJnGTlft49SFGxWloHLdh6QbAbdhzc=; b=cNLSHBU8ArKVyTy8heEkxobhItu2aMFPAlD/UrEOwwM2+Ic/dnkFo5r2ngdan0zbC6 zrNo8+lF7L6bG3vVHCwm38OimB5AdtQzIqvfkHd3pL8BqD3wdd3WDAPEoyqoyuhC6BmH DYyncFcvwxJAUWU45w37ICHOdTo6cA+KZBGp7pR+uf6eh20qymokn54venz3JfCVzj/o 8SIETJmbxyVrTcytdB0o+wVW4IZfaH3YnP5mqnxEIQmQG4Xi4FT56gBL7gDlsL7yh9gA EVklVjT8x13HWfiI3WSX+CAUNDKrRmmR5+D7c8Py9m4ZE+rYFt6YlBpsg4iI/ixBuMpz uJBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747073337; x=1747678137; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZWI42H1mGpC+qtJnGTlft49SFGxWloHLdh6QbAbdhzc=; b=tR0fInw5rbrI+iWGJ2iqxzU+AaXDqq9yc3eTAXZuTF4FL7AIkIG4bDvBEDitrY3I0d uRb2NGbkWRmNbgpzoUb2mPdumkAp6PIugHK4lI4iIPSTSk4fbLCcnGWDR7LVr223zjo+ VTyv1hewSTHmAae+An2bszfExfYTuJNhZLvjgW8FCAXz/Wvn6ROZE9Smzw0uHb75f11R rCQAcuMClqUg2oReOsMp+W1iEg4mUsbvfUZsr1SmXMQZiRf4Vbrqz7ZNGvrBzrgZ63cv Zk34FqrNTaXgfqhLHCXlw83jJ5Rswzh8YA5YjKoNGNzjwU3o7B2wxoGBpA/QdeDmkzvi xqPw== X-Gm-Message-State: AOJu0YyaGvpqTJNgU2sgXBP7u5/I9IF4y5sRFVdrjvgSsdVdU+TsxwQL TMVWMQqD7HB4E9x3JIRI0F7QMXt/TsaFu6aWQutPVt2HW9cDwq+Lm/ISjhbX7Qe5uMYzabRSPGn y X-Gm-Gg: ASbGncvYc18VtqV66wMjOROaJBjE2H2qhnW9xZjEI+oWOU7hdTRv7tQSKn5QlVAHw+I RoFzT3v+7XUJJioh57C/BMHA5Aa8e62aZeyRlztMKFVcVqjrlSmNCn/XOrHNY19bWlhZAphe+TZ qjkpqosap59d2+9ugeUTKWLpmEhX+9MPthtRMwJ0udo0JASaim+oPHFKJUfovsEgck4QlsgU+JH v5mMmRkSeF5Zna3vEWtPZIEJ6XQwMAtvR25WOgsQnnfrgVTR8Nz2Owz6bHjky0WAsGroD/dfZOj WqlQ0GrdqsbNVqt/iRE4Vbb9rlIV5Xojiiz0E//pG4XLmDnNKV8= X-Received: by 2002:a05:6a00:23c8:b0:737:9b:582a with SMTP id d2e1a72fcca58-7423c087158mr22392781b3a.24.1747073337534; Mon, 12 May 2025 11:08:57 -0700 (PDT) Received: from pc.. ([38.41.223.211]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74237705499sm6438580b3a.33.2025.05.12.11.08.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 May 2025 11:08:57 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , kvm@vger.kernel.org, alex.bennee@linaro.org, anjo@rev.ng, qemu-arm@nongnu.org, Peter Maydell , Paolo Bonzini , Richard Henderson , Pierrick Bouvier Subject: [PATCH v8 46/48] target/arm/tcg/tlb-insns: compile file once (system) Date: Mon, 12 May 2025 11:05:00 -0700 Message-ID: <20250512180502.2395029-47-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250512180502.2395029-1-pierrick.bouvier@linaro.org> References: <20250512180502.2395029-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pf1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org aarch64 specific code is guarded by cpu_isar_feature(aa64*), so it's safe to expose it. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- target/arm/tcg/tlb-insns.c | 7 ------- target/arm/tcg/meson.build | 2 +- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/target/arm/tcg/tlb-insns.c b/target/arm/tcg/tlb-insns.c index 0407ad5542d..95c26c6d463 100644 --- a/target/arm/tcg/tlb-insns.c +++ b/target/arm/tcg/tlb-insns.c @@ -35,7 +35,6 @@ static CPAccessResult access_ttlbis(CPUARMState *env, const ARMCPRegInfo *ri, return CP_ACCESS_OK; } -#ifdef TARGET_AARCH64 /* Check for traps from EL1 due to HCR_EL2.TTLB or TTLBOS. */ static CPAccessResult access_ttlbos(CPUARMState *env, const ARMCPRegInfo *ri, bool isread) @@ -46,7 +45,6 @@ static CPAccessResult access_ttlbos(CPUARMState *env, const ARMCPRegInfo *ri, } return CP_ACCESS_OK; } -#endif /* IS variants of TLB operations must affect all cores */ static void tlbiall_is_write(CPUARMState *env, const ARMCPRegInfo *ri, @@ -802,7 +800,6 @@ static const ARMCPRegInfo tlbi_el3_cp_reginfo[] = { .writefn = tlbi_aa64_vae3_write }, }; -#ifdef TARGET_AARCH64 typedef struct { uint64_t base; uint64_t length; @@ -1270,8 +1267,6 @@ static const ARMCPRegInfo tlbi_rme_reginfo[] = { .writefn = tlbi_aa64_paallos_write }, }; -#endif - void define_tlb_insn_regs(ARMCPU *cpu) { CPUARMState *env = &cpu->env; @@ -1299,7 +1294,6 @@ void define_tlb_insn_regs(ARMCPU *cpu) if (arm_feature(env, ARM_FEATURE_EL3)) { define_arm_cp_regs(cpu, tlbi_el3_cp_reginfo); } -#ifdef TARGET_AARCH64 if (cpu_isar_feature(aa64_tlbirange, cpu)) { define_arm_cp_regs(cpu, tlbirange_reginfo); } @@ -1309,5 +1303,4 @@ void define_tlb_insn_regs(ARMCPU *cpu) if (cpu_isar_feature(aa64_rme, cpu)) { define_arm_cp_regs(cpu, tlbi_rme_reginfo); } -#endif } diff --git a/target/arm/tcg/meson.build b/target/arm/tcg/meson.build index 49c8f4390a1..5d326585401 100644 --- a/target/arm/tcg/meson.build +++ b/target/arm/tcg/meson.build @@ -34,7 +34,6 @@ arm_ss.add(files( 'mve_helper.c', 'op_helper.c', 'vec_helper.c', - 'tlb-insns.c', 'arith_helper.c', 'vfp_helper.c', )) @@ -68,6 +67,7 @@ arm_common_system_ss.add(files( 'iwmmxt_helper.c', 'neon_helper.c', 'tlb_helper.c', + 'tlb-insns.c', )) arm_user_ss.add(files( 'hflags.c',