From patchwork Fri Jun 20 17:12:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 898351 Delivered-To: patch@linaro.org Received: by 2002:a5d:5f54:0:b0:3a4:ee3f:8f15 with SMTP id cm20csp1454529wrb; Fri, 20 Jun 2025 10:20:46 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWYxlYdtI0lGT6StJt6kSP+74TA1WREaW9DABbwNThgN/VUMYwPUxZg57O0ZjB82knl18zsWw==@linaro.org X-Google-Smtp-Source: AGHT+IE8jdMPuwZQqNi28xYsEcELRkag45T+M/QxCjWMzjI5FHQGcKEdcMhT7S1OUwvBI8VN0HAB X-Received: by 2002:a05:6102:b14:b0:4e5:a0a3:86da with SMTP id ada2fe7eead31-4e9c2945b8emr2655091137.12.1750440046068; Fri, 20 Jun 2025 10:20:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1750440046; cv=none; d=google.com; s=arc-20240605; b=g1kYDw1YcZnQ7D6SS4NDSVlrVxHHNqpzpqics/2KNY/G7ptzVEa/t3TYXNPVZRk1SS TlwOs+dwlwOq8AYcA9+wjsBtnk0S4sLaLrNToc2RHFQGfB4c71CDTBR7lSO5q15IKepr rxfCDETPHIchypsju2TOeDIpg4m8NYP+HCpvQgA/lZxCPirGOXTE2r8cazWuE2TAJet6 7jRtf9Jwlu/9sFAA4zHRCSH4W09k1ECgn3A0B/EhA8J65mSXnsuBAlK8o9EVcdYM4ndz 5+MEPOCk0QtkmtolpuxNUCDlhPZyhvl6eUntoVRQbiWAVyqEoxDnXwbPRLOHPU4oUa1j EnTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ja/mWaJxTqT9HY8GpbCcKbyHjlgZdtvBuMFDUY0S1Jw=; fh=8f2AL0Su0K9UlZksY2EEcc9O+An+AQ/T/SEdbs2pdSA=; b=NiW/47EVVEPEf4MI4CoSAx5hAS0QvCT1PGT66ACezdfYYcikse1TJ5uimDm1xDHFSw qPJS5cjz8ZQ0mzw2WoYDv45igVboxkQcgVQ36uQO2LMgzCNruMZLk2gSBSjjlW/k4hiB +u0gdg3YQYqTU2vuE50+i8BGdphncsZLjOkaL8ueLeIESRdXDNPsHG2P0qFiPwzxpOAr 4KWrXoLTDH2vg8ESeVUmGhEo5/C9v3Wa2gtEwGxvytKIbbGHAe4lTpU/SUugpzaLtb7I g8QOYWUIjiX2sLxCjDUb6CSAwSH/8nRG5aU6UV9QgujndWWW5Ci8873kW1x4l4ytO08o FVbw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bYIttQiv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ada2fe7eead31-4e9c3208b05si459895137.377.2025.06.20.10.20.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Jun 2025 10:20:46 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bYIttQiv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSfJW-0000PZ-JY; Fri, 20 Jun 2025 13:14:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSfJR-0000Oo-Ll for qemu-devel@nongnu.org; Fri, 20 Jun 2025 13:14:02 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSfJQ-00049y-5e for qemu-devel@nongnu.org; Fri, 20 Jun 2025 13:14:01 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-450cf0120cdso16999745e9.2 for ; Fri, 20 Jun 2025 10:13:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750439638; x=1751044438; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ja/mWaJxTqT9HY8GpbCcKbyHjlgZdtvBuMFDUY0S1Jw=; b=bYIttQivQOPdTpWCVW1qfEdkOUJ/S+WPzt3EKrrH05xCEasT5UvyYeiWlwi4eh8C5J EY0iGqnPDSqaqWpxpAje0v+CE/0jsZTaR67tg0j9qPhAsCDede5WDL8I54aY0lCk1Jxx Ylv1eQruzboh+r48OBZmPeqdOXspLSRg0cj76HUPdC5qljL0PsUCFLPRURE/DSDsoEsr yUOywoWneqZyu+0Jq2huPKnNilGdgj5MqQKOrTGe5jhO5Vykd/f7ybQXLF6Q7bXgx3ya IpezS/t1HXsQkQcFYvuSad7KohCM7E0dYleGiU1GFZcsq5efEN8P+p7HG2Lbn7NpXoNL ugVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750439638; x=1751044438; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ja/mWaJxTqT9HY8GpbCcKbyHjlgZdtvBuMFDUY0S1Jw=; b=pEh0YIFC3xX6c2lzYjyP8joyQgqhqXFaJnNy8hsdj3uuHC25GE/tt6Nj/+YGDfSYaq ZyAEtOdEcVR7j7uimOd2Z4C3CSJ/pV82u1UB/ZZ17/LggsQh6A6a0LUBhHd2v9LMuDlQ /FsXGYLDrMxH2tMG+bA8bHQirZNAlyQhKRvxYniyzFk5T0alrWPW6f1r3tZqm/QyDZfL MwylZ2esQj8R1h7OfmOaaOiHJ06ZblNZJ3q0H+2TFbixDS/rZXYabYddpfpBjgD8uWR6 bBHjE9JOgBI6aL3mlP45ZHjd/b7z4El44v/sVAH/G/lgk8uGWFnVTVX5qrx0ZQCG15Eq +5Aw== X-Gm-Message-State: AOJu0YzePLjxb+xiDjK2AcCUTNIjqd1UN7dSaWZQg7xTE7oCZXZOLZlF et7S36AQXG00FjN3gDN89d44RqHJRbH/WBoBFU4CAvEFdyIs8q8gMclpSxchbgQGmQPH+0mp2PW +dbUcnCE= X-Gm-Gg: ASbGncs/F5MgyuZI3Gve4R0NTooy7UKOK+yrjgWxfkOXlov0aU9Si472EYnEjEXkbH4 EEy+QJUJFlO87uUdA5GFrZu4/MVYbwqvCI1DlEaYDB1CS/+uJQupbR5HJsugEqF+awdiQuCaPRw GGXj6RChHdJ1s9hgEgQ3AJ7ur5l0V9xdwvPwrWRyrnJp4/a7OOcrUwLmqfhwTUGg1qUi28CWAWT Vtyh0wYBpH0NoWgjn/EfXpbMiCWMyT0xoB1TlSgStJkhTKogjIacLdc2Av4a21nXxQt35n6k1Mt ldlqeMqmFuICKJOOXAR6irhbu66FgiHnXzx6Uww2kiN7ZAgXfFhTHwZdA5AKinddmxQsYhiuita KZL3jNy4v83Yg6FEhzRbUPByx3gyjOC2H23yu X-Received: by 2002:a05:600c:4684:b0:43c:eeee:b713 with SMTP id 5b1f17b1804b1-453659cb92fmr32553385e9.20.1750439638298; Fri, 20 Jun 2025 10:13:58 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45364703701sm31541125e9.27.2025.06.20.10.13.57 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 10:13:57 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Alexander Graf , Richard Henderson , Pierrick Bouvier , Peter Maydell , Thomas Huth , Cameron Esfahani , Julian Armistead , Paolo Bonzini , "Edgar E. Iglesias" , =?utf-8?q?Philippe_Mathieu-?= =?utf-8?q?Daud=C3=A9?= Subject: [RFC PATCH v2 03/48] system/cpus: Assert interrupt handling is done with BQL locked Date: Fri, 20 Jun 2025 19:12:56 +0200 Message-ID: <20250620171342.92678-4-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620171342.92678-1-philmd@linaro.org> References: <20250620171342.92678-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- accel/tcg/tcg-accel-ops.c | 2 -- system/cpus.c | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index da2e22a7dff..37b4b21f882 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -93,8 +93,6 @@ static void tcg_cpu_reset_hold(CPUState *cpu) /* mask must never be zero, except for A20 change call */ void tcg_handle_interrupt(CPUState *cpu, int mask) { - g_assert(bql_locked()); - cpu->interrupt_request |= mask; /* diff --git a/system/cpus.c b/system/cpus.c index d16b0dff989..a43e0e4e796 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -265,6 +265,8 @@ static void generic_handle_interrupt(CPUState *cpu, int mask) void cpu_interrupt(CPUState *cpu, int mask) { + g_assert(bql_locked()); + if (cpus_accel->handle_interrupt) { cpus_accel->handle_interrupt(cpu, mask); } else {