From patchwork Fri Jun 20 17:27:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 898382 Delivered-To: patch@linaro.org Received: by 2002:a5d:5f54:0:b0:3a4:ee3f:8f15 with SMTP id cm20csp1561082wrb; Fri, 20 Jun 2025 15:22:08 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXdQ6IhlzK2XwUS/3m2OyIg7JvGdiy9VpYhkxFRgD+hjdR7YcEzYbORSJU4yRNfE6u9rFWk2w==@linaro.org X-Google-Smtp-Source: AGHT+IGW36dEU24diot5UaRwTSzbkm+9ryeKOvZUJb6dZGj8ZB7KJgZGNMeiV/1Zk9Jg8D8y/v4R X-Received: by 2002:a05:6214:cc8:b0:6fa:c55e:873 with SMTP id 6a1803df08f44-6fd0a558275mr79854036d6.37.1750458128631; Fri, 20 Jun 2025 15:22:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1750458128; cv=none; d=google.com; s=arc-20240605; b=SvtV8oLDbVrSxHfKTdKI0Pt1ikf3UrxT5Y2kl5mhmOhGABtpSX0CyfSzu2hgkAPKHG qeIveSRHsdj0jvYVRe8dnMnVh4mkxvH1F4PfyrAuXo67zhHCgWFBNWJGyKq0AUwwaMp9 m9wX+9U9Y2qBRDo9yDxRnxrKWxEuX82oux43EEDCd1Offc488HTVmanY3ymNV7eTm5PS ZiIXlmyX9VmIEX8hmNMqE5CSjeKr9isdPWltIhBqaiKzR99HkHO5aqEmqCs/GXNv9d9E 23z9pXZ0wGLEamlVacGCM4BsUl4zT/koC5iAXqCtFzN0gM5yy7TmDAEDsPksCAHPNmnk n6HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3LOqF9IQUgckxNreMVaINjrct4R3Ylg/3ClAi13j+TI=; fh=AyzBWpdZKvTUKIe2KsNBcRb7uNXo8uS2i+VtImaSwe4=; b=OjxJ3ujZm06x3w2KTMC1Jg3gU6zFIRcmKr6phFHb5p5znGkIcdJlDjknbwNHs3ciIm sboRwnQ59CCpTxRkQw7LqA9fxKy8G2aYVpZZIalKYWJ68/vhxXE7ufQpwPt8KhQ3cMfY EKkWpJtjUj1BmxEnm/SFdirlS3BaAiHQ/IacAk7O/u7MkCWH0hjxMgtFbnrWVRC49jxb mbntZM2Zn6HbcHzb6fYllQh79GZllPyhoxgDWzWNBw4wJzQdZ06q8cHJFENQlRWkhgo4 XH6N1cjuxD6zFsw5hfW89g2ts71I1J2ywPLzw8e3t18kYVfdy+kdY4kvbckotyjZJD9w cLdg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FCWFDbOP; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7d3f99e6883si260163085a.280.2025.06.20.15.22.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Jun 2025 15:22:08 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FCWFDbOP; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSk6G-0004TZ-2v; Fri, 20 Jun 2025 18:20:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSfYU-0007BB-IB for qemu-devel@nongnu.org; Fri, 20 Jun 2025 13:29:34 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSfYS-0005x4-W9 for qemu-devel@nongnu.org; Fri, 20 Jun 2025 13:29:34 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-441ab63a415so22254415e9.3 for ; Fri, 20 Jun 2025 10:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750440571; x=1751045371; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3LOqF9IQUgckxNreMVaINjrct4R3Ylg/3ClAi13j+TI=; b=FCWFDbOPRFGXZkoaBxsHSUjUsmHOuzXD7kU3x65tHGvSAbG0wdnt9/SvLHXgCHWxyi tp9CBKi7oz0pf+E8cEmdJJTLO5Ka/iqdiwqL4nD7jtKjS33jeJ1pyWwO3i7oxzVkS4WL wz00Y6saJ839pgr2S1Fwp483aQK4UO/g9OTbuCeWyrF6jZU+y1VcMzTbvQEVCnPmwUa8 gmtS/LR3q8kpuk14av/6Ilt092ZWGLlwa4paOl8ubGfUf0LHBmtRnnZvzT0xcLhs2GRL aVPvzreb6ZBOW+GxqpQN6gjFx4xnL0QqOVT71Pw44Pp2RrBWDpwWtCnThKo5A3sJvDtd 80jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750440571; x=1751045371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3LOqF9IQUgckxNreMVaINjrct4R3Ylg/3ClAi13j+TI=; b=g65To+m00GTjER+ZNgyRb8IkNGq1/pLN9GHYtdfu7k22BGgGKsbqNFYGk79zXm+GQe H7Gb+bxg8PBH/GKHU1Og8amFfLyTFQOUQbFxA0k2kaHoSJbfsKHYlIFgWuTsLFrhE59F 7fzKSqqQPNakc/MfpZ0NOmNhjtJ6e+tCrUUKpvyDmzBVf5YXAP2zSmIHXMBX7p5ZQNPD H1Bk/NdpDsyrCwQ0XKChGMAof+QRm1eU3FHS4cqlCTMSao0SNBZeRRv+FYVFF+eX9lhj wzgRas6TK69hU+vCHEyfmQVYUfa54WPZF7WMXnr0ndhd6upbbvBXE9Ritf523D4GsgHo V9yA== X-Gm-Message-State: AOJu0YxISpl91YEmkaCdRU+MzuPuJ4D9kaNEhDvWLPcMJ/d1GLjfaR3k Lilcg4grOhGBKOjacZvkHdhvXTd56tfZKcunEE09fcOb2rhkK5/sUt3CLz7Vkk6fcTXSm2fa2Mo NtZknWP35aA== X-Gm-Gg: ASbGnct2k1nIobk7hdRTxmJyOpWcvDjCz/dBqYzN4OceMUMq5Y9Q24I87QaEcfwUwO1 rRb9t/EN/kbfUSHi8d28sOj4LrKyA78lmGz6ofhuGw/zYlNNSDmRglU/02VSRTfmc0xw0/B+Es5 y5/Fzg7/CNReTIo/yDSY5Syy+mLSNG5FJwYWouuP0fUSz9pE7Ia3a/KMzjWu8VFzGzHt+4RLGCS v3YCd6eqNRef9hT9Skzv37a8nGas8Ktxd1uQbNC0mFNDLU+SRMhR4MKsjCCmwYqFeMmKOX1aeuD 4dxkbjYjy1ON4FxxSAoM73ylMkgrR1juuXntpUo11RTVEZ4xGq6hbdsyXo8rY2x+9WxOmw/Gh7c 2O/kPrkza46RL8WGk/fp9NW7CSVJXXQkuJbhLrpbJuy4f4uSqikNsHeLB X-Received: by 2002:a05:600c:4747:b0:43d:300f:fa1d with SMTP id 5b1f17b1804b1-453659c0c2fmr40909735e9.31.1750440571163; Fri, 20 Jun 2025 10:29:31 -0700 (PDT) Received: from localhost.localdomain (101.red-95-127-63.dynamicip.rima-tde.net. [95.127.63.101]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d1187df7sm2591455f8f.66.2025.06.20.10.29.28 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 10:29:30 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Alexander Graf , =?utf-8?q?Alex_Benn=C3=A9e?= , Richard Henderson , Paolo Bonzini , Peter Maydell , Julian Armistead , Cameron Esfahani , Mark Burton , Thomas Huth , "Edgar E. Iglesias" , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-?= =?utf-8?q?Daud=C3=A9?= Subject: [RFC PATCH RESEND 12/42] accel/split: Have thread routine ready to dispatch over HW/SW Date: Fri, 20 Jun 2025 19:27:20 +0200 Message-ID: <20250620172751.94231-13-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620172751.94231-1-philmd@linaro.org> References: <20250620172751.94231-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- accel/split/split-accel-ops.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/accel/split/split-accel-ops.c b/accel/split/split-accel-ops.c index 2c7945b6331..39495fdff14 100644 --- a/accel/split/split-accel-ops.c +++ b/accel/split/split-accel-ops.c @@ -19,12 +19,18 @@ static void *split_cpu_thread_routine(void *arg) { AccelState *as = current_accel(); + SplitAccelState *sas = SPLIT_ACCEL(as); + AccelClass *hwc = ACCEL_GET_CLASS(sas->hw); + AccelClass *swc = ACCEL_GET_CLASS(sas->sw); + AccelOpsClass *hwops = hwc->ops; + AccelOpsClass *swops = swc->ops; void *sw_force_rcu; CPUState *cpu = arg; AccelCPUState *acs; int r; - /* TODO: check accel allowed */ + assert(swc->allowed); + assert(hwc->allowed); rcu_register_thread(); sw_force_rcu = mttcg_vcpu_register(cpu); @@ -35,7 +41,8 @@ static void *split_cpu_thread_routine(void *arg) cpu->thread_id = qemu_get_thread_id(); current_cpu = cpu; - /* TODO: init_vcpu_thread() */ + hwops->init_vcpu_thread(cpu); + swops->init_vcpu_thread(cpu); cpu->accel = g_renew(AccelCPUState, cpu->accel, 1); /* XXX only with current TCG */ acs = cpu->accel; acs->accel = as; @@ -49,10 +56,12 @@ static void *split_cpu_thread_routine(void *arg) cpu->exit_request = 1; do { - r = 0; - if (cpu_can_run(cpu)) { - r = 0; /* TODO: exec_vcpu_thread() */ + if (acs->use_hw) { + r = hwops->exec_vcpu_thread(cpu); + } else { + r = swops->exec_vcpu_thread(cpu); + } switch (r) { case 0: break; @@ -83,7 +92,8 @@ static void *split_cpu_thread_routine(void *arg) qemu_wait_io_event(cpu); } while (!cpu->unplug || cpu_can_run(cpu)); - /* TODO: destroy_vcpu_thread() */ + hwops->destroy_vcpu_thread(cpu); + swops->destroy_vcpu_thread(cpu); cpu_thread_signal_destroyed(cpu); bql_unlock();