diff mbox series

[RFC,RESEND,28/42] accel/split: Empty cpu_thread_is_idle()

Message ID 20250620172751.94231-29-philmd@linaro.org
State New
Headers show
Series accel/split/arm: Run EL2 using TCG and EL1/EL0 in hardware with HVF | expand

Commit Message

Philippe Mathieu-Daudé June 20, 2025, 5:27 p.m. UTC 
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 accel/split/split-accel-ops.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Richard Henderson June 22, 2025, 3:14 a.m. UTC | #1 
On 6/20/25 10:27, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   accel/split/split-accel-ops.c | 6 ------
>   1 file changed, 6 deletions(-)

Why does this not defer to the current sub-accel?

r~

> 
> diff --git a/accel/split/split-accel-ops.c b/accel/split/split-accel-ops.c
> index 034b5ebc96c..e1d91ace2fa 100644
> --- a/accel/split/split-accel-ops.c
> +++ b/accel/split/split-accel-ops.c
> @@ -166,11 +166,6 @@ static void split_kick_vcpu_thread(CPUState *cpu)
>       }
>   }
>   
> -static bool split_cpu_thread_is_idle(CPUState *cpu)
> -{
> -    g_assert_not_reached();
> -}
> -
>   static void split_synchronize_post_reset(CPUState *cpu)
>   {
>       SplitAccelState *sas = SPLIT_ACCEL(cpu->accel->accel);
> @@ -291,7 +286,6 @@ static void split_accel_ops_class_init(ObjectClass *oc, const void *data)
>       ops->cpu_reset_hold = split_cpu_reset_hold;
>       ops->cpu_thread_routine = split_cpu_thread_routine;
>       ops->kick_vcpu_thread = split_kick_vcpu_thread;
> -    ops->cpu_thread_is_idle = split_cpu_thread_is_idle;
>   
>       ops->synchronize_post_reset = split_synchronize_post_reset;
>       ops->synchronize_post_init = split_synchronize_post_init;
diff mbox series

Patch

diff --git a/accel/split/split-accel-ops.c b/accel/split/split-accel-ops.c
index 034b5ebc96c..e1d91ace2fa 100644
--- a/accel/split/split-accel-ops.c
+++ b/accel/split/split-accel-ops.c
@@ -166,11 +166,6 @@  static void split_kick_vcpu_thread(CPUState *cpu)
     }
 }
 
-static bool split_cpu_thread_is_idle(CPUState *cpu)
-{
-    g_assert_not_reached();
-}
-
 static void split_synchronize_post_reset(CPUState *cpu)
 {
     SplitAccelState *sas = SPLIT_ACCEL(cpu->accel->accel);
@@ -291,7 +286,6 @@  static void split_accel_ops_class_init(ObjectClass *oc, const void *data)
     ops->cpu_reset_hold = split_cpu_reset_hold;
     ops->cpu_thread_routine = split_cpu_thread_routine;
     ops->kick_vcpu_thread = split_kick_vcpu_thread;
-    ops->cpu_thread_is_idle = split_cpu_thread_is_idle;
 
     ops->synchronize_post_reset = split_synchronize_post_reset;
     ops->synchronize_post_init = split_synchronize_post_init;