diff mbox series

[PULL,05/14] CODING_STYLE: Mention preferred comment form

Message ID 25ac5bbec43973e9b97a454e55fd307ef9db1320.1488264243.git.mjt@msgid.tls.msk.ru
State Accepted
Commit 25ac5bbec43973e9b97a454e55fd307ef9db1320
Headers show
Series None | expand

Commit Message

Michael Tokarev Feb. 28, 2017, 6:44 a.m. UTC 
From: Peter Maydell <peter.maydell@linaro.org>


Our defacto coding style strongly prefers /* */ style comments
over the single-line // style, and checkpatch enforces this,
but we don't actually document this. Mention it in CODING_STYLE.

Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Fam Zheng <famz@redhat.com>

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

---
 CODING_STYLE | 7 +++++++
 1 file changed, 7 insertions(+)

-- 
2.1.4
diff mbox series

Patch

diff --git a/CODING_STYLE b/CODING_STYLE
index f53180b..2fa0c0b 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -116,3 +116,10 @@  if (a == 1) {
 Rationale: Yoda conditions (as in 'if (1 == a)') are awkward to read.
 Besides, good compilers already warn users when '==' is mis-typed as '=',
 even when the constant is on the right.
+
+7. Comment style
+
+We use traditional C-style /* */ comments and avoid // comments.
+
+Rationale: The // form is valid in C99, so this is purely a matter of
+consistency of style. The checkpatch script will warn you about this.