From patchwork Mon Mar 23 13:54:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Riku Voipio X-Patchwork-Id: 46195 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f69.google.com (mail-la0-f69.google.com [209.85.215.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id AFBA520D10 for ; Mon, 23 Mar 2015 13:56:55 +0000 (UTC) Received: by labgq15 with SMTP id gq15sf27389368lab.0 for ; Mon, 23 Mar 2015 06:56:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=H8064z6ScBe904jLPfPFbgMrArzhKrX/PX69Pr4PqGc=; b=KkasUjX89ca18tei/VCZX3nvZa/oGAyQF2EIraCBbLCQKfCm7SWSS76mtLIseWkDco 6RXN7nH8PZ21+pt/5pCVE3NKwujlSpoe7a8vUnR4ZLAUr+1a7Ftf/Miaee3+6K0oGqel x2uMaJthyJC7payyBKPpdEGyPX8O94GrST50xc0zMkP/eIfCctsCbXzIB/JobuD/vG4X icyshCbT3q9PGehz8vpYHeeX5+3cLFbFUWxED6lV4yNCDINgbnXRquj6uvK9ot+e8zJd BF70YUUAVrv8ypUVO/70z3ykbBJ6AcIbVzgIPlMMm9D7Csu3/P14nh44ntAfSDetXxC7 5Www== X-Gm-Message-State: ALoCoQnpSrM+hz3CWixC400i3e6hswBS5rMi7YoEZT712XZ0Bzr0Dbht3Nv/JApF6xznK21IKwrb X-Received: by 10.152.3.70 with SMTP id a6mr4763364laa.0.1427119014647; Mon, 23 Mar 2015 06:56:54 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.224.165 with SMTP id rd5ls41790lac.77.gmail; Mon, 23 Mar 2015 06:56:54 -0700 (PDT) X-Received: by 10.152.87.144 with SMTP id ay16mr28836153lab.10.1427119014364; Mon, 23 Mar 2015 06:56:54 -0700 (PDT) Received: from mail-lb0-f180.google.com (mail-lb0-f180.google.com. [209.85.217.180]) by mx.google.com with ESMTPS id h2si730163lab.15.2015.03.23.06.56.54 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Mar 2015 06:56:54 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.180 as permitted sender) client-ip=209.85.217.180; Received: by lbbsy1 with SMTP id sy1so118910935lbb.1 for ; Mon, 23 Mar 2015 06:56:54 -0700 (PDT) X-Received: by 10.112.130.195 with SMTP id og3mr82612391lbb.112.1427119014035; Mon, 23 Mar 2015 06:56:54 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.57.201 with SMTP id k9csp842877lbq; Mon, 23 Mar 2015 06:56:53 -0700 (PDT) X-Received: by 10.55.42.137 with SMTP id q9mr175095912qkq.14.1427119012868; Mon, 23 Mar 2015 06:56:52 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id d4si785657qcs.19.2015.03.23.06.56.52 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 23 Mar 2015 06:56:52 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:56086 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya2qa-00058V-3E for patch@linaro.org; Mon, 23 Mar 2015 09:56:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya2pT-0004DW-9D for qemu-devel@nongnu.org; Mon, 23 Mar 2015 09:55:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ya2pO-00011r-7z for qemu-devel@nongnu.org; Mon, 23 Mar 2015 09:55:43 -0400 Received: from mail-lb0-f169.google.com ([209.85.217.169]:33459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya2pO-00011a-28 for qemu-devel@nongnu.org; Mon, 23 Mar 2015 09:55:38 -0400 Received: by lbcmq2 with SMTP id mq2so8650263lbc.0 for ; Mon, 23 Mar 2015 06:55:37 -0700 (PDT) X-Received: by 10.152.179.139 with SMTP id dg11mr78308542lac.28.1427118937209; Mon, 23 Mar 2015 06:55:37 -0700 (PDT) Received: from localhost.localdomain (91-157-196-38.elisa-laajakaista.fi. [91.157.196.38]) by mx.google.com with ESMTPSA id j6sm204311laf.5.2015.03.23.06.55.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 23 Mar 2015 06:55:36 -0700 (PDT) From: riku.voipio@linaro.org To: qemu-devel@nongnu.org Date: Mon, 23 Mar 2015 15:54:52 +0200 Message-Id: <92bed463d12ab9e1e34cdd44673ab9c4315ad1d2.1427118794.git.riku.voipio@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.217.169 Cc: Chen Gang S Subject: [Qemu-devel] [PULL 1/3] linux-user/main.c: Remove redundant end_exclusive() in arm_kernel_cmpxchg64_helper() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: riku.voipio@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.180 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Chen Gang S start/end_exclusive() need be pairs, except the start_exclusive() in stop_all_tasks() which is only used by force_sig(), which will be abort. So at present, start_exclusive() in stop_all_task() need not be paired. queue_signal() may call force_sig(), or return after kill pid (or queue signal). If could return from queue_signal(), stop_all_task() would not be called in time, the next end_exclusive() would be issue. So in arm_kernel_cmpxchg64_helper() for ARM, need remove end_exclusive() after queue_signal(). The related commit: "97cc756 linux-user: Implement new ARM 64 bit cmpxchg kernel helper". Signed-off-by: Chen Gang Signed-off-by: Riku Voipio --- linux-user/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 6e446de..31eb60f 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -525,8 +525,6 @@ segv: info.si_code = TARGET_SEGV_MAPERR; info._sifields._sigfault._addr = env->exception.vaddress; queue_signal(env, info.si_signo, &info); - - end_exclusive(); } /* Handle a jump to the kernel code page. */