From patchwork Thu Jul 8 18:32:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 471291 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp549125jao; Thu, 8 Jul 2021 11:38:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyv5qmVkyS4FH/mjfLCjzhrMVxee+qMUywr/cM+LMtCDU0GeI6U9Gk9Uz9R4wonAVMA7jDi X-Received: by 2002:ac5:c24e:: with SMTP id n14mr26691521vkk.23.1625769532131; Thu, 08 Jul 2021 11:38:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625769532; cv=none; d=google.com; s=arc-20160816; b=LzkBFQHXFw3NEaZK6EeVsfRmT3NqoWIIftJ9iSNzbmRtYyHTOMVHEFyfCai1pl4T2A MdzaiOajRV+1hFxjpCLwUMhfsZHLo20z6q9/rP8SdER9PR35GVt+TwrnbKAnFy9NeQXZ +CYsCamn5SJaZp/TqAgTELDWuvBqBbPY3jpR5twdVVLq2yaBYvvJChFh/lwtm4LogWr4 WQ3oI7qP+U3/i0Gn2oKM8p5xN3K+k4DG1hUJ2gb0tGmh9Dgk7oYoGdOROOOfXNit8a5y GWtGUwpeG95o8RK/Lpbe5+g3CcIuiWWJt8Rg40QUcWq33zXOo8E7ps0YrQYJmP09xQ89 lRtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=zO/h5X9UPnGQiOCuPnMzSAfAIq7BXyvkfwQU7S8Y810=; b=kPbVSb5qi+qLiZrbPwfv8bdFHmUL7VnGO9EUfnd2CMpzAvtwLl8lUBqZ9SVlbnK3Ej /YAeeofWRwZZCbmWxRo5ZfhIqF1TNzwBDp7yxT1mTzcZRTx95r7GTX6141I+P8zDLtfx DTJFw4Bjh4jz96lHukKyUNktFd4rA5eiQVUNk6XYCIrUVINEXnacfGBApWFxfTQlxfnG uOljStbIGCeuZxPuC57rcIE1ZpZnvEWSFLHdIkrXrDkxwywZ/JCDiK8nV206CumLkUYk +604tvGloQlbXMRPksE0P0MbztuY9UQayIRyQtJIcqkEguDFbKYubZpZpztJd0Lav1yO wJRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Lp12P3pP; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u4si3823682vse.199.2021.07.08.11.38.52 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Jul 2021 11:38:52 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Lp12P3pP; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:54278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1YvD-0005SB-Ib for patch@linaro.org; Thu, 08 Jul 2021 14:38:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1YqE-0006OY-GG for qemu-devel@nongnu.org; Thu, 08 Jul 2021 14:33:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47673) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1YqC-00026O-J4 for qemu-devel@nongnu.org; Thu, 08 Jul 2021 14:33:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625769219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zO/h5X9UPnGQiOCuPnMzSAfAIq7BXyvkfwQU7S8Y810=; b=Lp12P3pPm10fvytRcDZm5gANTDXrJSZ3bLM1caTfAY/4/4GXYK6moNuN8GW3nCFI7DjgC+ Zq/yc4sxPjZ6r/4EgJvKZ6EnSOKbfnnsN8UQXdlrww6GSmR3eFVsQeXA27fvx+sMc95ZkP pQn63I9gSEAvhMRaLF20kDj4j3sho+c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-479-t580vm8LOEyF99v7EUmgWw-1; Thu, 08 Jul 2021 14:33:38 -0400 X-MC-Unique: t580vm8LOEyF99v7EUmgWw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7D3D81926DCC for ; Thu, 8 Jul 2021 18:33:17 +0000 (UTC) Received: from worklaptop.home (ovpn-115-15.rdu2.redhat.com [10.10.115.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id DAE6569320; Thu, 8 Jul 2021 18:33:16 +0000 (UTC) From: Cole Robinson To: qemu-devel@nongnu.org Subject: [PATCH 4/4] contrib: qemu-guest-agent.service: Use IgnoreOnIsolate=True Date: Thu, 8 Jul 2021 14:32:02 -0400 Message-Id: In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crobinso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=crobinso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.45, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cole Robinson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Changing runlevel (telinit 3) will stop qemu-guest-agent.service, and it won't ever restart, because it's intended to only start when the specified virtio device is added. Use IgnoreOnIsolate=True plus Install WantedBy= to keep the agent running regardless of runlevel, which is the expected behavior IMO. This has been in RHEL since 7.2ish timeframe: https://bugzilla.redhat.com/show_bug.cgi?id=1165176 Signed-off-by: Cole Robinson --- contrib/systemd/qemu-guest-agent.service | 2 ++ 1 file changed, 2 insertions(+) -- 2.31.1 diff --git a/contrib/systemd/qemu-guest-agent.service b/contrib/systemd/qemu-guest-agent.service index 505636a5ba..bb419fe55f 100644 --- a/contrib/systemd/qemu-guest-agent.service +++ b/contrib/systemd/qemu-guest-agent.service @@ -3,6 +3,7 @@ Description=QEMU Guest Agent Documentation=https://wiki.qemu.org/Features/GuestAgent BindsTo=dev-virtio\x2dports-org.qemu.guest_agent.0.device After=dev-virtio\x2dports-org.qemu.guest_agent.0.device +IgnoreOnIsolate=True [Service] ExecStart=/usr/bin/qemu-ga @@ -10,3 +11,4 @@ Restart=always RestartSec=0 [Install] +WantedBy=dev-virtio\x2dports-org.qemu.guest_agent.0.device