From patchwork Wed Nov 13 21:09:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 179350 Delivered-To: patch@linaro.org Received: by 2002:ac9:3c86:0:0:0:0:0 with SMTP id w6csp9777704ocf; Wed, 13 Nov 2019 13:09:28 -0800 (PST) X-Google-Smtp-Source: APXvYqwX39ZqmY0SzAyzbL/E4s6Q4/DfS8RTIb8XoexroZBvg0av1r3Pn90htztrX7LCsbLIZeZz X-Received: by 2002:a50:9930:: with SMTP id k45mr5927928edb.134.1573679368765; Wed, 13 Nov 2019 13:09:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573679368; cv=none; d=google.com; s=arc-20160816; b=JOdwf/FgXipKDHjv25aAMJ2xJKubaXSoS0cmneAHXyqIs8l+o13d+3Ob3VqTBoa+PJ TyoOnMnpSVs3KKd+SFc2VBe5L1VGgLqo5uR9C6BoDK6C2C0ic94PVNAWha+i51kxudHk S9v8gL4etYaR0CnpIxze6ZDr+0+tP7Dxgm9Ci/rYuC8e4wBHx2XYyGcbv0iRTXqrh2Mh UK9ew/zwy0ttggkIAcC1e4iSKT0P6Vqpyl23mNW6cWyXoGQDQCVw8PW4NsEWl3i0cCYo a2770VZ+0vgJup+lCI0Emdzoe/hbfPyTXfBCJyu5K2J0QFCf+mCT6760nN5wd778GSzp Y27g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature; bh=eJCqJWR8acQwzfcefPriX5xuSEUaakfykNzq7QUKrVQ=; b=eR+GgKvmtSxUCe7OP5KblFAU5xWzUQUPTsNu/W5//O/4Rr9k7Ptk0uvRa6C44uPDEW 34u0+m5/RCurvI0QdJe4cGW2vho3rMniXA3dBF0GbcK9rhRDlBJtnAPoVUDcEhDHi5vs VCHzVL5TA5FK43vt6t6ki1L4pX67vU7dQRg0m2oppqzw1tagAW+fBdYgh4v17saFge4H hf846FC7Je6fIByOwHWr6JPnwA452oRFEq2vqWTfmgL0ZvUIxIb8k8js0YNBPe8zaPTE fFE56Ob6K6XRrcj+AzNsOxd3B60k6hCefJGLacD8dKlr7H70rGpijbqleXLBkYWSpJqr 73yQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=Kbxl38Yi; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t6si2199250edr.52.2019.11.13.13.09.28 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Nov 2019 13:09:28 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=Kbxl38Yi; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:51000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUztH-0004Wh-Gk for patch@linaro.org; Wed, 13 Nov 2019 16:09:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46103) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUzsh-0004K3-AK for qemu-devel@nongnu.org; Wed, 13 Nov 2019 16:08:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUzsg-0006Hk-6F for qemu-devel@nongnu.org; Wed, 13 Nov 2019 16:08:51 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:37098 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iUzsg-0006GP-2L for qemu-devel@nongnu.org; Wed, 13 Nov 2019 16:08:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573679329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eJCqJWR8acQwzfcefPriX5xuSEUaakfykNzq7QUKrVQ=; b=Kbxl38Yiv1YovIKOla82mpHyneAJuEwnn7dRA8ZwuSizdfRi6ATmWEZF5yQCpXLWr85Fwn URVKyUx1Mud44mEHyf+s/pmF56yXjp2W29o8NEyg4XHn4Nw14F8KmF2betJuG9ToDLV8Vk hK0U/+fOVM8U0K82cGV8czZY5P7ya14= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-92-iOGmqgjHMYuNgDAp_dSHhw-1; Wed, 13 Nov 2019 16:08:46 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 71134835B63; Wed, 13 Nov 2019 21:08:45 +0000 (UTC) Received: from worklaptop.redhat.com (ovpn-125-32.rdu2.redhat.com [10.10.125.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id B73431084192; Wed, 13 Nov 2019 21:08:41 +0000 (UTC) From: Cole Robinson To: qemu-devel@nongnu.org Subject: [PATCH] tests: fix modules-test 'duplicate test case' error Date: Wed, 13 Nov 2019 16:09:35 -0500 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: iOGmqgjHMYuNgDAp_dSHhw-1 X-Mimecast-Spam-Score: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial , =?utf-8?q?Marc-Andr=C3=A9_Lure?= =?utf-8?q?au?= , Cole Robinson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" ./configure --enable-sdl --audio-drv-list=sdl --enable-modules Will generate two identical test names: /$arch/module/load/sdl Which generates an error like: (tests/modules-test:23814): GLib-ERROR **: 18:23:06.359: duplicate test case path: /aarch64//module/load/sdl Add the subsystem prefix in the name as well, so instead we get: /$arch/module/load/audio-sdl /$arch/module/load/ui-sdl Signed-off-by: Cole Robinson --- tests/modules-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.23.0 Reviewed-by: Marc-André Lureau Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé diff --git a/tests/modules-test.c b/tests/modules-test.c index d1a6ace218..88217686e1 100644 --- a/tests/modules-test.c +++ b/tests/modules-test.c @@ -64,7 +64,8 @@ int main(int argc, char *argv[]) g_test_init(&argc, &argv, NULL); for (i = 0; i < G_N_ELEMENTS(modules); i += 2) { - char *testname = g_strdup_printf("/module/load/%s", modules[i + 1]); + char *testname = g_strdup_printf("/module/load/%s%s", + modules[i], modules[i + 1]); qtest_add_data_func(testname, modules + i, test_modules_load); g_free(testname); }