mbox series

[for-4.4.y,0/4] selftests: firmware: fix mainline test runs

Message ID 1510170852-32052-1-git-send-email-amit.pundir@linaro.org
Headers show
Series selftests: firmware: fix mainline test runs | expand

Message

Amit Pundir Nov. 8, 2017, 7:54 p.m. UTC
Hi Greg,

Please consider following upstream selftest firmware changes
to help run mainline/linux-next firmware test scripts on 4.4.y,
without breaking 0-day testing.

47e0bbb7fa98 ("test: firmware_class: report errors properly on failure")
is the one patch actually needed to make sure mainline/linux-next
selftest firmware test scripts run on 4.4.y.

Following commits are, however, required to make sure the above commit
doesn't break 0-day testing, wherein they run in-kernel selftests.
1b1fe542b6f0 ("selftests: firmware: add empty string and async tests")
880444e214cf ("selftests: firmware: send expected errors to /dev/null")
afb999cdef69 ("tools: firmware: check for distro fallback udev cancel rule")

Regards,
Amit Pundir

Brian Norris (2):
  test: firmware_class: report errors properly on failure
  selftests: firmware: add empty string and async tests

Luis R. Rodriguez (2):
  selftests: firmware: send expected errors to /dev/null
  tools: firmware: check for distro fallback udev cancel rule

 lib/test_firmware.c                               | 11 ++++++---
 tools/testing/selftests/firmware/fw_filesystem.sh | 10 +++++++-
 tools/testing/selftests/firmware/fw_userhelper.sh | 28 +++++++++++++++++++++--
 3 files changed, 43 insertions(+), 6 deletions(-)

-- 
2.7.4

Comments

Greg KH Nov. 10, 2017, 2:05 p.m. UTC | #1
On Thu, Nov 09, 2017 at 01:24:08AM +0530, Amit Pundir wrote:
> Hi Greg,

> 

> Please consider following upstream selftest firmware changes

> to help run mainline/linux-next firmware test scripts on 4.4.y,

> without breaking 0-day testing.

> 

> 47e0bbb7fa98 ("test: firmware_class: report errors properly on failure")

> is the one patch actually needed to make sure mainline/linux-next

> selftest firmware test scripts run on 4.4.y.

> 

> Following commits are, however, required to make sure the above commit

> doesn't break 0-day testing, wherein they run in-kernel selftests.

> 1b1fe542b6f0 ("selftests: firmware: add empty string and async tests")

> 880444e214cf ("selftests: firmware: send expected errors to /dev/null")

> afb999cdef69 ("tools: firmware: check for distro fallback udev cancel rule")


Now all applied, and I added the last two to 4.9 so as to not get out of
sync.

thanks,

greg k-h
Shuah Nov. 10, 2017, 2:58 p.m. UTC | #2
On 11/10/2017 07:05 AM, Greg KH wrote:
> On Thu, Nov 09, 2017 at 01:24:08AM +0530, Amit Pundir wrote:

>> Hi Greg,

>>

>> Please consider following upstream selftest firmware changes

>> to help run mainline/linux-next firmware test scripts on 4.4.y,

>> without breaking 0-day testing.

>>

>> 47e0bbb7fa98 ("test: firmware_class: report errors properly on failure")

>> is the one patch actually needed to make sure mainline/linux-next

>> selftest firmware test scripts run on 4.4.y.

>>

>> Following commits are, however, required to make sure the above commit

>> doesn't break 0-day testing, wherein they run in-kernel selftests.

>> 1b1fe542b6f0 ("selftests: firmware: add empty string and async tests")

>> 880444e214cf ("selftests: firmware: send expected errors to /dev/null")

>> afb999cdef69 ("tools: firmware: check for distro fallback udev cancel rule")

> 

> Now all applied, and I added the last two to 4.9 so as to not get out of

> sync.

> 

> thanks,

> 

> greg k-h

> 

> 


Thanks both for taking care of this.

-- Shuah