| Message ID | 20180320080027.8948-1-semen.protsenko@linaro.org |
|---|---|
| Headers | show |
| Series | Fix build on multi_v7_defconfig | expand |
On Tue, Mar 20, 2018 at 04:00:24PM +0800, Sam Protsenko wrote: > Recent patches broke build on multi_v7_defconfig (ARM), on > stable-rc/linux-4.4.y branch. The build error as follows: > > arch/arm/mach-omap2/omap_hwmod_7xx_data.c:2243:12: error: > 'HWMOD_CLKDM_NOAUTO' undeclared here (not in a function) > .flags = HWMOD_CLKDM_NOAUTO, > ^~~~~~~~~~~~~~~~~~ I just dropped this patch instead, as is it really worth adding these other patches to resolve this? thanks greg k-h
On 20 March 2018 at 16:10, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Tue, Mar 20, 2018 at 04:00:24PM +0800, Sam Protsenko wrote: >> Recent patches broke build on multi_v7_defconfig (ARM), on >> stable-rc/linux-4.4.y branch. The build error as follows: >> >> arch/arm/mach-omap2/omap_hwmod_7xx_data.c:2243:12: error: >> 'HWMOD_CLKDM_NOAUTO' undeclared here (not in a function) >> .flags = HWMOD_CLKDM_NOAUTO, >> ^~~~~~~~~~~~~~~~~~ > > I just dropped this patch instead, as is it really worth adding these > other patches to resolve this? > Agree. Those patches are the actual dependency for one that breaks the build, but it's kinda an overkill to pull that amount of code. If we really need that patch, somebody (maintainers?) should revise it and come up with a better solution, providing all needed dependency patches and predicting the impact of all series on the system, as this is a stable branch. Thanks. > thanks > > greg k-h
On 20/03/18 10:20, Sam Protsenko wrote: > On 20 March 2018 at 16:10, Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: >> On Tue, Mar 20, 2018 at 04:00:24PM +0800, Sam Protsenko wrote: >>> Recent patches broke build on multi_v7_defconfig (ARM), on >>> stable-rc/linux-4.4.y branch. The build error as follows: >>> >>> arch/arm/mach-omap2/omap_hwmod_7xx_data.c:2243:12: error: >>> 'HWMOD_CLKDM_NOAUTO' undeclared here (not in a function) >>> .flags = HWMOD_CLKDM_NOAUTO, >>> ^~~~~~~~~~~~~~~~~~ >> >> I just dropped this patch instead, as is it really worth adding these >> other patches to resolve this? >> > > Agree. Those patches are the actual dependency for one that breaks the > build, but it's kinda an overkill to pull that amount of code. If we > really need that patch, somebody (maintainers?) should revise it and > come up with a better solution, providing all needed dependency > patches and predicting the impact of all series on the system, as this > is a stable branch. Yea I don't see why this patch would be so critical to get it fixed in stable. If a need rises, we (as in TI) can work on that. -Tero -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Recent patches broke build on multi_v7_defconfig (ARM), on stable-rc/linux-4.4.y branch. The build error as follows: arch/arm/mach-omap2/omap_hwmod_7xx_data.c:2243:12: error: 'HWMOD_CLKDM_NOAUTO' undeclared here (not in a function) .flags = HWMOD_CLKDM_NOAUTO, ^~~~~~~~~~~~~~~~~~ Pull in missing dependency patches to fix that build error. 1. "Allow modules to disable HW_AUTO": this commit is needed to fix build error 2. "add usecounting support to autoidle APIs": this commit is a dependency for 1 3. "provide space for more hwmod flags": this is also a dependency for 1 Tested on TI BeagleBoard X15. Roger Quadros (1): ARM: OMAP2+ hwmod: Allow modules to disable HW_AUTO Sekhar Nori (1): ARM: OMAP2+: omap_hwmod: provide space for more hwmod flags Tero Kristo (1): ARM: OMAP2+: clockdomain: add usecounting support to autoidle APIs arch/arm/mach-omap2/clockdomain.c | 36 ++++++++++++++++++++++++------------ arch/arm/mach-omap2/clockdomain.h | 2 ++ arch/arm/mach-omap2/cpuidle44xx.c | 2 +- arch/arm/mach-omap2/omap-smp.c | 2 +- arch/arm/mach-omap2/omap_hwmod.c | 32 +++++++++++++++++--------------- arch/arm/mach-omap2/omap_hwmod.h | 7 ++++++- arch/arm/mach-omap2/pm.c | 8 +------- arch/arm/mach-omap2/powerdomain.c | 20 ++++++-------------- 8 files changed, 58 insertions(+), 51 deletions(-) -- 2.16.1