From patchwork Tue Oct 27 13:35:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matteo Croce X-Patchwork-Id: 313119 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D43AFC388F9 for ; Tue, 27 Oct 2020 13:35:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 91AE821707 for ; Tue, 27 Oct 2020 13:35:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752297AbgJ0Nf5 (ORCPT ); Tue, 27 Oct 2020 09:35:57 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:39052 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752296AbgJ0Nf4 (ORCPT ); Tue, 27 Oct 2020 09:35:56 -0400 Received: by mail-wr1-f65.google.com with SMTP id y12so1937141wrp.6; Tue, 27 Oct 2020 06:35:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g6+0uI07gwej8vOY9AHu1gUHHmahsVxYAJt5Q+A7Des=; b=ZZ3GMgxRwAqYpJfyTKg0M/AL6RIKV+uZH8sZpB3VFZXzQbKaDsh6lbPWEm9H0qXgYP 99V+0Uqx3P+S+U2zgNzHnC3BR1T6Uw12dUmtHked+gbv9TuBgwqHVUDRrkzkuDOE7EbI iOKNpYM1YXPi7I7iC3XGtFFnQxCtxdJo3MqY0f6V9nh4nOiMfoPtUZi16i3RuncGoG6W oOZeTSKRWitWdhn3mYcuwwP5rD83Pq9ov9vBDQkQZDce1zxWowrSa/yBh503d2U9W+EI JypS3UW6l5EQB4tHYrkVbb8krbsOPPBY9uI3/3UFbSuFn3I4W69OL5ipaGSetRGt95lA gGYg== X-Gm-Message-State: AOAM531CvD54o0vlc1F4PiAsZAK4rtUBefvK6bZ5TVU4k6GUFRE7CkoT IsHfVe6kIBJnVPu+kHCmP0J6Lru47g4= X-Google-Smtp-Source: ABdhPJz/LlrWPEcwYlzMUVrMCj4Wvg+V3Nbj8qBfkW3mSTfRY9vUmxd86f0gtb1MKixU/pzkz+Ybiw== X-Received: by 2002:adf:a354:: with SMTP id d20mr3140972wrb.29.1603805754703; Tue, 27 Oct 2020 06:35:54 -0700 (PDT) Received: from msft-t490s.teknoraver.net (net-2-36-134-112.cust.vodafonedsl.it. [2.36.134.112]) by smtp.gmail.com with ESMTPSA id x15sm2218175wrr.36.2020.10.27.06.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 06:35:54 -0700 (PDT) From: Matteo Croce To: linux-kernel@vger.kernel.org Cc: Guenter Roeck , Petr Mladek , Arnd Bergmann , Mike Rapoport , Kees Cook , Pavel Tatashin , Robin Holt , Fabian Frederick , stable@vger.kernel.org Subject: [PATCH v2 0/2] fix parsing of reboot= cmdline Date: Tue, 27 Oct 2020 14:35:43 +0100 Message-Id: <20201027133545.58625-1-mcroce@linux.microsoft.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Matteo Croce The parsing of the reboot= cmdline has two major errors: - a missing bound check can crash the system on reboot - parsing of the cpu number only works if specified last Fix both, along with a small code refactor. v1->v2: As Petr suggested, don't force base 10 in simple_strtoul(), so hex values are accepted as well. Matteo Croce (2): reboot: fix overflow parsing reboot cpu number reboot: fix parsing of reboot cpu number kernel/reboot.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-)