From patchwork Tue Sep 9 08:48:14 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Baldyga X-Patchwork-Id: 37053 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yh0-f70.google.com (mail-yh0-f70.google.com [209.85.213.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 36E7A20566 for ; Tue, 9 Sep 2014 08:49:07 +0000 (UTC) Received: by mail-yh0-f70.google.com with SMTP id b6sf55887719yha.9 for ; Tue, 09 Sep 2014 01:49:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=gR0mDxpR2+Tm1hCK8I+gMvvIy/jL19n4TqKeO91eeuE=; b=VCItSiKokyY6tKm6GUz5WAqY4p/re9pTdfYkAt38GEbvXgNocWYkFQ6NQIUou/ec+g q8JWy5TR/cbzxBnCRuDEwRTBQQ4Jmyv4FReSEa2bsOisysrwe0IeLq7dKHGKZFjrN7o8 +jWpYdznDj7utXDSLGTYYIlpKHw2PCMHCYQQ19iJ8YmtSP3ZMG+7xci+lrHtmcKUQLaw PS46uYUcMSsBgNArPZSHpzLN1jiPjssx61CzfMm1TF3XR64mEur48yJi5WY6ymRAWTX5 le72EXrkvTinDtUzuXB6n2QVYkcTwdEz/c4gNbgkij5T4vPG8u2dq1CUNmqLpMja8tdA qwlA== X-Gm-Message-State: ALoCoQkw2OnfE7JcLd7U+tchIVwVHWKQxbfuC1y2UAXER7iqv01oDhCeBDEzv1boAvSaIM3gdKub X-Received: by 10.236.123.200 with SMTP id v48mr231459yhh.54.1410252547055; Tue, 09 Sep 2014 01:49:07 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.46.100 with SMTP id j91ls2068713qga.44.gmail; Tue, 09 Sep 2014 01:49:07 -0700 (PDT) X-Received: by 10.52.135.133 with SMTP id ps5mr12291996vdb.33.1410252546979; Tue, 09 Sep 2014 01:49:06 -0700 (PDT) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx.google.com with ESMTPS id lr17si5588325vdb.24.2014.09.09.01.49.06 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 09 Sep 2014 01:49:06 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.182 as permitted sender) client-ip=209.85.220.182; Received: by mail-vc0-f182.google.com with SMTP id le20so2655111vcb.27 for ; Tue, 09 Sep 2014 01:49:06 -0700 (PDT) X-Received: by 10.53.7.225 with SMTP id df1mr25705502vdd.9.1410252546907; Tue, 09 Sep 2014 01:49:06 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp251582vcb; Tue, 9 Sep 2014 01:49:06 -0700 (PDT) X-Received: by 10.70.38.135 with SMTP id g7mr39744778pdk.100.1410252546048; Tue, 09 Sep 2014 01:49:06 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id zh7si21990806pac.141.2014.09.09.01.49.05 for ; Tue, 09 Sep 2014 01:49:06 -0700 (PDT) Received-SPF: none (google.com: linux-usb-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932384AbaIIItC (ORCPT + 2 others); Tue, 9 Sep 2014 04:49:02 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:47586 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932273AbaIIIsx (ORCPT ); Tue, 9 Sep 2014 04:48:53 -0400 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NBM004S0LT57YC0@mailout4.samsung.com>; Tue, 09 Sep 2014 17:48:41 +0900 (KST) X-AuditID: cbfee61b-f79f86d00000144c-d5-540ebee9af0d Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 7B.A4.05196.9EEBE045; Tue, 09 Sep 2014 17:48:41 +0900 (KST) Received: from AMDC2122.DIGITAL.local ([106.120.53.17]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NBM00JXYLSK8KA0@mmp1.samsung.com>; Tue, 09 Sep 2014 17:48:41 +0900 (KST) From: Robert Baldyga To: gregkh@linuxfoundation.org Cc: Paul.Zimmerman@synopsys.com, balbi@ti.com, stable@vger.kernel.org, linux-usb@vger.kernel.org, Marek Szyprowski , Robert Baldyga Subject: [PATCH stable 4/6] usb: dwc2/gadget: do not call disconnect method in pullup Date: Tue, 09 Sep 2014 10:48:14 +0200 Message-id: <1410252496-13814-5-git-send-email-r.baldyga@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1410252496-13814-1-git-send-email-r.baldyga@samsung.com> References: <1410252496-13814-1-git-send-email-r.baldyga@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMLMWRmVeSWpSXmKPExsVy+t9jAd2X+/hCDE7ukrI4eL/eonnxejaL RctamS3WHrnLbvHo4VZWiweHd7JbLNj4iNGB3WP/3DXsHn1bVjF6bNn/mdHj+I3tTB6fN8kF sEZx2aSk5mSWpRbp2yVwZfx4uJql4ChbxfmWE8wNjEdYuxg5OSQETCRutuxkgrDFJC7cW8/W xcjFISSwiFGic9UcZginnUli56dzYFVsAjoSW75PYASxRQTkJJ7c/gNWxCywk1Hi2extYEXC AuESq743sYDYLAKqEv3L37CB2LwCrhL32k9ArZaTOHlsMpDNwcEp4Cax4LI6SFgIqGT21Mfs Exh5FzAyrGIUTS1ILihOSs810itOzC0uzUvXS87P3cQIDqpn0jsYVzVYHGIU4GBU4uHNCOYL EWJNLCuuzD3EKMHBrCTCa7kXKMSbklhZlVqUH19UmpNafIhRmoNFSZz3YKt1oJBAemJJanZq akFqEUyWiYNTqoHRY+PjtLnSPddu3ugX0L20nL171uaUgosSDDLX3bfv9MtKqqmd/Xz1xPCY TbJrHwg5eby33i9iwrL7SbyuKvPLMxFN//kqrR2PGH5J1gzlksl02Cf8u/xO+EqdWw9nqFUU 5y6onerdcGORWeN8rb4ewVmuHutdf5rp7Pmq3y557be9/JuUszFKLMUZiYZazEXFiQD22aks JgIAAA== Sender: linux-usb-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: patch@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.182 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Marek Szyprowski This leads to potential spinlock recursion in composite framework, other udc drivers also don't call it directly from pullup method. Cc: # 3.16.x Signed-off-by: Marek Szyprowski Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index f3198dc..1c2b8dd 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -2943,7 +2943,6 @@ static int s3c_hsotg_pullup(struct usb_gadget *gadget, int is_on) s3c_hsotg_phy_enable(hsotg); s3c_hsotg_core_init(hsotg); } else { - s3c_hsotg_disconnect(hsotg); s3c_hsotg_phy_disable(hsotg); }