From patchwork Tue Jul 17 08:08:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 142113 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp3359793ljj; Tue, 17 Jul 2018 01:08:48 -0700 (PDT) X-Google-Smtp-Source: AAOMgpduWt8D4UOzPTE0d1irYnrYF8iR99ZiOiIl4hEoNwGN1KUrLE967UUWgnbwFoybsgnIrOdt X-Received: by 2002:a63:d011:: with SMTP id z17-v6mr598513pgf.272.1531814928392; Tue, 17 Jul 2018 01:08:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531814928; cv=none; d=google.com; s=arc-20160816; b=xtTx+A1yU+jAclgC7vIJFinK9icg8UAmo5WtYXKzGxdZ6CEJKIAQoJZ+Q4FAD7QYhM gEtrMrLcPikInRWsN2LqUVIzaecZZ8QUcCx5BQZsA4E8SQB8np47VoGpveW8JgVU2tv6 K/nsqjgRAfgXEkuBikGY6QlRa2FFF7F1qthmQBf7weBbFUcj2fBfjuAesOXZ7fcLKNzh D65L/79xloPWYGQlX/B2IhL293u7zBK/o99K9kRkDWd4o7N4P3Br39V4hIGz8/vWFQgl eJLnCthZ1sfhQazJYSKtxfRhpsZP3oz602dMYpaFkvQ5yX4RqMgvmDcNYHOoWtxXP37R VMNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=xfaSidnn8WMqIPb6/VQJY7fHwCZk18IuD4nzK4x5dd0=; b=rdf7oDO8KnMvqdVBuUG8ToEW2/Ji9GtRxrg3W5XtrjZdr4/quIr6p0xycXQLe5dlvW DwlITm0f7gFsb7Aujtins1NQowlOLeSCQlqHmZOSDz7ydwtFZg34J1CUPfcmJXlhf93p fyQpikPbu4Pe4D5KOn+DLxFfhCJNZYJ7BsRCH0SWcrD2M+sde8LHB6h1eVKpjELWxu+4 yUJj8fN1pobWWdHoF0WP3QPZmYVbTwIsnRkyIFpbSq+BU4uk4eIfzZGcrO3x4efcnykk dwWYOzBI2SizZfmdhIt/gJX9m10LFX7UfaH3v/liPYp+CLinMvdshpl1ArxffI42Oe6X b9ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Qp/3mBkR"; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j1-v6si309442pll.493.2018.07.17.01.08.48; Tue, 17 Jul 2018 01:08:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Qp/3mBkR"; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729661AbeGQIkJ (ORCPT + 13 others); Tue, 17 Jul 2018 04:40:09 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:45353 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726819AbeGQIkJ (ORCPT ); Tue, 17 Jul 2018 04:40:09 -0400 Received: by mail-pl0-f65.google.com with SMTP id 94-v6so114060ple.12 for ; Tue, 17 Jul 2018 01:08:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xfaSidnn8WMqIPb6/VQJY7fHwCZk18IuD4nzK4x5dd0=; b=Qp/3mBkRTSTe+x28nAwlIRfgAeFYJBBScWKaqI9CJADWoUnNSS+iU4Vl5cmTd94BsP pHAqSDDD3mNlzhlUtupPZJ4PYjGoVqcfG+HXfwzHhAb8ey6/df1uqJf2Qq8dayWIAlyT PwMxEdAOp0OcS9Q0tGMNKJiGNT+/i5PDyCYhg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xfaSidnn8WMqIPb6/VQJY7fHwCZk18IuD4nzK4x5dd0=; b=MSYdzFibpbElsnqj+sN7yp91R3V+5DVN9Ct5RUqlwNHhTm9AC1W/2RkMva4EFOMWSq u7vt+F7eVw0qgQSAlEXShIG7IWusVcm4TouTuFC57tuEexfqSHTSWzayIzkmIl2jobXA 6KcwB3Y9eXQhO6+h8bzoa7634fJ8HPBrf7F17GA7tHH8wroOlYy056lOOlXvVw1Zd+LY NpwXh2HZAH7Mz5LUz6yfigxFb7Y3nYJnCgOaHx2xrsmwzHP4/02n/Ar5lg0xLNNfNP1H d3h82UQ6xTwVCugNTRvRT+JOp/Z/cFUDgpkNrHK4tEvR1gRN3JPvpTKYDBdZ3yuL9X21 F+qg== X-Gm-Message-State: AOUpUlFVNpduCU2POElkEeTXlXRGHX1faLzPTEe4d9+6xcztu3z6N4bJ TuqjIT0M/F89SOwsQnh3YA5xWeDvmho= X-Received: by 2002:a17:902:9302:: with SMTP id bc2-v6mr634650plb.280.1531814926942; Tue, 17 Jul 2018 01:08:46 -0700 (PDT) Received: from localhost.localdomain ([106.51.22.240]) by smtp.gmail.com with ESMTPSA id c85-v6sm2205083pfd.110.2018.07.17.01.08.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Jul 2018 01:08:45 -0700 (PDT) From: Amit Pundir To: Greg KH , Stable Cc: Christian Lamparter , Herbert Xu Subject: [PATCH for-4.14.y 2/5] crypto: crypto4xx - remove bad list_del Date: Tue, 17 Jul 2018 13:38:31 +0530 Message-Id: <1531814914-19191-3-git-send-email-amit.pundir@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1531814914-19191-1-git-send-email-amit.pundir@linaro.org> References: <1531814914-19191-1-git-send-email-amit.pundir@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Christian Lamparter commit a728a196d253530f17da5c86dc7dfbe58c5f7094 upstream. alg entries are only added to the list, after the registration was successful. If the registration failed, it was never added to the list in the first place. Signed-off-by: Christian Lamparter Signed-off-by: Herbert Xu Signed-off-by: Amit Pundir --- Cherry-picked from lede tree https://git.lede-project.org/?p=source.git drivers/crypto/amcc/crypto4xx_core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.7.4 diff --git a/drivers/crypto/amcc/crypto4xx_core.c b/drivers/crypto/amcc/crypto4xx_core.c index 65dc78b91dea..3118cec0d81e 100644 --- a/drivers/crypto/amcc/crypto4xx_core.c +++ b/drivers/crypto/amcc/crypto4xx_core.c @@ -1033,12 +1033,10 @@ int crypto4xx_register_alg(struct crypto4xx_device *sec_dev, break; } - if (rc) { - list_del(&alg->entry); + if (rc) kfree(alg); - } else { + else list_add_tail(&alg->entry, &sec_dev->alg_list); - } } return 0;