From patchwork Tue Aug 28 20:13:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 145370 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp1589532ljw; Tue, 28 Aug 2018 13:14:16 -0700 (PDT) X-Google-Smtp-Source: ANB0Vdb58seCM726NcJECmlf1q+8MW31kbLd+8wI8Wk0xzo7+hk7IrrwEt/AYNZZrxaNqDYcv5mS X-Received: by 2002:a17:902:e190:: with SMTP id cd16-v6mr2880682plb.305.1535487256090; Tue, 28 Aug 2018 13:14:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535487256; cv=none; d=google.com; s=arc-20160816; b=J9ZeRt5Lhs/kRzK4VRGjWOUko0W7nyi2c95FZdPABjQNVZ/YszfuSAgLpDNUV/nUt9 yIGQvgNt8qUXovxWG1tUxHhtgU0WQ5ZPplsbrH1B37RC9sbXrxd7bFbgV354PTB+zJ4E dV0KG/BIgkkJ35hrXGH7xRLsd5tjlW3owhS6tN4UXIhw6y/3HKDdtLjWWslwJ8eq3phs YHMjCImTgizfBq1/g7M+I08oz7zzQEe5YQVnQK4RWxoIy9m5C0ae4YiKAKxlAMKqP6n3 sm/knE+CYIfcOIREFDV3fJq6oQ/MQn3rdo1QZ4d5eFAhHHaMrA6w5n+OnhiyjhCLGHsK zc2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=C0nQimwuIw9aUPcGBBVl1Omj2YnwzA/ET0MZeeWEF3U=; b=jACX1mjOeHrPiRNxT3GseplV//kKQoK+TOwA35BhaPV6k6Eu0h9CZU8NQGYSslYCmX pW6EJinI4ahoiElsj7TDX/1CFOaCmSNENgvBal169UrLnDTxX9a62rBKN4cGqp3l/LLN ha5JdkcFZf4YRxV+8ZpzySh9eWVmdZvM81JVQHCC6+jUavyJ2Bc5KUjUql+2KIK82yFZ e2vj3L+YhM95ctYTI0XO0ZRm3GwcDaN200qxK6Fx5ngudIi9NV+ed7DWafMd0XR4JC+d wShiKEm3QsQYaDkmpfDuL6Tv/HtCv9cvs44JQy1IICP/bAXojUoSG+0MrHOTj86VFoQw DPEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PliUOURu; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y10-v6si1906969pgf.312.2018.08.28.13.14.15; Tue, 28 Aug 2018 13:14:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PliUOURu; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727201AbeH2AH3 (ORCPT + 13 others); Tue, 28 Aug 2018 20:07:29 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:36553 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726961AbeH2AH3 (ORCPT ); Tue, 28 Aug 2018 20:07:29 -0400 Received: by mail-pl1-f195.google.com with SMTP id e11-v6so1211164plb.3 for ; Tue, 28 Aug 2018 13:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=C0nQimwuIw9aUPcGBBVl1Omj2YnwzA/ET0MZeeWEF3U=; b=PliUOURumiIr4SIemwKq/8B7HUV9vjws+Q10q0K9xy14sUx8OMQfuiiTxQ15jf6YZO YVEQU8qRHK7YwzZpOqNxpXaanjZHb5kAS5qkKhKGQTGj6TAcEzhikla/b5T+fF8bZ91q xBk9z+I9mvQeOq14I0jALgZbA2hBTn2N4uX/4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=C0nQimwuIw9aUPcGBBVl1Omj2YnwzA/ET0MZeeWEF3U=; b=nQ0SvI8fGY4rEJiSWrtVt17wVUVxfM2ElPV2U9PLJdwA4ugvA3U8H6fFBq6ESM2RLV bL/Oip/SQ8XIujqYUOOr6MFLBMQqv8ZE1SrtKdx88SEzrrOf8LJ2sYzdzk3WMqh8s25h 4Pki20pXt8KzH1eyYOF5GpL1IJirG0GlA9UF1NMHXg/nvESCBgHZip7OaspH2ez+pmun NOuZhWi7pNXWga1/aPnOS66c+0XUppZCc7CXTA7ZTXqfCUYuLQgUoM8KAQHZFUEKHL1K s0z18L6U42PJewjuyMBJ6nk+SEfgfN1f/2gTVeZ4az5YvScxrLhaHs9PvdVGchLoea8D qNNg== X-Gm-Message-State: APzg51D+RDFoOkcxYiq67UlzOv3OQkPIZE5bLE06sOFGwrqobSfaFosW jbIJrTZHF7J2m9sbIHKjYsckyHG13OCF9Q== X-Received: by 2002:a17:902:722:: with SMTP id 31-v6mr2880769pli.207.1535487254481; Tue, 28 Aug 2018 13:14:14 -0700 (PDT) Received: from localhost.localdomain ([49.207.48.21]) by smtp.gmail.com with ESMTPSA id t86-v6sm3098181pfe.109.2018.08.28.13.14.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 28 Aug 2018 13:14:13 -0700 (PDT) From: Amit Pundir To: Greg KH Cc: Stable , Johannes Weiner , Jia He , Andrew Morton , Linus Torvalds Subject: [PATCH for-4.9.y 14/14] mm: remove seemingly spurious reclaimability check from laptop_mode gating Date: Wed, 29 Aug 2018 01:43:25 +0530 Message-Id: <1535487205-26280-15-git-send-email-amit.pundir@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1535487205-26280-1-git-send-email-amit.pundir@linaro.org> References: <1535487205-26280-1-git-send-email-amit.pundir@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Johannes Weiner commit 047d72c30eedcb953222810f1e7dcaae663aa452 upstream. Commit 1d82de618ddd ("mm, vmscan: make kswapd reclaim in terms of nodes") allowed laptop_mode=1 to start writing not just when the priority drops to DEF_PRIORITY - 2 but also when the node is unreclaimable. That appears to be a spurious change in this patch as I doubt the series was tested with laptop_mode, and neither is that particular change mentioned in the changelog. Remove it, it's still recent. Link: http://lkml.kernel.org/r/20170228214007.5621-4-hannes@cmpxchg.org Signed-off-by: Johannes Weiner Acked-by: Hillf Danton Acked-by: Mel Gorman Acked-by: Michal Hocko Cc: Jia He Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Amit Pundir --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/mm/vmscan.c b/mm/vmscan.c index cfffef1f26a8..4e5846b8b5eb 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3301,7 +3301,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int classzone_idx) * If we're getting trouble reclaiming, start doing writepage * even in laptop mode. */ - if (sc.priority < DEF_PRIORITY - 2 || !pgdat_reclaimable(pgdat)) + if (sc.priority < DEF_PRIORITY - 2) sc.may_writepage = 1; /* Call soft limit reclaim before calling shrink_node. */