From patchwork Thu May 4 20:52:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 98574 Delivered-To: patch@linaro.org Received: by 10.140.89.200 with SMTP id v66csp806367qgd; Thu, 4 May 2017 13:52:25 -0700 (PDT) X-Received: by 10.99.161.26 with SMTP id b26mr48589025pgf.115.1493931145795; Thu, 04 May 2017 13:52:25 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x7si3136031pls.89.2017.05.04.13.52.25; Thu, 04 May 2017 13:52:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751238AbdEDUwY (ORCPT + 6 others); Thu, 4 May 2017 16:52:24 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:57280 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832AbdEDUwV (ORCPT ); Thu, 4 May 2017 16:52:21 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.129]) with ESMTPA (Nemesis) id 0MUxAq-1daAdq3LLg-00YDqX; Thu, 04 May 2017 22:52:18 +0200 From: Arnd Bergmann To: gregkh@linuxfoundation.org Cc: stable@vger.kernel.org, Arnd Bergmann Subject: [PATCH 07/13] [3.18-stable] IB/ehca: fix maybe-uninitialized warnings Date: Thu, 4 May 2017 22:52:03 +0200 Message-Id: <20170504205209.498721-8-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170504205209.498721-1-arnd@arndb.de> References: <20170504205209.498721-1-arnd@arndb.de> X-Provags-ID: V03:K0:0Eqs13dWrJCpuz5M/C3tZe1qmPbOhEnaJhpXURQ5UhikKm5R/Zn CyLhVebzvkSBnOFCu2O7NPugCW2q9YyZ1KRedqKrP3+6CmeKnryOyPDmW7XN30wW3CUIQaw FZYL0DTslabc45DENbk5M4uhsdBveC75My6pWFj9QwN8EgMEYSt0ro6vBNEGmlBihL43KSi SK9nQwOPBfd7Xvpmv6OAA== X-UI-Out-Filterresults: notjunk:1; V01:K0:kAIWXkdLHL4=:908e3YYh9fhSSkGU+BP/bh vyVpOUTb4LCCmkbvyR4ToO0q8c+P9DHUQDS8pqesyU1RSRutgSfv9OgP5o4lvOBgkz1LxEkQw po1HtxXd5z+z7QWMrUPJl/wVGHP9J0aOAoA3dZM2IyDHJTSwCzhMHeq6C+HQKa1nvX8KAoR1X h2k6HiQkt42obgjvEPW7CSkiCrvEY2GU4Jk+fJ5C1+T5u2BO+8AwIyfjL95dmTIU4K1XoLjXS 1gISM1v8oOEHinsp6US4CvXxZHQ4HhwJ4u03WGAOiHbxJDygW31OZV7S/6f0bzEqkRh+8OFYB h0Yu/KG7lrIFFyXEIgBRO5k4bYUQpqS0gC3rqOuKu7CXAFvc7+TA71PqjiyoZB5iRfl5N8Wo3 8tdAkuZdaT96qvgyMxj+1VRdh+q7pnCOq3x1Cvd8fRhKTUtolhY95DhwiTZWFU+u4MURy7pD2 cO6gBLo7Uf1j1k2MY3jF4NPOK3XCMF31E9aShYlPEsPiPBa2iqip4Q4RSfHEOucCNqiBZnoDR 2DzWv/ib6hSMm4GGx8KnSw53mf/W3AspHsfFZW0Qvcc76xbxkQIl4TfF94UOlf08G+Xa5AXkR ILfI/RlC5ops1hG7CF3AFl/ZmfNYrVeOHhSfMXoMHinMZOj3JVk005qd1nM61vmh8s4Ah2kr6 j70ch0lufCTTFAKDFf4GaiPSTwficv3ULb1Pea9p0xlZQDHu04tudSbpzoVWYEr0Uyw8= Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The driver causes two warnings about possibly uninitialized variables: drivers/infiniband/hw/ehca/ehca_mrmw.c: In function 'ehca_set_pagebuf': drivers/infiniband/hw/ehca/ehca_mrmw.c:1908:4: warning: 'prev_pgaddr' may be used uninitialized in this function [-Wmaybe-uninitialized] drivers/infiniband/hw/ehca/ehca_mrmw.c:1924:14: note: 'prev_pgaddr' was declared here drivers/infiniband/hw/ehca/ehca_mrmw.c: In function 'ehca_reg_mr': drivers/infiniband/hw/ehca/ehca_mrmw.c:2430:5: warning: 'hret' may be used uninitialized in this function [-Wmaybe-uninitialized] The first one is definitely a false positive, the second one may or may not be one. In both cases, adding an intialization is the safe and easy workaround. The driver was removed in mainline in commit e581d111dad3 ("staging/rdma: remove deprecated ehca driver"), in linux-4.6. In 4.4, the file is located in drivers/staging/rdma/ehca/ehca_mrmw.c, and the fix still applies. Signed-off-by: Arnd Bergmann --- drivers/infiniband/hw/ehca/ehca_mrmw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.9.0 diff --git a/drivers/infiniband/hw/ehca/ehca_mrmw.c b/drivers/infiniband/hw/ehca/ehca_mrmw.c index 3488e8c9fcb4..62b61e9b60ce 100644 --- a/drivers/infiniband/hw/ehca/ehca_mrmw.c +++ b/drivers/infiniband/hw/ehca/ehca_mrmw.c @@ -1921,7 +1921,7 @@ static int ehca_set_pagebuf_user2(struct ehca_mr_pginfo *pginfo, u64 *kpage) { int ret = 0; - u64 pgaddr, prev_pgaddr; + u64 pgaddr, prev_pgaddr = 0; u32 j = 0; int kpages_per_hwpage = pginfo->hwpage_size / PAGE_SIZE; int nr_kpages = kpages_per_hwpage; @@ -2417,6 +2417,7 @@ static int ehca_reg_bmap_mr_rpages(struct ehca_shca *shca, ehca_err(&shca->ib_device, "kpage alloc failed"); return -ENOMEM; } + hret = H_SUCCESS; for (top = 0; top < EHCA_MAP_ENTRIES; top++) { if (!ehca_bmap_valid(ehca_bmap->top[top])) continue;