From patchwork Fri May 5 19:46:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 98678 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp292732qge; Fri, 5 May 2017 12:48:27 -0700 (PDT) X-Received: by 10.98.155.28 with SMTP id r28mr18356040pfd.198.1494013706534; Fri, 05 May 2017 12:48:26 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 144si6012850pfa.118.2017.05.05.12.48.26; Fri, 05 May 2017 12:48:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755309AbdEETsZ (ORCPT + 6 others); Fri, 5 May 2017 15:48:25 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:52928 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755479AbdEETsQ (ORCPT ); Fri, 5 May 2017 15:48:16 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0MFljh-1dJ7GN1tUT-00Eg4e; Fri, 05 May 2017 21:48:14 +0200 From: Arnd Bergmann To: Ben Hutchings Cc: stable@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman Subject: [PATCH 3.16-stable 32/87] dm bufio: hide bogus warning Date: Fri, 5 May 2017 21:46:50 +0200 Message-Id: <20170505194745.3627137-33-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170505194745.3627137-1-arnd@arndb.de> References: <20170505194745.3627137-1-arnd@arndb.de> X-Provags-ID: V03:K0:tcysIQgZiHTQu9jOp26wUUQQQvZi/8/g+IeYuD3zWJmJX+FLcHN 5oYEZXqEEkTz7+QeXZbv9qQhGyjxVn6ip6OQ2svRUQRT1tLzJImmOwS0eBYgJ4aqWsEi9LC 3YRaQi+GTG3tidIxdjyDtDIfkJMiaASkYSG1Huds1ODPCeiMrf8opWPGYFARIr1YxCeW04U EPJv2DKEz98QxSDRucozg== X-UI-Out-Filterresults: notjunk:1; V01:K0:ysOJejACqp8=:lKnwi3stwEtQr6cFNTxClb SVGlVSjmhc1FYzMrCzCqmZHzRptfh6Fqi7IyrZRa78l1vFZvZxFUK7xZH4v2jVLum6k+vDZxK 5np2IKiVWZm4tmL0Hg+beWaAKxJd2DFsIaMVh6i/eF7nhACs6RQWPSO6eROW7uZqqDJAh62NL GeFVUc7SZ7H8JDZ+C0H7WKw8TZUM+vjSlMtb1/N+gx8S/NgKr/IjlvfDa22IQjhJFQ7X1tlDV zIYteGaNzR60YgQWNNRWlEjx4kDL+dWi2w0gRawjL2IctB6ZMDmDaqntlv85TOgavinxX6x7z dTZcqJ/jqfncHPrW3n6WTFNLQN1ltRXYhf0lrvaU8v0/8Sl4uMPqiMKsedRM3n0a5x+A7sTAm tYAEfty3O6UAPUrCY7evi37Q112cg+KumR+n/TsXDrxoJJEIjm3HofX/LYD5mDW3lWNx8hGmz VtSTa5YFIZaB8WEUXpBBM4gLEGThtozs0iB+d9qc7qBNd09tqH/r42XPJX2wKzjmrpoXu6Wit f6+pektVDaONEGy8faI2zICIwktYZFlo5erncCmK892BcqrqcBKXtllRUYNMmsB2bFal//LzJ BZ8Z1cNA6kV0P6u/Dp/2xWpEqoVtCugqADSNYHamfW3J2xvFxKNUOKplrdBoMP3Z1DD9FI7cz YbA8At5xbbyr8tUs1Z1oyNBSRe+iux4e7e/l3x7BD42iu9erFzyeobDv6EYny475gfAk= Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org mips-gcc-5.3 warns about correct code on linux-3.18 and earlier: In file included from ../include/linux/blkdev.h:4:0, from ../drivers/md/dm-bufio.h:12, from ../drivers/md/dm-bufio.c:9: ../drivers/md/dm-bufio.c: In function 'alloc_buffer': ../include/linux/sched.h:1975:56: warning: 'noio_flag' may be used uninitialized in this function [-Wmaybe-uninitialized] current->flags = (current->flags & ~PF_MEMALLOC_NOIO) | flags; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ ../drivers/md/dm-bufio.c:325:11: note: 'noio_flag' was declared here The warning disappeared on later kernels with this commit: be0c37c985ed ("MIPS: Rearrange PTE bits into fixed positions.") I assume this only happened because it changed some inlining decisions. On 3.18.y, we can shut up the warning by adding an extra initialization. Signed-off-by: Arnd Bergmann Signed-off-by: Greg Kroah-Hartman --- drivers/md/dm-bufio.c | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c index 4d1edcf552bb..3711ca2a709e 100644 --- a/drivers/md/dm-bufio.c +++ b/drivers/md/dm-bufio.c @@ -349,6 +349,7 @@ static void *alloc_buffer_data(struct dm_bufio_client *c, gfp_t gfp_mask, * as if GFP_NOIO was specified. */ + noio_flag = 0; if (gfp_mask & __GFP_NORETRY) noio_flag = memalloc_noio_save();