From patchwork Wed Sep 20 04:45:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Levin, Alexander \(Sasha Levin\)" X-Patchwork-Id: 113079 Delivered-To: patch@linaro.org Received: by 10.140.106.117 with SMTP id d108csp314130qgf; Tue, 19 Sep 2017 21:45:48 -0700 (PDT) X-Google-Smtp-Source: AOwi7QCIwucbBpE0Rx6FlxsAJG/wn0cckNzpr0F1k3SB8gAWVtaSG3DvckSJ4iEAOqY4dGnOslVg X-Received: by 10.99.100.70 with SMTP id y67mr918831pgb.248.1505882748227; Tue, 19 Sep 2017 21:45:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505882748; cv=none; d=google.com; s=arc-20160816; b=aM2ib0uqGFlMP7RfDExJOPMG0oYRQCc7pNvdDlh/9wlgg/o6OqBdA5lpMJdCppysJU LgBiEUsUAPzOnNKv2KFsrCYzlos5FcrecOdjZ6oTTTJ9sie2UmC08CmOqEa2iCL/QtHi E9yF68DzN+u/FiBxgp5VN8/WiZqne9Hi1dzYxR8pepHh62xwBQbFvb//GFDFXwJkpNNz vt2p20ZqpyIvjF2V1O5VUJtrDhoQqPISOcZ/ZCEZFCwjIplo3X5ukLGWJEa7uuqV6YxD d6bPcRrwJ6g1gsWLB8HAhqruf3q/mAjZmxAbMSa2rU91th+GA2OUdvHrwUpvaONbcHQ7 4lXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:to:dkim-signature :dkim-signature:cc:from:dkim-signature:arc-authentication-results; bh=RLheaW3NL0g4N2nIQMPXYjJ0PiIyPFK5Z0H3Pvm5Ns4=; b=WlI1fkgfOfL9648sKitJyiMWLWXPinnNgQSbqCJyKESKxUydtoUMdivXS5UvUcRty/ oqo95XYuvqXBmS/igmQp/XNg1Zuq67lJ5tU0VBff6lpA7KFtuNUtwpMvXVU3xf5g6ERU Opi0WJj1wHuhGeUnSDO94ZaCWsMRBStOCLAkOcQZE9+vqCbGIC1PIF1Qlgs4G2Wi77qg jwiznOhgXA+iuD8n/B8k8kn171AOfqECcIDkkZTmgidas6YtVmk9OkAR6Ay9CYiQn7/l 7Fu0+P78RkVKrS/WVzutiD2MTsTa5T3GvKo/erAK3hQnW/eUWom3kGbdDx215Xue79Xf vBKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@verizon.com header.s=corp header.b=SKs/JuHG; dkim=fail header.i=@verizon.com header.s=corp header.b=N5i0sZEi; dkim=fail header.i=@verizon.com header.s=corp header.b=sUfTHvE1; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=verizon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j9si2580610pgs.702.2017.09.19.21.45.48; Tue, 19 Sep 2017 21:45:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@verizon.com header.s=corp header.b=SKs/JuHG; dkim=fail header.i=@verizon.com header.s=corp header.b=N5i0sZEi; dkim=fail header.i=@verizon.com header.s=corp header.b=sUfTHvE1; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=verizon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751599AbdITEpp (ORCPT + 7 others); Wed, 20 Sep 2017 00:45:45 -0400 Received: from omzsmtpe03.verizonbusiness.com ([199.249.25.208]:11831 "EHLO omzsmtpe03.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbdITEp3 (ORCPT ); Wed, 20 Sep 2017 00:45:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1505882729; x=1537418729; h=from:cc:to:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=1yontPG1P74X54WmVcMbw2nWm8YKYQddXpV6SIhxGWw=; b=SKs/JuHGI14Csvk3Zj7ECiZZGOBpq9vyMu5F9jIKKunXAdEapcbpYPvM DkBte0J56AUbhvAjQiMmKlkWRIYRt22/u0CGdYoSBzbeGtO2Ib4flA3qk 71X6awKJkj2UU60ATiQAcAGsXmRkc1QotSeBBXVKORYAro+hY87ap3zSs o=; Received: from unknown (HELO fldsmtpi01.verizon.com) ([166.68.71.143]) by omzsmtpe03.verizonbusiness.com with ESMTP; 20 Sep 2017 04:45:26 +0000 From: "Levin, Alexander (Sasha Levin)" Cc: Arnd Bergmann , John Crispin , "linux-mips@linux-mips.org" , Ralf Baechle , "Levin, Alexander (Sasha Levin)" Received: from rogue-10-255-192-101.rogue.vzwcorp.com (HELO atlantis.verizonwireless.com) ([10.255.192.101]) by fldsmtpi01.verizon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 20 Sep 2017 04:45:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1505882721; x=1537418721; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=1yontPG1P74X54WmVcMbw2nWm8YKYQddXpV6SIhxGWw=; b=N5i0sZEiemNvrh3TIy0rGqZYn3bmum3v4vi4e1C9PBRWLuFpnfBKeg3B rTZXFFVuNGghemkNGLllUAkMgjV6SJSXVKLZ2ISof2HIWGeF8+FnvyjZp yYusYbYMbqWsj7qB2E9LIxuqWJVHPi/1zyKu4AaO9uB/11nRbUG8DS2v5 w=; Received: from viking.odc.vzwcorp.com (HELO mercury.verizonwireless.com) ([10.255.240.26]) by atlantis.verizonwireless.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 20 Sep 2017 00:45:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1505882720; x=1537418720; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=1yontPG1P74X54WmVcMbw2nWm8YKYQddXpV6SIhxGWw=; b=sUfTHvE1OTvQ6hORyXNXFr4j22hO+3J53LOnYxQO+wOiNEthrQ7P8g2E BXb71hfYU7UkMOd4Cko7pJw0nyHOyvLSiZKMHqQBaJL/JTMj3aDlcHbKu 3f7zkdtv2m+JaojhBKG7MKJKkq5PFUBOjWAf2mwSRb+F2sXvynqmhNDmV 8=; X-Host: viking.odc.vzwcorp.com Received: from casac1exh001.uswin.ad.vzwcorp.com ([10.11.218.43]) by mercury.verizonwireless.com with ESMTP/TLS/AES128-SHA256; 20 Sep 2017 04:45:19 +0000 Received: from scwexch18apd.uswin.ad.vzwcorp.com (153.114.130.37) by CASAC1EXH001.uswin.ad.vzwcorp.com (10.11.218.43) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 19 Sep 2017 21:45:19 -0700 Received: from OMZP1LUMXCA14.uswin.ad.vzwcorp.com (144.8.22.189) by scwexch18apd.uswin.ad.vzwcorp.com (153.114.130.37) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Tue, 19 Sep 2017 21:45:18 -0700 Received: from OMZP1LUMXCA17.uswin.ad.vzwcorp.com (144.8.22.195) by OMZP1LUMXCA14.uswin.ad.vzwcorp.com (144.8.22.189) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Tue, 19 Sep 2017 23:45:17 -0500 Received: from OMZP1LUMXCA17.uswin.ad.vzwcorp.com ([144.8.22.195]) by OMZP1LUMXCA17.uswin.ad.vzwcorp.com ([144.8.22.195]) with mapi id 15.00.1263.000; Tue, 19 Sep 2017 23:45:17 -0500 To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: [PATCH review for 4.4 30/47] MIPS: Lantiq: Fix another request_mem_region() return code check Thread-Topic: [PATCH review for 4.4 30/47] MIPS: Lantiq: Fix another request_mem_region() return code check Thread-Index: AQHTMcs7JSUhJYXtEkSs2C8QyTbM+g== Date: Wed, 20 Sep 2017 04:45:07 +0000 Message-ID: <20170920044445.7392-30-alexander.levin@verizon.com> References: <20170920044445.7392-1-alexander.levin@verizon.com> In-Reply-To: <20170920044445.7392-1-alexander.levin@verizon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit 98ea51cb0c8ce009d9da1fd7b48f0ff1d7a9bbb0 ] Hauke already fixed a couple of them, but one instance remains that checks for a negative integer when it should check for a NULL pointer: arch/mips/lantiq/xway/sysctrl.c: In function 'ltq_soc_init': arch/mips/lantiq/xway/sysctrl.c:473:19: error: ordered comparison of pointer with integer zero [-Werror=extra] Fixes: 6e807852676a ("MIPS: Lantiq: Fix check for return value of request_mem_region()") Signed-off-by: Arnd Bergmann Cc: John Crispin Cc: linux-mips@linux-mips.org Cc: linux-kernel@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/15043/ Signed-off-by: Ralf Baechle Signed-off-by: Sasha Levin --- arch/mips/lantiq/xway/sysctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.11.0 diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c index daf580ce5ca2..2528181232fd 100644 --- a/arch/mips/lantiq/xway/sysctrl.c +++ b/arch/mips/lantiq/xway/sysctrl.c @@ -469,8 +469,8 @@ void __init ltq_soc_init(void) panic("Failed to load xbar nodes from devicetree"); if (of_address_to_resource(np_xbar, 0, &res_xbar)) panic("Failed to get xbar resources"); - if (request_mem_region(res_xbar.start, resource_size(&res_xbar), - res_xbar.name) < 0) + if (!request_mem_region(res_xbar.start, resource_size(&res_xbar), + res_xbar.name)) panic("Failed to get xbar resources"); ltq_xbar_membase = ioremap_nocache(res_xbar.start,