From patchwork Sun Sep 24 18:41:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Levin, Alexander \(Sasha Levin\)" X-Patchwork-Id: 114138 Delivered-To: patch@linaro.org Received: by 10.140.106.117 with SMTP id d108csp1806196qgf; Sun, 24 Sep 2017 11:43:23 -0700 (PDT) X-Google-Smtp-Source: AOwi7QDir3G4GLE4lvahQ/MhWdg3pENt4cFT3Kv1mkaj+ssQoTm9mEgBI6JNg70mm8pnwMQXlxCE X-Received: by 10.99.98.131 with SMTP id w125mr5401519pgb.214.1506278603523; Sun, 24 Sep 2017 11:43:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1506278603; cv=none; d=google.com; s=arc-20160816; b=wdgGa1tvpmyLr+p1X78fhrw0tDvitc13OequUXwNQl503QSBDn1hbT6aZvJaGEebcS 2ljDWBooKit6b47F705DzGoJpWk6LJDIjrl0+57hfTpm60tZLyhTrRKGx0Q2EuN/jea4 VpKWJ9N/AXBvxgcib+Q8tVLPPbX4s9O/2aGrHk2AavkQx+VonUDJMXsfs6sotzz7SqKh Uo5n6ANfLTem2U872bJxdpOsT1STOOWfqhC4mbJALQTep1dNfvqOXodfk3jn1C3Lxm6Q hRIpHQ410QeN/PV8ROEM0dxJAsl5QnQbFYWTIfgqIumdW/s1/8vUl0X5lvjPnFrspkCV epLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:dkim-signature :dkim-signature:from:dkim-signature:arc-authentication-results; bh=FaIBPOeKN7aA/nVQqJMBW1U/UzfmqdYiv38BUq+K5JA=; b=jJlzDFw7FE69DHgAm7uKINj09MJF8X/yIJapEtZ4phfieTE9KO51TNfpeEUnBOhVhl elIzj8k0b+SEIlhaD7jebxrXyVS8qo4nH6fO5K4z6Ri+DxXrusvrIpAdCtrw/6AXRysJ /tYexrgLJXCS2cMp7XMcpH7wDpON5y8+S2yzbOpTptYQexNRwSYI3D2//15GUR351Emf AIenePDMtVEldkt1f9C91DJISHOUGPWW9ka+/tETvlzaIObTibuh7AtFSNa6BEy5UEU+ AFIB8Lj9cBzTN1XAsQVRf4/okTVEagCvGbyvAMkovAiIhwjmgSkP0EB8eQ63bsK1RjPV o0aA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@verizon.com header.s=corp header.b=UlHwdLzg; dkim=fail header.i=@verizon.com header.s=corp header.b=MweFY5FX; dkim=fail header.i=@verizon.com header.s=corp header.b=MweFY5FX; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=verizon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h4si3003187pgs.34.2017.09.24.11.43.23; Sun, 24 Sep 2017 11:43:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@verizon.com header.s=corp header.b=UlHwdLzg; dkim=fail header.i=@verizon.com header.s=corp header.b=MweFY5FX; dkim=fail header.i=@verizon.com header.s=corp header.b=MweFY5FX; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=verizon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752836AbdIXSnW (ORCPT + 8 others); Sun, 24 Sep 2017 14:43:22 -0400 Received: from omzsmtpe03.verizonbusiness.com ([199.249.25.208]:5356 "EHLO omzsmtpe03.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752851AbdIXSnH (ORCPT ); Sun, 24 Sep 2017 14:43:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506278587; x=1537814587; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=yNRUdmY/S5Rebb/GBqI5y/FHVkkGrnjFXCDH8vc404w=; b=UlHwdLzggNxLTmv+fGeMbx03m4933s1oLqmA9pKyIHggoB+bUV035gHp GJm4RHF9Bt92jY61MGhlnoecYXQVwEzySgscke3+/wQJuh9LOka5BxISA oS6ymbaNz1jH5UFFQjQp7QGfTlt3gb6b3P4nZqm6sCqanAxf87f5x+OG4 k=; Received: from unknown (HELO fldsmtpi01.verizon.com) ([166.68.71.143]) by omzsmtpe03.verizonbusiness.com with ESMTP; 24 Sep 2017 18:42:53 +0000 From: "Levin, Alexander (Sasha Levin)" Received: from rogue-10-255-192-101.rogue.vzwcorp.com (HELO apollo.verizonwireless.com) ([10.255.192.101]) by fldsmtpi01.verizon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 24 Sep 2017 18:42:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506278564; x=1537814564; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=yNRUdmY/S5Rebb/GBqI5y/FHVkkGrnjFXCDH8vc404w=; b=MweFY5FXPNcVhOw6TI70LbukRYONZ16nCKk8tD+j26bl7CaUBGzwK7J0 NIsOVDsasoCi50Qe4/3YGT4DV0OIvBZi/+AnSIW03sdFWUFzI0utVRged 464S1pXnUGwQq/Lq6KJAELbPj2VO0TDO680bmwVrl6RMHZYDfI51yjc0v U=; Received: from challenger.odc.vzwcorp.com (HELO mercury.verizonwireless.com) ([10.255.240.24]) by apollo.verizonwireless.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 24 Sep 2017 14:42:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506278564; x=1537814564; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=yNRUdmY/S5Rebb/GBqI5y/FHVkkGrnjFXCDH8vc404w=; b=MweFY5FXPNcVhOw6TI70LbukRYONZ16nCKk8tD+j26bl7CaUBGzwK7J0 NIsOVDsasoCi50Qe4/3YGT4DV0OIvBZi/+AnSIW03sdFWUFzI0utVRged 464S1pXnUGwQq/Lq6KJAELbPj2VO0TDO680bmwVrl6RMHZYDfI51yjc0v U=; X-Host: challenger.odc.vzwcorp.com Received: from casac1exh001.uswin.ad.vzwcorp.com ([10.11.218.43]) by mercury.verizonwireless.com with ESMTP/TLS/AES128-SHA256; 24 Sep 2017 18:42:44 +0000 Received: from scwexch14apd.uswin.ad.vzwcorp.com (153.114.130.33) by CASAC1EXH001.uswin.ad.vzwcorp.com (10.11.218.43) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 24 Sep 2017 11:42:43 -0700 Received: from OMZP1LUMXCA16.uswin.ad.vzwcorp.com (144.8.22.194) by scwexch14apd.uswin.ad.vzwcorp.com (153.114.130.33) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Sun, 24 Sep 2017 11:42:42 -0700 Received: from OMZP1LUMXCA17.uswin.ad.vzwcorp.com (144.8.22.195) by OMZP1LUMXCA16.uswin.ad.vzwcorp.com (144.8.22.194) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Sun, 24 Sep 2017 13:42:41 -0500 Received: from OMZP1LUMXCA17.uswin.ad.vzwcorp.com ([144.8.22.195]) by OMZP1LUMXCA17.uswin.ad.vzwcorp.com ([144.8.22.195]) with mapi id 15.00.1263.000; Sun, 24 Sep 2017 13:42:41 -0500 To: "gregkh@linuxfoundation.org" CC: "stable@vger.kernel.org" Subject: [GIT PULL for-4.9 55/96] MIPS: Lantiq: Fix another request_mem_region() return code check Thread-Topic: [GIT PULL for-4.9 55/96] MIPS: Lantiq: Fix another request_mem_region() return code check Thread-Index: AQHTNWTIcd+bqKBMxUuIg+2dgdBu/A== Date: Sun, 24 Sep 2017 18:41:50 +0000 Message-ID: <20170924184130.29445-56-alexander.levin@verizon.com> References: <20170924184130.29445-1-alexander.levin@verizon.com> In-Reply-To: <20170924184130.29445-1-alexander.levin@verizon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit 98ea51cb0c8ce009d9da1fd7b48f0ff1d7a9bbb0 ] Hauke already fixed a couple of them, but one instance remains that checks for a negative integer when it should check for a NULL pointer: arch/mips/lantiq/xway/sysctrl.c: In function 'ltq_soc_init': arch/mips/lantiq/xway/sysctrl.c:473:19: error: ordered comparison of pointer with integer zero [-Werror=extra] Fixes: 6e807852676a ("MIPS: Lantiq: Fix check for return value of request_mem_region()") Signed-off-by: Arnd Bergmann Cc: John Crispin Cc: linux-mips@linux-mips.org Cc: linux-kernel@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/15043/ Signed-off-by: Ralf Baechle Signed-off-by: Sasha Levin --- arch/mips/lantiq/xway/sysctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.11.0 diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c index 90565477dfbd..95bec460b651 100644 --- a/arch/mips/lantiq/xway/sysctrl.c +++ b/arch/mips/lantiq/xway/sysctrl.c @@ -469,8 +469,8 @@ void __init ltq_soc_init(void) panic("Failed to load xbar nodes from devicetree"); if (of_address_to_resource(np_xbar, 0, &res_xbar)) panic("Failed to get xbar resources"); - if (request_mem_region(res_xbar.start, resource_size(&res_xbar), - res_xbar.name) < 0) + if (!request_mem_region(res_xbar.start, resource_size(&res_xbar), + res_xbar.name)) panic("Failed to get xbar resources"); ltq_xbar_membase = ioremap_nocache(res_xbar.start,