From patchwork Mon Feb 19 10:13:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 128785 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp3330077ljc; Mon, 19 Feb 2018 02:14:24 -0800 (PST) X-Google-Smtp-Source: AH8x2265lthc5IUPfTLZ6HrJAOlggS21AVZUSg6X6bdx/dlJfDoWDmV02U7ghK29cVkYWq7pSVHC X-Received: by 2002:a17:902:74c3:: with SMTP id f3-v6mr13835745plt.444.1519035264369; Mon, 19 Feb 2018 02:14:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519035264; cv=none; d=google.com; s=arc-20160816; b=E1z3Lp5ekkAH0qyg1e8u+0EfCarhLle6NRwuCBHhqDLk2wpa1kQaWXD0mexRio9KXe hdy2kEx9sPIdRPvplgDaIA0HtFIteabKiBWYPXe23J58NWFigBnDwE/M+8MvptOmimQJ 2LpB7EAC1FPUpktn+O7p0xOjzxqrPwY2q4nqUf73ZJBvoKXxG8HqbcKbyJKaSQk2V0L/ KPxNIXe6vciX7sJ323q5YmUjP/rISNjrp3YAE7mY/DT/ePqOTZs7B8PSSHiw2TNYB4xE 0o8WKn86R8PT0mr6mJMJeomayYJI1D0JI58Fvq696quR2gSKrWkt/9ZTq1AIHwi99HVh n7zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=YFWtT77g5ALI0menvTm90EKyKYJB1aPpo7vFfSVSVIA=; b=lzpyfGrAwlZBczWwojpltkp7UATc+ZJNm6wGAtooLKTkhyvFC+z3zUWBGkME/gzXju mPbX5Sef6mUlh4y0EwyMYUIpjeulV9cfQ8qZEno39ZTJ42RVn7hvQMecbitVrzFTjN19 6tvz5UHVHdN6alITzceI41PTZAcYDBMcRBjMu93Iyz/vGO6BBSyEK/rageB3V3SLyG3w kcmcYhY/PO6qGKRLsNsOpXr4ffUrrQPfHPAIWoud68/2tSI47zTimTKCOjeootAZI6ow Vj7y6TGwAwmpb12DJZuunzZ5hqLyUXVEXEpPY0Waf1qe4Cf9XAGcq9PhwTNRXXMytnb8 ei1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f6si596686pfe.188.2018.02.19.02.14.24; Mon, 19 Feb 2018 02:14:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752478AbeBSKOX (ORCPT + 10 others); Mon, 19 Feb 2018 05:14:23 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:39357 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752474AbeBSKOW (ORCPT ); Mon, 19 Feb 2018 05:14:22 -0500 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue006 [212.227.15.129]) with ESMTPA (Nemesis) id 0MW4Oi-1fGNFS1qe0-00X4NC; Mon, 19 Feb 2018 11:14:10 +0100 From: Arnd Bergmann To: stable@vger.kernel.org Cc: Greg KH , linux-kernel@vger.kernel.org, Arnd Bergmann , Mauro Carvalho Chehab , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Andrey Konovalov , Andrew Morton , Linus Torvalds , Sasha Levin , Sudip Mukherjee Subject: [4.9-stable 1/9] kasan: rework Kconfig settings Date: Mon, 19 Feb 2018 11:13:20 +0100 Message-Id: <20180219101343.2922561-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20180219101343.2922561-1-arnd@arndb.de> References: <20180219101343.2922561-1-arnd@arndb.de> X-Provags-ID: V03:K0:wKI57U609WKa1lDv4jC1sGo6PKTYdkxXbFOocblHPrnST6aXqia 3vfTiOzqVrJr7lCxOKSzyGapmNvi2xwhz+LHaHuR/Wtpk9K2wZ+doFDpG1jdyUk/BdvTFmM att7ca/Zby8GvqoYrVscTw7CmhI2AL2ciLXGmhbbpiR3JC+DxU+5wOoW2PCp8UooyBA7kMw hesnrWvd0XBA3IDktCPzw== X-UI-Out-Filterresults: notjunk:1; V01:K0:W5+vt5H1TxQ=:Jqwb5FSaeF7MD+wKzSjBJ4 EtaIYwYSy7EsOobPB7IXEUGvto4u71CSsi25+5Tm5kfayRyu9LNE+fDqVBonoQ1LTSXQJABcn ZQw+AtudpCZzps0oM07Q/zWnlMuKpqXzuPjoFTp7ZwhszjOeXcSviqggRktM96vousqiaN9xS n37vZW8vzQUk2RQtwNI2+NbvtZcz7shyMF2njWOlonXFQNI88nM+QWZe42prs8kcnovcXdJX9 ZL7xS8D5Ncv2tKYoR+Hjcx+7+SrdqiowQne0cjcn+GJZeQSW/sCtAbyj/+nsNzDEZm+ces8EX w6YWdQsuyR+8stZz0/uxHvJPVCqpo9WesC4DL0UTQNt0bDd0e5/6kBYPfvBJ6VviBxUH5w2Vv whw+HoGbcWQ0zMaCi5IS0Z10/h644nJczGOeaLctfdwA9H2MqXBapW8CJQG6uaI93GJM5U1ux EMFcW1X+nyel8vwdBS3wm6JG5RtXh1D7O+b77ycXxjsaqRMFUyoWLn0nKwnfIiyMHgMyHsBOD VtrMi25Gte8tak94aVH+l0nB64N7fOXTMeQjDhefg8l6i+Zi4RBa+0yjRdxZWYc1xjzkQ8BaV NAPxwbkZsGnKGok1hCeXUGoKwuUoH4WiP3NO/unp0wFOS9FUaKKlQyuiwohSKe9eO66Dofcte 87NEc0IICmyJjyHGhq9BAJoYwZ+cmFiDupr+nRwk5/pBfAhBGIDybHBzSLoHQkW1XTN5MENY3 bDwja4qB5QpHYMo2zV6CcjXKONyz+Y3b9s6oTw== Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org We get a lot of very large stack frames using gcc-7.0.1 with the default -fsanitize-address-use-after-scope --param asan-stack=1 options, which can easily cause an overflow of the kernel stack, e.g. drivers/gpu/drm/i915/gvt/handlers.c:2434:1: warning: the frame size of 46176 bytes is larger than 3072 bytes drivers/net/wireless/ralink/rt2x00/rt2800lib.c:5650:1: warning: the frame size of 23632 bytes is larger than 3072 bytes lib/atomic64_test.c:250:1: warning: the frame size of 11200 bytes is larger than 3072 bytes drivers/gpu/drm/i915/gvt/handlers.c:2621:1: warning: the frame size of 9208 bytes is larger than 3072 bytes drivers/media/dvb-frontends/stv090x.c:3431:1: warning: the frame size of 6816 bytes is larger than 3072 bytes fs/fscache/stats.c:287:1: warning: the frame size of 6536 bytes is larger than 3072 bytes To reduce this risk, -fsanitize-address-use-after-scope is now split out into a separate CONFIG_KASAN_EXTRA Kconfig option, leading to stack frames that are smaller than 2 kilobytes most of the time on x86_64. An earlier version of this patch also prevented combining KASAN_EXTRA with KASAN_INLINE, but that is no longer necessary with gcc-7.0.1. All patches to get the frame size below 2048 bytes with CONFIG_KASAN=y and CONFIG_KASAN_EXTRA=n have been merged by maintainers now, so we can bring back that default now. KASAN_EXTRA=y still causes lots of warnings but now defaults to !COMPILE_TEST to disable it in allmodconfig, and it remains disabled in all other defconfigs since it is a new option. I arbitrarily raise the warning limit for KASAN_EXTRA to 3072 to reduce the noise, but an allmodconfig kernel still has around 50 warnings on gcc-7. I experimented a bit more with smaller stack frames and have another follow-up series that reduces the warning limit for 64-bit architectures to 1280 bytes (without CONFIG_KASAN). With earlier versions of this patch series, I also had patches to address the warnings we get with KASAN and/or KASAN_EXTRA, using a "noinline_if_stackbloat" annotation. That annotation now got replaced with a gcc-8 bugfix (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715) and a workaround for older compilers, which means that KASAN_EXTRA is now just as bad as before and will lead to an instant stack overflow in a few extreme cases. This reverts parts of commit 3f181b4d8652 ("lib/Kconfig.debug: disable -Wframe-larger-than warnings with KASAN=y"). Two patches in linux-next should be merged first to avoid introducing warnings in an allmodconfig build: 3cd890dbe2a4 ("media: dvb-frontends: fix i2c access helpers for KASAN") 16c3ada89cff ("media: r820t: fix r820t_write_reg for KASAN") Do we really need to backport this? I think we do: without this patch, enabling KASAN will lead to unavoidable kernel stack overflow in certain device drivers when built with gcc-7 or higher on linux-4.10+ or any version that contains a backport of commit c5caf21ab0cf8. Most people are probably still on older compilers, but it will get worse over time as they upgrade their distros. The warnings we get on kernels older than this should all be for code that uses dangerously large stack frames, though most of them do not cause an actual stack overflow by themselves.The asan-stack option was added in linux-4.0, and commit 3f181b4d8652 ("lib/Kconfig.debug: disable -Wframe-larger-than warnings with KASAN=y") effectively turned off the warning for allmodconfig kernels, so I would like to see this fix backported to any kernels later than 4.0. I have done dozens of fixes for individual functions with stack frames larger than 2048 bytes with asan-stack, and I plan to make sure that all those fixes make it into the stable kernels as well (most are already there). Part of the complication here is that asan-stack (from 4.0) was originally assumed to always require much larger stacks, but that turned out to be a combination of multiple gcc bugs that we have now worked around and fixed, but sanitize-address-use-after-scope (from v4.10) has a much higher inherent stack usage and also suffers from at least three other problems that we have analyzed but not yet fixed upstream, each of them makes the stack usage more severe than it should be. Link: http://lkml.kernel.org/r/20171221134744.2295529-1-arnd@arndb.de Signed-off-by: Arnd Bergmann Acked-by: Andrey Ryabinin Cc: Mauro Carvalho Chehab Cc: Andrey Ryabinin Cc: Alexander Potapenko Cc: Dmitry Vyukov Cc: Andrey Konovalov Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds [arnd: rebase to v4.9; only re-enable warning] Signed-off-by: Arnd Bergmann --- lib/Kconfig.debug | 1 - 1 file changed, 1 deletion(-) -- 2.9.0 diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index f60e67217f18..58a22ca10f33 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -197,7 +197,6 @@ config ENABLE_MUST_CHECK config FRAME_WARN int "Warn for stack frames larger than (needs gcc 4.4)" range 0 8192 - default 0 if KASAN default 2048 if GCC_PLUGIN_LATENT_ENTROPY default 1024 if !64BIT default 2048 if 64BIT