From patchwork Thu Mar 1 15:27:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 130279 Delivered-To: patch@linaro.org Received: by 10.80.172.228 with SMTP id x91csp2952042edc; Thu, 1 Mar 2018 07:38:14 -0800 (PST) X-Google-Smtp-Source: AG47ELuv0bb4YN/VF/6q4MrlVVjx9awgS9OoZIxCUQBiztHgsgDe9sR99qKEQB1uIA7fgvoXmoT8 X-Received: by 10.99.49.208 with SMTP id x199mr351370pgx.424.1519918694628; Thu, 01 Mar 2018 07:38:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519918694; cv=none; d=google.com; s=arc-20160816; b=Cnzc5jeawL8/KjmXIJCUJ9XIm6+yZcnGuyxB0JRQWwbUGrFKZYEjSshUDY+dHMpbnG PwEMGjrKZGEcqPRYuT+RbooHvvlIJQ7UaSp0nGuGGxqig4PTeiZPnYcK9E236GwFYIC/ Sudb43giSUX1vCZAnzI30f9emp/0J4aG9vBwTRvWXO/odtwc4sj2ExprMXwb2W8Vgfpb eBmn9FiAQ+A+0mj36jSod1mvZd7D7Fr1QKlAamY5YLzwaY/ezb2HXs3nZJx2BwL6Li8Y MI8ODZ57pRbprNhufU3dWFZmWUY7MDWF2gAsxMF+7ASxDgcxI29rTos0yWP1UAjDod8g 5tpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=IAM3fTSoQLFtain7o8bFykLajswlCLLOIAoyqRka+4Y=; b=vRCRKiibB8g3RBRh4doBQlD8Nw07/BGBb2RQAPInmQopyKdKS0i+hYDBeAPpBJ6jOL a1WsRfw7Tw1JXfK8AXqxfV1iEOBzmjRtmj0ks/0aV8YFagZU9MeD+Y7U6BO4gPrzQm1k 5+jUrHBBWSFs+yyqXxPVx8iZGR8UOSqfi7YNcm6bEFrvHIoQdgkkVFoNy8FAwK79khOj Qt9b5SUslbD2p3aM5CfVwm46SapEmTeNOEDpRm2xnQIz8QOtq0UEtTu0jhJFjJEp8/HU aATzvwO2n0jd9Ldy3fquPNgEyo/lbRVHjKIo/q6bACqBBgX/E5BOgANLP0XLJNybapMP u4/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=dMa8VtLx; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d24-v6si3165005plr.615.2018.03.01.07.38.14; Thu, 01 Mar 2018 07:38:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=dMa8VtLx; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032551AbeCAPiL (ORCPT + 10 others); Thu, 1 Mar 2018 10:38:11 -0500 Received: from mail-by2nam03on0132.outbound.protection.outlook.com ([104.47.42.132]:24496 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1032282AbeCAPhk (ORCPT ); Thu, 1 Mar 2018 10:37:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=IAM3fTSoQLFtain7o8bFykLajswlCLLOIAoyqRka+4Y=; b=dMa8VtLx9nOkblkYlYA1kUbua9u8tNfIp3PdQgIXI9sN+jNpXxbFYKbavK9woqkA9QOhD16D/eWjkzt7QTWK+lvEzo9XHdpgbC1Icl8A/7Dk04HqMbwYhKiXgl12WRQePhAD8nxr7yJhO3SEBhtzvOiIhqt7uSj7Ic+BfXs4MT4= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1014.namprd21.prod.outlook.com (52.132.133.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.3; Thu, 1 Mar 2018 15:37:37 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446%2]) with mapi id 15.20.0567.006; Thu, 1 Mar 2018 15:37:37 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "stable-commits@vger.kernel.org" CC: Arnd Bergmann , Greg Kroah-Hartman , Sasha Levin Subject: [added to the 4.1 stable tree] isdn: icn: remove a #warning Thread-Topic: [added to the 4.1 stable tree] isdn: icn: remove a #warning Thread-Index: AQHTsXHA8IkuSJZWH0uaB61m4CFX5w== Date: Thu, 1 Mar 2018 15:27:04 +0000 Message-ID: <20180301152116.1486-428-alexander.levin@microsoft.com> References: <20180301152116.1486-1-alexander.levin@microsoft.com> In-Reply-To: <20180301152116.1486-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB1014; 7:/DxxbXIAfWQV5pFCIFG+8JLtpKYbpD9hU6sXq7pj7D9p53rEAepyG5CAkWDAFC2WUNVtWEyDIvKCfFTb8HSwIhMRi5RjDaBH4qSjEoT0+oRDwq5augxV5biulgT3MKJVNr+kDWi5EseKzE1AsqXHPZKGLIH4W6ItgCRY9wRJ/sOQqdu9XVTDTNPgzaKTqtMjvvFVGxzy21OKEgTwXzL94wWNM3A1ZJOiY/Nb0Z6Mtk++aX3gm3AHfgt6FjAmmDyc x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: a1c38ebb-5e30-4e5b-f12d-08d57f8a5c6e x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020); SRVR:DM5PR2101MB1014; x-ms-traffictypediagnostic: DM5PR2101MB1014: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(3231220)(944501228)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(61426038)(61427038)(6041288)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:DM5PR2101MB1014; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB1014; x-forefront-prvs: 05986C03E0 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(39380400002)(346002)(39860400002)(376002)(396003)(199004)(189003)(53936002)(2906002)(3280700002)(6436002)(6486002)(3846002)(6512007)(6306002)(2900100001)(6116002)(2950100002)(107886003)(6666003)(72206003)(5660300001)(966005)(36756003)(10090500001)(3660700001)(14454004)(7736002)(305945005)(97736004)(1076002)(22452003)(26005)(6506007)(105586002)(86362001)(575784001)(59450400001)(478600001)(68736007)(102836004)(4326008)(6346003)(54906003)(110136005)(81156014)(81166006)(86612001)(8936002)(186003)(10290500003)(8676002)(76176011)(316002)(2501003)(66066001)(25786009)(5250100002)(106356001)(99286004)(22906009); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB1014; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-message-info: /Uj/t8gmTymXhY9sRp98mujhq8j0VmRfuYmSw8aCR9Aqd2eW2lB0cwLmWXIMPdqnyMAQr5AZu4FxM3ffaYbwF02CPdb881/ELPs1BMSVjeJ2ZlFy3sc6tS8VC15EXJzBfXCvpv5Q9UypHa9GOPhC1t/NISLaWR2k9/mdg2EfuWo= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1c38ebb-5e30-4e5b-f12d-08d57f8a5c6e X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2018 15:27:04.9073 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1014 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann This patch has been added to the 4.1 stable tree. If you have any objections, please let us know. -- 2.14.1 =============== [ Upstream commit 01ed1e1504ac83a8b0b365c9f55d3427babbd7d9 ] The icn driver currently produces an unconditional #warning whenever we build it, introduced by Karsten Keil back in 2003: #warning TODO test headroom or use skb->nb to flag ACK Karsten's original commit (from BitKeeper) contains this description: - here are lot of bugs left, so ISDN is not stable yet but I think it's really time to fix it, even if it need some cycles to get it right (normally I'm only send patches if it works 100% for me). - I add some additional #warnings to address places which need fixing (I hope that some of the other ISDN developer jump in) Apparently this has not happened, and it is unlikely that it ever will, given that the driver doesn't seem to work. No substantial bug fixes other than janitorial cleanups have happened in the driver since then, and I see no indication that anyone who patched it had the hardware. We should probably either remove the driver, or remove all of i4l, but for now, this shuts up the distracting #warning by turning it into a comment. Signed-off-by: Arnd Bergmann Link: http://git.meleeweb.net/linux.git/commit/?id=b0deac0886b0056765afd149e9834373b38e096b Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/isdn/icn/icn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/icn/icn.c b/drivers/isdn/icn/icn.c index 358a574d9e8b..46d957c34be1 100644 --- a/drivers/isdn/icn/icn.c +++ b/drivers/isdn/icn/icn.c @@ -718,7 +718,7 @@ icn_sendbuf(int channel, int ack, struct sk_buff *skb, icn_card *card) return 0; if (card->sndcount[channel] > ICN_MAX_SQUEUE) return 0; -#warning TODO test headroom or use skb->nb to flag ACK + /* TODO test headroom or use skb->nb to flag ACK */ nskb = skb_clone(skb, GFP_ATOMIC); if (nskb) { /* Push ACK flag as one