From patchwork Thu Mar 8 04:56:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 130963 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp6129638lja; Wed, 7 Mar 2018 23:06:52 -0800 (PST) X-Google-Smtp-Source: AG47ELtfvetdXL98AzFzqZD6MAUmAQ7HBLRuDxRjUPu/G+6IRwJnrxenqerjeKexxlZB6L1htAwm X-Received: by 2002:a17:902:365:: with SMTP id 92-v6mr23270524pld.127.1520492812229; Wed, 07 Mar 2018 23:06:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520492812; cv=none; d=google.com; s=arc-20160816; b=k0pAFQQ/451YN4yFzIzfVaVzWPiEPghTRZ78Dt7Vj26Np5ikaBgxttVM+JgUip/4Xm YWgzMALaBuA5Hg0Ka8tWEHEafZxUNtOH9zu0aYXzm7DB67Od6pjo9zmm01HD/kCmIF9D RQHjaRliGvGDYLEuhFn23qvt5z/586ASsvqS1NuxNboq3E4+MWSUWMxlDjuhjV7J4tfe 9Ttk1P7aO2YbstM8Va6GuSWYqq4+N+fOsuxUNRpXTYj92XBWH7dmC3373fDdTJ1ENSa9 V+ztVg20T/J8aDQrvkJdeNRA6bvLc9cfQR5FpmKK6hRvQqt9G7lKDUS0nZeXfOdaiNGB zTEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=AkJhVfJ1nAur6Od7PlwDuH0UJiq+I5seQQeV+TnQWkY=; b=XBNlQqBYDXplbhKWIdwdhQes3mm7oU0Qz+5Zx35Hc0R4fgK4uYM08Ed4Fi6FFZkUrW y7DhFsMYSO4xUvYxqUyT0aACbP5fVojVa1ay792sDlvPyvIbFvaBpn+Hfj85jmEy784u BaxQFrU48WTz+eXnJE3mGLoyhd7odiJjr+uwOHZOtPpt/qYGHmFCPk/0VSEyTByHTy5H 3mzfk15uXpiNaMqcuTAFJpa6hiKlT3CSi4xgCU2Y3tBtsgu6BHvggbE5XdJ5qskfBV3Z ciw+d0mztvzNWLMsXT9YvGqydwyOwi8bYFz0G8MR6eAbZmoTgtHsN4s8aSQGxdQGYKvH S+pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=buaclLtb; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v9-v6si999608ply.677.2018.03.07.23.06.52; Wed, 07 Mar 2018 23:06:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=buaclLtb; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935211AbeCHHGs (ORCPT + 10 others); Thu, 8 Mar 2018 02:06:48 -0500 Received: from mail-bn3nam01on0138.outbound.protection.outlook.com ([104.47.33.138]:1475 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755242AbeCHE4d (ORCPT ); Wed, 7 Mar 2018 23:56:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AkJhVfJ1nAur6Od7PlwDuH0UJiq+I5seQQeV+TnQWkY=; b=buaclLtbXTaaXSrlw6aXBc3Wf1JtDVW5SftuKBT8gXYBRexij4s99cKgoUjIXK6hDRvymsOO1HS57Y8WDfWghdgfSmj2iwCbdBnDuCNX3mGBE6PXuHb3dUZzyIweSH21lf6I39NKKq+Yn6Bu2vvUARJMFbfeM0O7zVf+hurU1zc= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1111.namprd21.prod.outlook.com (52.132.132.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.588.3; Thu, 8 Mar 2018 04:56:29 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446%2]) with mapi id 15.20.0588.008; Thu, 8 Mar 2018 04:56:29 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Arnd Bergmann , Benson Leung , Sasha Levin Subject: [PATCH AUTOSEL for 4.15 27/78] cros_ec: fix nul-termination for firmware build info Thread-Topic: [PATCH AUTOSEL for 4.15 27/78] cros_ec: fix nul-termination for firmware build info Thread-Index: AQHTtpnINuqVhkibPEWrL5W0z5iSTg== Date: Thu, 8 Mar 2018 04:56:13 +0000 Message-ID: <20180308045525.7662-27-alexander.levin@microsoft.com> References: <20180308045525.7662-1-alexander.levin@microsoft.com> In-Reply-To: <20180308045525.7662-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB1111; 20:VnUoaT3wO8ZAOXzW9F4jOV743E8yvAXnzwTIXmtaKeoAeIJVDi9PRqAi2UTTfz6QGn9ChKTtN06D/c5VnxB7SXT5iLfQVl7KP+aSCNfSHC52J4yzXeM1vQRnEAI20HcFWi1PRtz/k/e8N1QO5T8ChYO6KLqb33ObRP24C6jiBdM= x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 3189a659-43d4-4ef7-2547-08d584b0f484 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020); SRVR:DM5PR2101MB1111; x-ms-traffictypediagnostic: DM5PR2101MB1111: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(20558992708506)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(3231220)(944501244)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(61426038)(61427038)(6041288)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:DM5PR2101MB1111; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB1111; x-forefront-prvs: 060503E79B x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39380400002)(346002)(396003)(376002)(39860400002)(366004)(199004)(189003)(86612001)(22452003)(99286004)(7736002)(54906003)(305945005)(86362001)(5660300001)(66066001)(6512007)(81156014)(14454004)(53936002)(2900100001)(10090500001)(1076002)(110136005)(107886003)(575784001)(6116002)(6436002)(3846002)(72206003)(36756003)(102836004)(316002)(3280700002)(3660700001)(478600001)(106356001)(6486002)(76176011)(6666003)(81166006)(10290500003)(4326008)(2950100002)(97736004)(25786009)(59450400001)(105586002)(8676002)(26005)(2501003)(2906002)(5250100002)(8936002)(186003)(68736007)(6506007)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB1111; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: p/FWpahbnoF9iordOLw/nxUieiasydh30YaZONdQ+cokKKnhmipbHFlBDGx+eSM/uc03x0zxAt6dgFBvWNLBwryMt4FfUxNKsOjRyZ4ZqA+pfXHKyTpvBgoK9aBn9sv13BNZNrnlXYvCQs25nzWTYmUBBkhsZAJLFkEudZRdIfolwtxnQQ9cQH4fOXJLZb9weH9JfNcLhNNb1r8OuuptDvXFTzc1B3li06HTF6RXZkz9s4wCSUDi2d7SKeitgtF9630ijZJIB3s/BHA1bW42zTWBu9vWfDpeB3rPWrLAMIviBiP333fId7a4v/sXAHTli5Q6hmyBnibcCIEuoFirLw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3189a659-43d4-4ef7-2547-08d584b0f484 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2018 04:56:13.0950 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1111 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit 50a0d71a5d20e1d3eff1d974fdc8559ad6d74892 ] As gcc-8 reports, we zero out the wrong byte: drivers/platform/chrome/cros_ec_sysfs.c: In function 'show_ec_version': drivers/platform/chrome/cros_ec_sysfs.c:190:12: error: array subscript 4294967295 is above array bounds of 'uint8_t[]' [-Werror=array-bounds] This changes the code back to what it did before changing to a zero-length array structure. Fixes: a841178445bb ("mfd: cros_ec: Use a zero-length array for command data") Signed-off-by: Arnd Bergmann Signed-off-by: Benson Leung Signed-off-by: Sasha Levin --- drivers/platform/chrome/cros_ec_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.14.1 diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b/drivers/platform/chrome/cros_ec_sysfs.c index f3baf9973989..24f1630a8b3f 100644 --- a/drivers/platform/chrome/cros_ec_sysfs.c +++ b/drivers/platform/chrome/cros_ec_sysfs.c @@ -187,7 +187,7 @@ static ssize_t show_ec_version(struct device *dev, count += scnprintf(buf + count, PAGE_SIZE - count, "Build info: EC error %d\n", msg->result); else { - msg->data[sizeof(msg->data) - 1] = '\0'; + msg->data[EC_HOST_PARAM_SIZE - 1] = '\0'; count += scnprintf(buf + count, PAGE_SIZE - count, "Build info: %s\n", msg->data); }