From patchwork Thu May 23 19:06:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 165057 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp2621670ili; Thu, 23 May 2019 12:28:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqweTwp6rrlOTKHSWn/TqPpQHKtaqTO+5M/TwtsyK02EekWXO5vbl0ympnW/WFdEkczjWK43 X-Received: by 2002:a17:90a:d98d:: with SMTP id d13mr3608883pjv.64.1558639713009; Thu, 23 May 2019 12:28:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558639713; cv=none; d=google.com; s=arc-20160816; b=URIIt6Cf96yptqzb6XDbe9ywGQozsDVOsYuNIl7f392RZZiCS8cr+hO+W6HZPRFgjv Z7gfU3Gl/yCicRwtQoO4RiPkKZpcReHCTyLkNj2FhGEfPNy6kJvq2E1/WLWPyLqrKFef IxIGTDBI8TA+ERw+XYQLSsyQr9l5EnMmUIcZXLUP8PYJZptUoTyCZRgTt1R957BU151b IK/9awsgIOhQyASmzFZjWk4usnjp+9pXZORB9wOQjltLB1w2lRTlaCrNnBg6u6tRX+U5 9LhHyuitoUKPWOMnMQYLK+kdilKWC5CZ+s/8ZQ+g+j7S3CdCfM8SvSfxBfhn1YX5fklk 1Chg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=W1mDgfBUXhLh4PL2dyGfGaNdoLApP2LvxFEfejhEUaU=; b=KXXOq7HjPEq3ejRjhED8rj0Rku8lrrwVinDPC2CLXJ3NcBVLsOVB8tr24vf/JIRZnv VVww+S0O3VBA5ApvImDbLQ1YWRpKNUknd/KwF3iEFBs2FvgwaI+EcN4sr28Gn1zP+mtq ZqizHYpA4jB41F65eoT6+B8YdB6/ZHk+KF2I0VW8KkHKUEDweTL9CeFtPkgcm3RdL5Gr 1kX6gY+BN3x1AhkP+tdrmfJqg/3QW6sDAG7qmxhklZMY+ApuHSeklMcjWVnVxi0GnVuG V31WoGGM5DSf3JEDObKvOQPUw40aNNckYIkPmtUn5F/NCohweFIrh0eWlm+5Dcxm5ty3 xuYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JSEJ65Lx; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p22si589065plo.341.2019.05.23.12.28.32; Thu, 23 May 2019 12:28:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JSEJ65Lx; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391497AbfEWT2b (ORCPT + 14 others); Thu, 23 May 2019 15:28:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:41156 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403755AbfEWT2b (ORCPT ); Thu, 23 May 2019 15:28:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DD10121841; Thu, 23 May 2019 19:28:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558639710; bh=UMvC08lni5aLyINag6W8qHVq+hf79X6rzLlABvFa1xc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JSEJ65Lx6sjLmlEhZTKmYxzciKcC/2es1fQK5YrMX85KGn2IMxJjYDIGzK8j9gm6D kYukHYlJF/O2VldNmJHWaIbCGw+mY9deWEARZB3s6W/9cHMoS9UnLv5Tz8p6OFY1w0 fMRxiZ9LShg1/LoWSx6WGd8RTitubGxTNsFG2ARY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Sean Young , Mauro Carvalho Chehab Subject: [PATCH 5.1 050/122] media: seco-cec: fix building with RC_CORE=m Date: Thu, 23 May 2019 21:06:12 +0200 Message-Id: <20190523181711.322318490@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190523181705.091418060@linuxfoundation.org> References: <20190523181705.091418060@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann commit 63604a143fe168094fbbccba56f6e3241683e399 upstream. I previously added an RC_CORE dependency here, but missed the corner case of CONFIG_VIDEO_SECO_CEC=y with CONFIG_RC_CORE=m, which still causes a link error: drivers/media/platform/seco-cec/seco-cec.o: In function `secocec_probe': seco-cec.c:(.text+0x1b8): undefined reference to `devm_rc_allocate_device' seco-cec.c:(.text+0x2e8): undefined reference to `devm_rc_register_device' drivers/media/platform/seco-cec/seco-cec.o: In function `secocec_irq_handler': seco-cec.c:(.text+0xa2c): undefined reference to `rc_keydown' Refine the dependency to disallow building the RC subdriver in this case. This is the same logic we apply in other drivers like it. Fixes: f27dd0ad6885 ("media: seco-cec: fix RC_CORE dependency") Cc: # 5.1 Signed-off-by: Arnd Bergmann Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -649,7 +649,7 @@ config VIDEO_SECO_CEC config VIDEO_SECO_RC bool "SECO Boards IR RC5 support" depends on VIDEO_SECO_CEC - depends on RC_CORE + depends on RC_CORE=y || RC_CORE = VIDEO_SECO_CEC help If you say yes here you will get support for the SECO Boards Consumer-IR in seco-cec driver.