From patchwork Thu Jan 2 22:06:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 234700 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E609CC3276C for ; Thu, 2 Jan 2020 22:34:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BAD3220863 for ; Thu, 2 Jan 2020 22:34:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578004491; bh=De4uJhC6i2INSoXv3P3kQHEpFN2Uywk+3NT+AykBCuc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=XI9QZpVPxyvXCAfPzcfb4M8vO0AkzP9TxuX0RfUjB8Jcg+N4sEE5MVwzeX74g5zzO IvcbXcWmua7u3C4v9dI56G9CJEK94saM3l2IqHoHhBXVYe4rXr2fbtXygV8yVdYCRh c2SCRGQfQ7BmB1TI8obt9AJK+wz6SRjUVMUS39r4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730592AbgABWeu (ORCPT ); Thu, 2 Jan 2020 17:34:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:43838 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730507AbgABWes (ORCPT ); Thu, 2 Jan 2020 17:34:48 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F357320863; Thu, 2 Jan 2020 22:34:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578004487; bh=De4uJhC6i2INSoXv3P3kQHEpFN2Uywk+3NT+AykBCuc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yLRjjPFjsh/v5wvolO+Wky6/QnCFyRIYq1RVkSQstw1qQzCqYJ92340tGzTdQwTns iKWGMvkJ0ugYv6XIDm+3JXQAE8jjtvCA9A7Qm917vLfKg4uULHuaQYx2Kdw0Y7hIGl pmGl2e+9uKK9XyrbKUrRBzucmfr7v0+d/0eLobjQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lukasz Majewski , Mark Brown , kbuild test robot , Sasha Levin Subject: [PATCH 4.4 007/137] spi: Add call to spi_slave_abort() function when spidev driver is released Date: Thu, 2 Jan 2020 23:06:20 +0100 Message-Id: <20200102220547.639847436@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200102220546.618583146@linuxfoundation.org> References: <20200102220546.618583146@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Lukasz Majewski [ Upstream commit 9f918a728cf86b2757b6a7025e1f46824bfe3155 ] This change is necessary for spidev devices (e.g. /dev/spidev3.0) working in the slave mode (like NXP's dspi driver for Vybrid SoC). When SPI HW works in this mode - the master is responsible for providing CS and CLK signals. However, when some fault happens - like for example distortion on SPI lines - the SPI Linux driver needs a chance to recover from this abnormal situation and prepare itself for next (correct) transmission. This change doesn't pose any threat on drivers working in master mode as spi_slave_abort() function checks if SPI slave mode is supported. Signed-off-by: Lukasz Majewski Link: https://lore.kernel.org/r/20190924110547.14770-2-lukma@denx.de Signed-off-by: Mark Brown Reported-by: kbuild test robot Link: https://lore.kernel.org/r/20190925091143.15468-2-lukma@denx.de Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spidev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index c5f1045561ac..3709088d4d24 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -662,6 +662,9 @@ static int spidev_release(struct inode *inode, struct file *filp) if (dofree) kfree(spidev); } +#ifdef CONFIG_SPI_SLAVE + spi_slave_abort(spidev->spi); +#endif mutex_unlock(&device_list_lock); return 0;