diff mbox series

[4.4,075/137] mod_devicetable: fix PHY module format

Message ID	20200102220556.759324709@linuxfoundation.org
State	New
Headers	show Return-Path: <SRS0=x1Uk=2X=vger.kernel.org=stable-owner@kernel.org> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>, Russell King <rmk+kernel@armlinux.org.uk>, Florian Fainelli <f.fainelli@gmail.com>, "David S. Miller" <davem@davemloft.net> Subject: [PATCH 4.4 075/137] mod_devicetable: fix PHY module format Date: Thu, 2 Jan 2020 23:07:28 +0100 Message-Id: <20200102220556.759324709@linuxfoundation.org> In-Reply-To: <20200102220546.618583146@linuxfoundation.org> References: <20200102220546.618583146@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk
Series	None \| expand [4.4,004/137] ALSA: hda/ca0132 - Avoid endless loop [4.4,006/137] iio: light: bh1750: Resolve compiler warning and make code more readable [4.4,007/137] spi: Add call to spi_slave_abort() function when spidev driver is released [4.4,010/137] IB/iser: bound protection_sg size by data_sg size [4.4,013/137] media: i2c: ov2659: Fix missing 720p register config [4.4,014/137] media: ov6650: Fix stored frame format not in sync with hardware [4.4,015/137] tools/power/cpupower: Fix initializer override in hsw_ext_cstates [4.4,016/137] usb: renesas_usbhs: add suspend event support in gadget mode [4.4,017/137] hwrng: omap3-rom - Call clk_disable_unprepare() on exit only if not idled [4.4,019/137] media: flexcop-usb: fix NULL-ptr deref in flexcop_usb_transfer_init() [4.4,021/137] mwifiex: pcie: Fix memory leak in mwifiex_pcie_init_evt_ring [4.4,024/137] media: ti-vpe: vpe: Make sure YUYV is set as default format [4.4,025/137] extcon: sm5502: Reset registers during initialization [4.4,027/137] perf report: Add warning when libunwind not compiled in [4.4,029/137] Bluetooth: hci_core: fix init for HCI_USER_CHANNEL [4.4,032/137] arm64: psci: Reduce the waiting time for cpu_psci_cpu_kill() [4.4,034/137] pinctrl: sh-pfc: sh7734: Fix duplicate TCLK1_B [4.4,038/137] perf probe: Fix to find range-only function instance [4.4,039/137] perf probe: Fix to list probe event with correct line number [4.4,041/137] perf probe: Fix to probe an inline function which has no entry pc [4.4,045/137] perf probe: Return a better scope DIE if there is no best scope [4.4,047/137] perf probe: Skip end-of-sequence and non statement lines [4.4,049/137] ath10k: fix get invalid tx rate for Mesh metric [4.4,050/137] media: pvrusb2: Fix oops on tear-down when radio support is not present [4.4,051/137] media: si470x-i2c: add missed operations in remove [4.4,052/137] EDAC/ghes: Fix grain calculation [4.4,055/137] parport: load lowlevel driver if ports not found [4.4,056/137] cpufreq: Register drivers only after CPU devices have been registered [4.4,057/137] x86/crash: Add a forward declaration of struct kimage [4.4,061/137] fbtft: Make sure string is NULL terminated [4.4,063/137] crypto: vmx - Avoid weird build failures [4.4,065/137] net: phy: initialise phydev speed and duplex sanely [4.4,068/137] btrfs: do not call synchronize_srcu() in inode_tree_del [4.4,069/137] btrfs: return error pointer from alloc_test_extent_buffer [4.4,070/137] btrfs: abort transaction after failed inode updates in create_subvol [4.4,072/137] ALSA: pcm: Avoid possible info leaks from PCM stream buffers [4.4,075/137] mod_devicetable: fix PHY module format [4.4,077/137] net: nfc: nci: fix a possible sleep-in-atomic-context bug in nci_uart_tty_receive() [4.4,079/137] net: usb: lan78xx: Fix suspend/resume PHY register access error [4.4,080/137] sctp: fully initialize v4 addr in some functions [4.4,081/137] net: dst: Force 4-byte alignment of dst_metrics [4.4,084/137] platform/x86: hp-wmi: Make buffer for HPWMI_FEATURE2_QUERY 128 bytes [4.4,087/137] powerpc/irq: fix stack overflow verification [4.4,089/137] perf probe: Fix to show function entry line as probe-able [4.4,090/137] scsi: mpt3sas: Fix clear pending bit in ioctl status [4.4,095/137] scsi: lpfc: Fix SLI3 hba in loop mode not discovering devices [4.4,096/137] scsi: csiostor: Dont enable IRQs too early [4.4,098/137] dma-debug: add a schedule point in debug_dma_dump_mappings() [4.4,099/137] clocksource/drivers/asm9260: Add a check for of_clk_get [4.4,101/137] jbd2: Fix statistics for the number of logged blocks [4.4,102/137] scsi: tracing: Fix handling of TRANSFER LENGTH == 0 for READ(6) and WRITE(6) [4.4,105/137] irqchip/irq-bcm7038-l1: Enable parent IRQ if necessary [4.4,106/137] irqchip: ingenic: Error out if IRQ domain creation failed [4.4,108/137] fs/quota: handle overflows of sysctl fs.quota.* and report as unsigned long [4.4,113/137] clk: pxa: fix one of the pxa RTC clocks [4.4,115/137] HID: Improve Windows Precision Touchpad detection. [4.4,117/137] scsi: pm80xx: Fix for SATA device discovery [4.4,119/137] gpio: mpc8xxx: Dont overwrite default irq_set_type callback [4.4,120/137] scripts/kallsyms: fix definitely-lost memory leak [4.4,123/137] libfdt: define INT32_MAX and UINT32_MAX in libfdt_env.h [4.4,125/137] ocfs2: fix passing zero to PTR_ERR warning [4.4,127/137] ALSA: hda - Downgrade error message for single-cmd fallback [4.4,128/137] Make filldir[64]() verify the directory entry filename is valid [4.4,130/137] net: davinci_cpdma: use dma_addr_t for DMA address [4.4,131/137] netfilter: ebtables: compat: reject all padding in matches/watchers [4.4,133/137] netfilter: bridge: make sure to pull arp header in br_nf_forward_arp() [4.4,135/137] hrtimer: Annotate lockless access to timer->state [4.4,136/137] mmc: sdhci: Update the tuning failed messages to pr_debug level

Commit Message

Greg KH Jan. 2, 2020, 10:07 p.m. UTC

From: Russell King <rmk+kernel@armlinux.org.uk>

[ Upstream commit d2ed49cf6c13e379c5819aa5ac20e1f9674ebc89 ]

When a PHY is probed, if the top bit is set, we end up requesting a
module with the string "mdio:-10101110000000100101000101010001" -
the top bit is printed to a signed -1 value. This leads to the module
not being loaded.

Fix the module format string and the macro generating the values for
it to ensure that we only print unsigned types and the top bit is
always 0/1. We correctly end up with
"mdio:10101110000000100101000101010001".

Fixes: 8626d3b43280 ("phylib: Support phy module autoloading")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 include/linux/mod_devicetable.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff mbox series

Patch

--- a/include/linux/mod_devicetable.h
+++ b/include/linux/mod_devicetable.h
@@ -502,9 +502,9 @@  struct platform_device_id {
 
 #define MDIO_MODULE_PREFIX	"mdio:"
 
-#define MDIO_ID_FMT "%d%d%d%d%d%d%d%d%d%d%d%d%d%d%d%d%d%d%d%d%d%d%d%d%d%d%d%d%d%d%d%d"
+#define MDIO_ID_FMT "%u%u%u%u%u%u%u%u%u%u%u%u%u%u%u%u%u%u%u%u%u%u%u%u%u%u%u%u%u%u%u%u"
 #define MDIO_ID_ARGS(_id) \
-	(_id)>>31, ((_id)>>30) & 1, ((_id)>>29) & 1, ((_id)>>28) & 1,	\
+	((_id)>>31) & 1, ((_id)>>30) & 1, ((_id)>>29) & 1, ((_id)>>28) & 1, \
 	((_id)>>27) & 1, ((_id)>>26) & 1, ((_id)>>25) & 1, ((_id)>>24) & 1, \
 	((_id)>>23) & 1, ((_id)>>22) & 1, ((_id)>>21) & 1, ((_id)>>20) & 1, \
 	((_id)>>19) & 1, ((_id)>>18) & 1, ((_id)>>17) & 1, ((_id)>>16) & 1, \