From patchwork Tue Jan 7 20:53:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 234387 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78C0EC282DD for ; Tue, 7 Jan 2020 21:04:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D255214D8 for ; Tue, 7 Jan 2020 21:04:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578431065; bh=uC+QLzBMiSo2zy/Qp/KYlZZxIGvBdlhLhbjUGsv0+uY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=R/i1Ao7oKxHIb+10pk1D0qRrUKA3GAT4Lnofm7SDeAt6W8/g7BLNogfevRG98hcbZ D+BTuKsoWHv84kA8s3YwKlxklLUJ+FWpQQmoi7fG2dstb/3yGnyN6gHxvy3vBS4tqL l4rnnsEBdPvLLGJlzJHHXwn3mKfVySVuWgxx+Spo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728850AbgAGVEY (ORCPT ); Tue, 7 Jan 2020 16:04:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:48534 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728569AbgAGVEX (ORCPT ); Tue, 7 Jan 2020 16:04:23 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 04AE820880; Tue, 7 Jan 2020 21:04:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578431063; bh=uC+QLzBMiSo2zy/Qp/KYlZZxIGvBdlhLhbjUGsv0+uY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wn2zMSV0k8JXjqyUGB3yQYdZOspqo7NnFCOjhvi3YkZMXtXRIg+BTN0jT/wq62H5T DKkJ11Lf9YY80lMCsZL7NzM1gtYH8c/40LO6pSZwh1mcxiKZKy8G3JCbRmlbQiHMbt xDlJtI0oWYpVYaZKEo9bBIoRFWz5puZ75VcELeh8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Krishna Kant , Alexei Potashnik , Quinn Tran , Himanshu Madhani , Hannes Reinecke , Roman Bolshakov , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.19 019/115] scsi: qla2xxx: Send Notify ACK after N2N PLOGI Date: Tue, 7 Jan 2020 21:53:49 +0100 Message-Id: <20200107205253.870588539@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200107205240.283674026@linuxfoundation.org> References: <20200107205240.283674026@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Roman Bolshakov [ Upstream commit 5e6b01d84b9d20bcd77fc7c4733a2a4149bf220a ] qlt_handle_login schedules session for deletion even if a login is in progress. That causes login bouncing, i.e. a few logins are made before it settles down. Complete the first login by sending Notify Acknowledge IOCB via qlt_plogi_ack_unref if the session is pending login completion. Fixes: 9cd883f07a54 ("scsi: qla2xxx: Fix session cleanup for N2N") Cc: Krishna Kant Cc: Alexei Potashnik Link: https://lore.kernel.org/r/20191125165702.1013-11-r.bolshakov@yadro.com Acked-by: Quinn Tran Acked-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Tested-by: Hannes Reinecke Signed-off-by: Roman Bolshakov Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_target.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 8eda55e917e0..e9545411ec5a 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -4779,6 +4779,7 @@ static int qlt_handle_login(struct scsi_qla_host *vha, switch (sess->disc_state) { case DSC_DELETED: + case DSC_LOGIN_PEND: qlt_plogi_ack_unref(vha, pla); break;