From patchwork Fri Jan 24 09:29:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 233199 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE92EC2D0DB for ; Fri, 24 Jan 2020 09:54:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6852214DB for ; Fri, 24 Jan 2020 09:54:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859657; bh=dfvrLCjUuNwlPrEBLjqxka2nipU725v7isZIiKzbVn0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Z58BQK123L3NHie1ApeWjkEvYQMBxQo1fQsiFzOg3biOMri8r5eplspx3o2TxP/WX DdBeesE0UOhNkjp51Y7uoS0ZPTdGdGcyp/Bb/5qQYSHtjCcSqStEUp/F0E8allHter mds8klgqK3cNEbNZQUe7FRa4HD+DWxmpSgE1oRow= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388184AbgAXJyR (ORCPT ); Fri, 24 Jan 2020 04:54:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:57226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731584AbgAXJyQ (ORCPT ); Fri, 24 Jan 2020 04:54:16 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 79AFE208C4; Fri, 24 Jan 2020 09:54:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859656; bh=dfvrLCjUuNwlPrEBLjqxka2nipU725v7isZIiKzbVn0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QWCVbJPL+vFKHiLM9gvGe056WqDdgoMQgbqUWPSejXwnu+VV9F7AHCmAjz/pFeb7N 3SXjMVxCT4iVxTmVKTkx/3+khFvmbouZ+gDOv4AGVod0eVOmTE2fzuUaVZDqbAhwuC QXE012X/Z8smRED1+IxX96PsV9TJdEADw5fQ4vFY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, YueHaibing , Robert Jarzmik , Sasha Levin Subject: [PATCH 4.14 166/343] ARM: pxa: ssp: Fix "WARNING: invalid free of devm_ allocated data" Date: Fri, 24 Jan 2020 10:29:44 +0100 Message-Id: <20200124092941.838256692@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: YueHaibing [ Upstream commit 9ee8578d953023cc57e7e736ae48502c707c0210 ] Since commit 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions") kfree, iounmap, clk_put etc are not needed anymore in remove path. Fixes: 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions") Signed-off-by: YueHaibing [ commit message spelling fix ] Signed-off-by: Robert Jarzmik Signed-off-by: Sasha Levin --- arch/arm/plat-pxa/ssp.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c index b92673efffffb..97bd43c16cd87 100644 --- a/arch/arm/plat-pxa/ssp.c +++ b/arch/arm/plat-pxa/ssp.c @@ -230,18 +230,12 @@ static int pxa_ssp_probe(struct platform_device *pdev) static int pxa_ssp_remove(struct platform_device *pdev) { - struct resource *res; struct ssp_device *ssp; ssp = platform_get_drvdata(pdev); if (ssp == NULL) return -ENODEV; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - release_mem_region(res->start, resource_size(res)); - - clk_put(ssp->clk); - mutex_lock(&ssp_lock); list_del(&ssp->node); mutex_unlock(&ssp_lock);