From patchwork Mon Feb 10 12:32:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 231633 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F7C4C352A3 for ; Mon, 10 Feb 2020 13:33:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7083820715 for ; Mon, 10 Feb 2020 13:33:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581341638; bh=Ass9Qglo5YTankLhHR3RLmxch4QTiOoSFpOhVzRIISk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=P5OzPCCugMuP4Vq7V14ytfnny7UysqagDli3d+IhuHGr+RWnv3I5cQ9PS6a8vz6E7 YNzpbIOSpSXMXBaSLejGgpxFmad/PMzmsqLz9vHVpiE9yPiKg9ZDNPLK/qEDu/Nkys NpGlpGBrvjSFDvCAvKI9Nkrk1I5l8ugFa1X1Yh7E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731362AbgBJNdu (ORCPT ); Mon, 10 Feb 2020 08:33:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:52932 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727981AbgBJMfc (ORCPT ); Mon, 10 Feb 2020 07:35:32 -0500 Received: from localhost (unknown [209.37.97.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4EB0720661; Mon, 10 Feb 2020 12:35:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581338132; bh=Ass9Qglo5YTankLhHR3RLmxch4QTiOoSFpOhVzRIISk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=diqxIHK7oPWB6YoaN9SUq4vbSRPmlx0AfS9rmL5pDBv9RE1drDkknLJOsbginjdPg v72mLhsHSvedKI/bF7nC9EddeeTMFeo8nqJappnQ/TY/5Et9Qa5cnuc6qq0R5VA8KE 5aqdS0HcAEsfU9R7ljF8gbU6j58Z/67+Ltn2rJdI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Geert Uytterhoeven , Jonathan Corbet Subject: [PATCH 4.19 077/195] scripts/find-unused-docs: Fix massive false positives Date: Mon, 10 Feb 2020 04:32:15 -0800 Message-Id: <20200210122313.188611771@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200210122305.731206734@linuxfoundation.org> References: <20200210122305.731206734@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Geert Uytterhoeven commit 1630146db2111412e7524d05d812ff8f2c75977e upstream. scripts/find-unused-docs.sh invokes scripts/kernel-doc to find out if a source file contains kerneldoc or not. However, as it passes the no longer supported "-text" option to scripts/kernel-doc, the latter prints out its help text, causing all files to be considered containing kerneldoc. Get rid of these false positives by removing the no longer supported "-text" option from the scripts/kernel-doc invocation. Cc: stable@vger.kernel.org # 4.16+ Fixes: b05142675310d2ac ("scripts: kernel-doc: get rid of unused output formats") Signed-off-by: Geert Uytterhoeven Link: https://lore.kernel.org/r/20200127093107.26401-1-geert+renesas@glider.be Signed-off-by: Jonathan Corbet Signed-off-by: Greg Kroah-Hartman --- scripts/find-unused-docs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/scripts/find-unused-docs.sh +++ b/scripts/find-unused-docs.sh @@ -54,7 +54,7 @@ for file in `find $1 -name '*.c'`; do if [[ ${FILES_INCLUDED[$file]+_} ]]; then continue; fi - str=$(scripts/kernel-doc -text -export "$file" 2>/dev/null) + str=$(scripts/kernel-doc -export "$file" 2>/dev/null) if [[ -n "$str" ]]; then echo "$file" fi