Return-Path: <SRS0=Wx/U=4B=vger.kernel.org=stable-owner@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 218A2C3B18C for <stable@archiver.kernel.org>; Thu, 13 Feb 2020 15:58:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E56CC217F4 for <stable@archiver.kernel.org>; Thu, 13 Feb 2020 15:58:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581609539; bh=od7zeOreRAXcHWXUSpsD6viNKergL7vkryhJ+LZGCng=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=beKqmHYPGnJXtSCGbHDqO3KS/ncNo4jspt4i7hQSb6jWo0SgDZY3DIYnRWlYNCosB R8cWUUXpYxFxwRWR+4FkCbF74477kRNZqeNOO8Ms+m2N/DOOVv5mlUu80z1zIq18V9 eXmLJGi/vQsFrM3PtImFHMV3YY1eXf/fMEsr/9jA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727608AbgBMP6u (ORCPT <rfc822;stable@archiver.kernel.org>); Thu, 13 Feb 2020 10:58:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:39818 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728425AbgBMPZC (ORCPT <rfc822;stable@vger.kernel.org>); Thu, 13 Feb 2020 10:25:02 -0500 Received: from localhost (unknown [104.132.1.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B6A7224690; Thu, 13 Feb 2020 15:25:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581607501; bh=od7zeOreRAXcHWXUSpsD6viNKergL7vkryhJ+LZGCng=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DUieTuUfgaPPQwPUHb2PA4v/3hCz8pH9mzg7jHqdyI/HrWwJdA11pu+6+/2er2AMx VLR+03l9l1N3UV8fOUSNjc9eizJ3G1bjiVVaTSo7ZV3A9TJeZeUWDAos0k6DX3qcBC onewE+voS6WpVT5386cOi4w33VzKzxU9aJ4TVKhM= From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Kevin Hao <haokexin@gmail.com>, Marc Zyngier <maz@kernel.org> Subject: [PATCH 4.14 029/173] irqdomain: Fix a memory leak in irq_domain_push_irq() Date: Thu, 13 Feb 2020 07:18:52 -0800 Message-Id: <20200213151940.940633671@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200213151931.677980430@linuxfoundation.org> References: <20200213151931.677980430@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: <stable.vger.kernel.org> X-Mailing-List: stable@vger.kernel.org
From: Kevin Hao <haokexin@gmail.com> commit 0f394daef89b38d58c91118a2b08b8a1b316703b upstream. Fix a memory leak reported by kmemleak: unreferenced object 0xffff000bc6f50e80 (size 128): comm "kworker/23:2", pid 201, jiffies 4294894947 (age 942.132s) hex dump (first 32 bytes): 00 00 00 00 41 00 00 00 86 c0 03 00 00 00 00 00 ....A........... 00 a0 b2 c6 0b 00 ff ff 40 51 fd 10 00 80 ff ff ........@Q...... backtrace: [<00000000e62d2240>] kmem_cache_alloc_trace+0x1a4/0x320 [<00000000279143c9>] irq_domain_push_irq+0x7c/0x188 [<00000000d9f4c154>] thunderx_gpio_probe+0x3ac/0x438 [<00000000fd09ec22>] pci_device_probe+0xe4/0x198 [<00000000d43eca75>] really_probe+0xdc/0x320 [<00000000d3ebab09>] driver_probe_device+0x5c/0xf0 [<000000005b3ecaa0>] __device_attach_driver+0x88/0xc0 [<000000004e5915f5>] bus_for_each_drv+0x7c/0xc8 [<0000000079d4db41>] __device_attach+0xe4/0x140 [<00000000883bbda9>] device_initial_probe+0x18/0x20 [<000000003be59ef6>] bus_probe_device+0x98/0xa0 [<0000000039b03d3f>] deferred_probe_work_func+0x74/0xa8 [<00000000870934ce>] process_one_work+0x1c8/0x470 [<00000000e3cce570>] worker_thread+0x1f8/0x428 [<000000005d64975e>] kthread+0xfc/0x128 [<00000000f0eaa764>] ret_from_fork+0x10/0x18 Fixes: 495c38d3001f ("irqdomain: Add irq_domain_{push,pop}_irq() functions") Signed-off-by: Kevin Hao <haokexin@gmail.com> Signed-off-by: Marc Zyngier <maz@kernel.org> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20200120043547.22271-1-haokexin@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- kernel/irq/irqdomain.c | 1 + 1 file changed, 1 insertion(+)
--- a/kernel/irq/irqdomain.c +++ b/kernel/irq/irqdomain.c @@ -1538,6 +1538,7 @@ int irq_domain_push_irq(struct irq_domai if (rv) { /* Restore the original irq_data. */ *root_irq_data = *child_irq_data; + kfree(child_irq_data); goto error; }