From patchwork Thu Mar 19 13:03:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 229097 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E71E2C4332E for ; Thu, 19 Mar 2020 13:16:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B69F020724 for ; Thu, 19 Mar 2020 13:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584623795; bh=P1Cv3fel8WKmU0E8OLq16QVgX3hV8+DnzSpL2TRqCKQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ODE0GjyDuNxXhHlUUsNUPTXUixw+p2hFtHNIHHnkDWy1syVTbea9yPu+fHz/O7T6e EfcV0y0qiWeNagMzzTZI9ClMYvv3b0EvxVFSGY68TgLHfL+8yD492KXseGuRIxuJNc i1JtCZoILtGfw7ZXV13nwJX58FAuO+xPfBGoJwCA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727138AbgCSNQf (ORCPT ); Thu, 19 Mar 2020 09:16:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:37084 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728859AbgCSNQe (ORCPT ); Thu, 19 Mar 2020 09:16:34 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 75E55216FD; Thu, 19 Mar 2020 13:16:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584623793; bh=P1Cv3fel8WKmU0E8OLq16QVgX3hV8+DnzSpL2TRqCKQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BeXw0M0J9yXUmjE/998M9E01PIYpntC+r9V8G7JWouEccWLiWYCRXp/wyakTOEcn1 BWlMb85XE9wsbooIQ9kyh3yfs7HFe/qJj3YEOKcDj+RwwsjHR32XjDs3P9ziOeLeNN xKtuoJvCHiKL1wyzZf0SHslC9qFYlo6u8ymyWZRQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Charles Keepax , Linus Walleij Subject: [PATCH 4.14 55/99] pinctrl: core: Remove extra kref_get which blocks hogs being freed Date: Thu, 19 Mar 2020 14:03:33 +0100 Message-Id: <20200319123958.564985744@linuxfoundation.org> X-Mailer: git-send-email 2.25.2 In-Reply-To: <20200319123941.630731708@linuxfoundation.org> References: <20200319123941.630731708@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Charles Keepax commit aafd56fc79041bf36f97712d4b35208cbe07db90 upstream. kref_init starts with the reference count at 1, which will be balanced by the pinctrl_put in pinctrl_unregister. The additional kref_get in pinctrl_claim_hogs will increase this count to 2 and cause the hogs to not get freed when pinctrl_unregister is called. Fixes: 6118714275f0 ("pinctrl: core: Fix pinctrl_register_and_init() with pinctrl_enable()") Signed-off-by: Charles Keepax Link: https://lore.kernel.org/r/20200228154142.13860-1-ckeepax@opensource.cirrus.com Signed-off-by: Linus Walleij Signed-off-by: Greg Kroah-Hartman --- drivers/pinctrl/core.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -2031,7 +2031,6 @@ static int pinctrl_claim_hogs(struct pin return PTR_ERR(pctldev->p); } - kref_get(&pctldev->p->users); pctldev->hog_default = pinctrl_lookup_state(pctldev->p, PINCTRL_STATE_DEFAULT); if (IS_ERR(pctldev->hog_default)) {