From patchwork Thu Mar 19 13:04:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 229088 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06C88C4332B for ; Thu, 19 Mar 2020 13:18:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0D67206D7 for ; Thu, 19 Mar 2020 13:18:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584623906; bh=ip0Zp0+YNOXcVYAm9P+nrD0aOp6Hxhhd2Oa4CbV0I1A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LZ4wjs3ctcpH5id7BtKF1L+K8FeJ77SPHGqK5UgPgi0oJb7nmvtm0hNRlpuONBJ2+ cVdu21mvuVZwpmk5LUkfyZWnh/rzK98hqVwgl6VTkIVRF65WN6H+T+sg7wjs8izfRw xYknpE6TNS2dkWteIH8+tVcpYhglM7k6MliUIAmg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729034AbgCSNSZ (ORCPT ); Thu, 19 Mar 2020 09:18:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:40604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729785AbgCSNSX (ORCPT ); Thu, 19 Mar 2020 09:18:23 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C8F1921556; Thu, 19 Mar 2020 13:18:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584623903; bh=ip0Zp0+YNOXcVYAm9P+nrD0aOp6Hxhhd2Oa4CbV0I1A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZWRlDMMwZh0owGtMJnkR0Wp4uQ5Jxqwro/OtAO3G18IlppARjRGYGaUs5YXGC2Fru gr8xdKZPHfuM94AwYYQkdY8lA5mt+GG7o9FTgoVwwI0VMppkcfePUTes70Eg9JAIq8 cWqFAQM8gPPoAK8d4vqJpnVPJzM3fJYIxfKzEZZs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, yangerkun , Oliver Hartkopp , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 92/99] slip: not call free_netdev before rtnl_unlock in slip_open Date: Thu, 19 Mar 2020 14:04:10 +0100 Message-Id: <20200319124007.093433693@linuxfoundation.org> X-Mailer: git-send-email 2.25.2 In-Reply-To: <20200319123941.630731708@linuxfoundation.org> References: <20200319123941.630731708@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: yangerkun [ Upstream commit f596c87005f7b1baeb7d62d9a9e25d68c3dfae10 ] As the description before netdev_run_todo, we cannot call free_netdev before rtnl_unlock, fix it by reorder the code. Signed-off-by: yangerkun Reviewed-by: Oliver Hartkopp Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/slip/slip.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/slip/slip.c b/drivers/net/slip/slip.c index b07f367abd915..d7882b548b79a 100644 --- a/drivers/net/slip/slip.c +++ b/drivers/net/slip/slip.c @@ -867,7 +867,10 @@ static int slip_open(struct tty_struct *tty) tty->disc_data = NULL; clear_bit(SLF_INUSE, &sl->flags); sl_free_netdev(sl->dev); + /* do not call free_netdev before rtnl_unlock */ + rtnl_unlock(); free_netdev(sl->dev); + return err; err_exit: rtnl_unlock();