From patchwork Wed Apr 1 16:16:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 228290 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52497C43331 for ; Wed, 1 Apr 2020 16:56:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F14520714 for ; Wed, 1 Apr 2020 16:56:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585760160; bh=DfNGjTiudtEt3OA0uTaA0pmUfogkjBLImsS9OuaHvYE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=qsidaqLNjou4T96akTgI6MH75gTLLXWAHehWn6ppi1EkYppMWYzImNuT860mH8XiV SuFTmP1xLO8xIatbH0qxR5zfGITNhcAx4Sh9Ls6Hel/oOrd3fOfXh+Y3rdFSJ7dHEj E/RfrPYxMae90y2N2YMcTtZxIAsHyKaXm3V4mCrQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387525AbgDAQz7 (ORCPT ); Wed, 1 Apr 2020 12:55:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:46386 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733222AbgDAQXK (ORCPT ); Wed, 1 Apr 2020 12:23:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 27D53214D8; Wed, 1 Apr 2020 16:23:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585758189; bh=DfNGjTiudtEt3OA0uTaA0pmUfogkjBLImsS9OuaHvYE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hnu8/hBMigqp0LODp1Hk5DZgEx7ZoybltqXVcaupwGB/3uJUikiwxu9koDzWxdruY 9U7+9xJt/O6yKNzUlXhfBSRH1RHFBcNtiGatTpvs0pVoDTMqDHISr8wnWFDL5ShFkN UNPlI8kKUwk0us6pG644FA4dPW1x9ofnz6Zfc170= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Maxime Bizon , Florian Fainelli , Vivien Didelot , "David S. Miller" Subject: [PATCH 4.19 012/116] net: dsa: Fix duplicate frames flooded by learning Date: Wed, 1 Apr 2020 18:16:28 +0200 Message-Id: <20200401161543.661131044@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161542.669484650@linuxfoundation.org> References: <20200401161542.669484650@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Florian Fainelli [ Upstream commit 0e62f543bed03a64495bd2651d4fe1aa4bcb7fe5 ] When both the switch and the bridge are learning about new addresses, switch ports attached to the bridge would see duplicate ARP frames because both entities would attempt to send them. Fixes: 5037d532b83d ("net: dsa: add Broadcom tag RX/TX handler") Reported-by: Maxime Bizon Signed-off-by: Florian Fainelli Reviewed-by: Vivien Didelot Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/dsa/tag_brcm.c | 2 ++ 1 file changed, 2 insertions(+) --- a/net/dsa/tag_brcm.c +++ b/net/dsa/tag_brcm.c @@ -141,6 +141,8 @@ static struct sk_buff *brcm_tag_rcv_ll(s /* Remove Broadcom tag and update checksum */ skb_pull_rcsum(skb, BRCM_TAG_LEN); + skb->offload_fwd_mark = 1; + return skb; }