From patchwork Wed Apr 22 09:57:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 227287 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 213DBC55186 for ; Wed, 22 Apr 2020 10:13:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9DA12071E for ; Wed, 22 Apr 2020 10:13:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587550418; bh=PMPsZAyKkO1vYVopSB3WRyEZCJka8hrgwZwx7kCYqug=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Z8XhStLsepei+damJfsiHkGUiX2z3ur3AVRiQdg1FqIWl9RYdZeuIvmD73O2H1Hfw sfjsyslAZpez+2QoXYClbKfQw1UbD1kCpNLU4pJqQPEge2hyplKt8frms1/rTIiYCp c6fN1fJgP0NEi5oeAFhppXVlUd6IPWKxrdwsZqeY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726224AbgDVKNg (ORCPT ); Wed, 22 Apr 2020 06:13:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:47416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728657AbgDVKN2 (ORCPT ); Wed, 22 Apr 2020 06:13:28 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DDBCB2070B; Wed, 22 Apr 2020 10:13:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587550408; bh=PMPsZAyKkO1vYVopSB3WRyEZCJka8hrgwZwx7kCYqug=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YEVPxg7ypOKwDjda62uh9irBXFHWCmPGLv8wVnHr9f3tV4G0wl0f2HaquZXXO0wuq 4wPgwaVeSoB02f5ampB+YstHv350Bic3dm6K9RRYebm8Q8ZWvz0DlFncallf0sXHnh mXMfWD9rzB4u+753J+aInTJTnjdNw/Om+AFhBeeo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sebastian Andrzej Siewior , Tom Lendacky , "David S. Miller" Subject: [PATCH 4.14 106/199] amd-xgbe: Use __napi_schedule() in BH context Date: Wed, 22 Apr 2020 11:57:12 +0200 Message-Id: <20200422095108.379952068@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095057.806111593@linuxfoundation.org> References: <20200422095057.806111593@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Sebastian Andrzej Siewior [ Upstream commit d518691cbd3be3dae218e05cca3f3fc9b2f1aa77 ] The driver uses __napi_schedule_irqoff() which is fine as long as it is invoked with disabled interrupts by everybody. Since the commit mentioned below the driver may invoke xgbe_isr_task() in tasklet/softirq context. This may lead to list corruption if another driver uses __napi_schedule_irqoff() in IRQ context. Use __napi_schedule() which safe to use from IRQ and softirq context. Fixes: 85b85c853401d ("amd-xgbe: Re-issue interrupt if interrupt status not cleared") Signed-off-by: Sebastian Andrzej Siewior Acked-by: Tom Lendacky Cc: Tom Lendacky Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c @@ -515,7 +515,7 @@ static void xgbe_isr_task(unsigned long xgbe_disable_rx_tx_ints(pdata); /* Turn on polling */ - __napi_schedule_irqoff(&pdata->napi); + __napi_schedule(&pdata->napi); } } else { /* Don't clear Rx/Tx status if doing per channel DMA