From patchwork Mon May 18 17:35:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 225557 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13EB5C433E0 for ; Mon, 18 May 2020 18:28:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E04A3207D3 for ; Mon, 18 May 2020 18:28:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589826534; bh=xmOIEw70a5FE80g1DFmUn2FjbmTpBNFJhhp4JZAkVjw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=nJ93iskD/QS+yIjJ9iz8kXMQKod+qpwSgBeCrHVlt+dL7BhOp12kJWFKcB3Z83rrO nBYFtxI3xINNmbW6fuDuIJv9mvTt8LlrdSiaBLOkxWel+A911L3YnxM2WTVNlmQXrh feJhAX0OQWGo89C7ZIsrM94f+7TjwtEkLtuRv+mY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729975AbgERS2x (ORCPT ); Mon, 18 May 2020 14:28:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:39428 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729420AbgERRm0 (ORCPT ); Mon, 18 May 2020 13:42:26 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CFEEC20829; Mon, 18 May 2020 17:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589823746; bh=xmOIEw70a5FE80g1DFmUn2FjbmTpBNFJhhp4JZAkVjw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fpMvkncp9QwiHG1oHOZHMzd0Nkf7d4NQyXQO0FnjqOgplTl/0x/Wom3A96XbINqpo phvwK/zLtGmIoQotedlL8EJ/ESYnwAZqF+5rDDvBxgKV3/BZL7tcegVhmxblOWCZDJ 5/7rCFgbTM9Y3tneJigb2MQqP7nVmVOayJ6hB9pY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Julia Lawall , "David S. Miller" Subject: [PATCH 4.9 02/90] dp83640: reverse arguments to list_add_tail Date: Mon, 18 May 2020 19:35:40 +0200 Message-Id: <20200518173451.432316239@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200518173450.930655662@linuxfoundation.org> References: <20200518173450.930655662@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Julia Lawall [ Upstream commit 865308373ed49c9fb05720d14cbf1315349b32a9 ] In this code, it appears that phyter_clocks is a list head, based on the previous list_for_each, and that clock->list is intended to be a list element, given that it has just been initialized in dp83640_clock_init. Accordingly, switch the arguments to list_add_tail, which takes the list head as the second argument. Fixes: cb646e2b02b27 ("ptp: Added a clock driver for the National Semiconductor PHYTER.") Signed-off-by: Julia Lawall Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/phy/dp83640.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/phy/dp83640.c +++ b/drivers/net/phy/dp83640.c @@ -1108,7 +1108,7 @@ static struct dp83640_clock *dp83640_clo goto out; } dp83640_clock_init(clock, bus); - list_add_tail(&phyter_clocks, &clock->list); + list_add_tail(&clock->list, &phyter_clocks); out: mutex_unlock(&phyter_clocks_lock);