From patchwork Mon May 18 17:36:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 225550 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48CAAC433E0 for ; Mon, 18 May 2020 18:30:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EE1920657 for ; Mon, 18 May 2020 18:30:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589826606; bh=+YDyGxiPU6HgZ0QqhhHYusz2iCtZUh4TaMWN612TJMw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=WgoU0dtl0Ekxpg6KyFgbQGZjbkq3BFo77TYzRWNt0nvChc13QIfg8mQfs7bmOQxZN hNPS+CxCTJVXqds2fw4ERpPiQGRSrmoPy2WmuYQVlMyIhI/9VpJq3++j2dwO617Obz MXPPxWxeQnqp9o3Rj8JdMn7jxWESOJvoORvEtqkY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729780AbgERS36 (ORCPT ); Mon, 18 May 2020 14:29:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:37618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728478AbgERRlU (ORCPT ); Mon, 18 May 2020 13:41:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E03420715; Mon, 18 May 2020 17:41:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589823679; bh=+YDyGxiPU6HgZ0QqhhHYusz2iCtZUh4TaMWN612TJMw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JckdDQRK0XOTiQLh0lw7zs+lB9Rg7zV49bx/07PuUZHq8Rl1mowMMFD8uHKjQ+43s bCiQQOZr4xxS9hJ16iuUxmPeUpP1/cBa4uHagVBv91DIUpRRBrorqP4sPUh5JXPNbp KEOMABYNK4wckbr7UT0b/6TcCNERwX9b9IiB1fN8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Felipe Balbi Subject: [PATCH 4.4 79/86] usb: gadget: net2272: Fix a memory leak in an error handling path in net2272_plat_probe() Date: Mon, 18 May 2020 19:36:50 +0200 Message-Id: <20200518173506.597367557@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200518173450.254571947@linuxfoundation.org> References: <20200518173450.254571947@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Christophe JAILLET commit ccaef7e6e354fb65758eaddd3eae8065a8b3e295 upstream. 'dev' is allocated in 'net2272_probe_init()'. It must be freed in the error handling path, as already done in the remove function (i.e. 'net2272_plat_remove()') Fixes: 90fccb529d24 ("usb: gadget: Gadget directory cleanup - group UDC drivers") Signed-off-by: Christophe JAILLET Signed-off-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/udc/net2272.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/usb/gadget/udc/net2272.c +++ b/drivers/usb/gadget/udc/net2272.c @@ -2670,6 +2670,8 @@ net2272_plat_probe(struct platform_devic err_req: release_mem_region(base, len); err: + kfree(dev); + return ret; }