From patchwork Tue Jun 23 19:58:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 191571 Delivered-To: patch@linaro.org Received: by 2002:a54:3249:0:0:0:0:0 with SMTP id g9csp1346866ecs; Tue, 23 Jun 2020 13:51:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzjWitUaHOtQgBCFcl3elmt3gZbUGfYi7kjea4EFHP7y1zsD1g+IlOLqV+/lobeM6rhXX5 X-Received: by 2002:aa7:ccc2:: with SMTP id y2mr23023859edt.97.1592945502375; Tue, 23 Jun 2020 13:51:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592945502; cv=none; d=google.com; s=arc-20160816; b=obS40aKlsvrWOMALJCtT+nP+bnHzqTfNtXyesitoIF3A1LfUg8N7/kzJ9Bc1sAEmZ8 2tbwlq4oFa5Jezu9A4c4S90x7J+Y50OBDNBobGKbztgE+PH7aZc6JptPVhTDYMqhFKEQ /ItrrlCQ+fdEaTH781+WJWGFrSnEZ7tO90P5W2mFwmTDGS9eTS9kJd7iekqDUEObzZsL xYdayRTmFLsM20UfqZLiRWzhic1AJLp+97eoYJRTVNHY5Oc3mEEzw/XALKWcJDY9x5KE QhP9xOCHDf7ilc4se/ix3187Irm8gfSsQ/U/OmjqGUnRFwh3ghS1mkM+Ylfg0MDAib/x zAwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fhdUBTuWqzw8uxcUYRNHUbygzmUE+eSQpb6X2949v08=; b=xk9u5Nqr273zcjN0mbotvSSvCtGIGNApoM6YwRt/ZgrK3KH+7yumHZEGz4YCsZtRmZ 154WGJfOH+ogFx86kwlmC+VHrCHlnk6clv4snfFKfv6bN4nVwmwh1++xtkcu8xbz20lP JGe1rlNr5xR40yRmIOcRxsgbJUTGe3QpjlxaLrBd1Cp17B3iRf09ode74rK+xx5TvfYw u6oHoFDvGfn5/GYvWKnLsqO1bwW8phKlNuWNrPIX+oBaqZLNshKuDKbtwpa+SGXMHN4W z30We79P7hUg08NfwV88kSFMVhIfofOMxWCTKofLKFTD0EwnzBu4ZB9lB9YjWs1FN4Fw m6RA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="A/LdWTZN"; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f15si2937138edt.552.2020.06.23.13.51.42; Tue, 23 Jun 2020 13:51:42 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="A/LdWTZN"; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392633AbgFWUvl (ORCPT + 15 others); Tue, 23 Jun 2020 16:51:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:46462 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387547AbgFWUru (ORCPT ); Tue, 23 Jun 2020 16:47:50 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0273320781; Tue, 23 Jun 2020 20:47:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945270; bh=a4CwcrJ/b+6dG6PyeIawfDbhllvX8ea47Bp08Yw/DgM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A/LdWTZNyKGVXEj6At3NgHBIMdCzZv43IUU7wVvQ1Xi2CuMaXag0npUWrZ8Ut+2gu tUhQ/zlQZ+sebv4rDpoqflhqEAJNWCRYSyVQJjlPOKbONgfI6K56O39bPz4o9tt6DG XR/ttgsIOxyU7Tl+/BxAgThnB66p2PFv405H5IZU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marek Szyprowski , Sylwester Nawrocki , Sasha Levin Subject: [PATCH 4.14 065/136] clk: samsung: exynos5433: Add IGNORE_UNUSED flag to sclk_i2s1 Date: Tue, 23 Jun 2020 21:58:41 +0200 Message-Id: <20200623195306.961636697@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195303.601828702@linuxfoundation.org> References: <20200623195303.601828702@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Marek Szyprowski [ Upstream commit 25bdae0f1c6609ceaf55fe6700654f0be2253d8e ] Mark the SCLK clock for Exynos5433 I2S1 device with IGNORE_UNUSED flag to match its behaviour with SCLK clock for AUD_I2S (I2S0) device until a proper fix for Exynos I2S driver is ready. This fixes the following synchronous abort issue revealed by the probe order change caused by the commit 93d2e4322aa7 ("of: platform: Batch fwnode parsing when adding all top level devices") Internal error: synchronous external abort: 96000210 [#1] PREEMPT SMP Modules linked in: CPU: 0 PID: 50 Comm: kworker/0:1 Not tainted 5.7.0-rc5+ #701 Hardware name: Samsung TM2E board (DT) Workqueue: events deferred_probe_work_func pstate: 60000005 (nZCv daif -PAN -UAO) pc : samsung_i2s_probe+0x768/0x8f0 lr : samsung_i2s_probe+0x688/0x8f0 ... Call trace: samsung_i2s_probe+0x768/0x8f0 platform_drv_probe+0x50/0xa8 really_probe+0x108/0x370 driver_probe_device+0x54/0xb8 __device_attach_driver+0x90/0xc0 bus_for_each_drv+0x70/0xc8 __device_attach+0xdc/0x140 device_initial_probe+0x10/0x18 bus_probe_device+0x94/0xa0 deferred_probe_work_func+0x70/0xa8 process_one_work+0x2a8/0x718 worker_thread+0x48/0x470 kthread+0x134/0x160 ret_from_fork+0x10/0x1c Code: 17ffffaf d503201f f94086c0 91003000 (88dffc00) ---[ end trace ccf721c9400ddbd6 ]--- Signed-off-by: Marek Szyprowski Signed-off-by: Sylwester Nawrocki Signed-off-by: Sasha Levin --- drivers/clk/samsung/clk-exynos5433.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c index 1d2265f9ee974..1c327d5de98cb 100644 --- a/drivers/clk/samsung/clk-exynos5433.c +++ b/drivers/clk/samsung/clk-exynos5433.c @@ -1674,7 +1674,8 @@ static const struct samsung_gate_clock peric_gate_clks[] __initconst = { GATE(CLK_SCLK_PCM1, "sclk_pcm1", "sclk_pcm1_peric", ENABLE_SCLK_PERIC, 7, CLK_SET_RATE_PARENT, 0), GATE(CLK_SCLK_I2S1, "sclk_i2s1", "sclk_i2s1_peric", - ENABLE_SCLK_PERIC, 6, CLK_SET_RATE_PARENT, 0), + ENABLE_SCLK_PERIC, 6, + CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, 0), GATE(CLK_SCLK_SPI2, "sclk_spi2", "sclk_spi2_peric", ENABLE_SCLK_PERIC, 5, CLK_SET_RATE_PARENT, 0), GATE(CLK_SCLK_SPI1, "sclk_spi1", "sclk_spi1_peric", ENABLE_SCLK_PERIC,